Re: Review Request 120155: Correctly load non-square icons in KIconLoader

2014-10-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120155/#review67754 --- So, iconthemes aren't made for non-square icons. So why not sk

Re: Review Request 120099: RFC: UI-Files inside resources instead of filesystem

2014-10-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120099/#review67755 --- Ship it! Sounds like a great idea to me. Apart from the small

Re: kio_trash

2014-10-01 Thread David Faure
On Monday 22 September 2014 22:26:06 David Faure wrote: > On Saturday 13 September 2014 20:29:18 Luigi Toscano wrote: > > Luigi Toscano ha scritto: > > > Nicolás Alvarez ha scritto: > > >> 2014-09-13 15:13 GMT-03:00 Nicolás Alvarez : > > >>> Done. The resulting history looks kind of weird though, b

Re: Replacement for kde4_add_app_icon ?

2014-10-01 Thread David Faure
On Tuesday 19 August 2014 23:26:42 Marko Käning wrote: > On 12 Aug 2014, at 12:52 , Albert Astals Cid wrote: > > Hi, i've been porting some of my apps to KF5 work and I'm noticing there > > doesn't seem to be (or i can't find) a replacement for kde4_add_app_icon. > > > > This seems like a problem

Re: kconfigwidgets should install have kf5_entry.desktop

2014-10-01 Thread David Faure
On Tuesday 30 September 2014 20:25:59 Albert Astals Cid wrote: > I can see the kconfigwidget commit to install kf5_entry.desktop but can't > find any commit in release-tools that copies the .desktop files over. Oops, it helps if I "git push". Done now. http://commits.kde.org/sysadmin/release-too

Re: kdelibs4support does not contain any .po

2014-10-01 Thread David Faure
On Wednesday 17 September 2014 23:07:50 Albert Astals Cid wrote: > El Dimecres, 17 de setembre de 2014, a les 22:53:35, David Faure va escriure: > > On Monday 15 September 2014 23:12:19 Albert Astals Cid wrote: > > > Hi David, kf-ers > > > > > > I can't find any .po inside kdelibs4support tarball

Review Request 120448: Fix initial size of KCMultiDialog

2014-10-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120448/ --- Review request for KDE Frameworks. Bugs: 325897 and 337494 https://bu

Re: Review Request 120448: Fix initial size of KCMultiDialog

2014-10-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120448/#review67762 --- +1 from me. - David Edmundson On Oct. 1, 2014, 1:24 p.m., A

Re: Review Request 120448: Fix initial size of KCMultiDialog

2014-10-01 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120448/#review67764 --- Ship it! src/kcmultidialog.h

Re: Review Request 120448: Fix initial size of KCMultiDialog

2014-10-01 Thread Christoph Feck
> On Oct. 1, 2014, 2:50 p.m., Christoph Feck wrote: > > src/kcmultidialog.cpp, line 260 > > > > > > type* v -> type *v I hate RB... what I wanted to say is that the * has to be moved to the variable, not to the

Review Request 120449: Avoid infinite recursion in KSNI

2014-10-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120449/ --- Review request for KDE Frameworks. Repository: knotifications Descripti

Re: Review Request 120243: Remove fallback QSystemTray support

2014-10-01 Thread David Edmundson
> On Sept. 17, 2014, 12:55 p.m., Aleix Pol Gonzalez wrote: > > Maybe we want to ifdef it? We won't require Qt 5.4 in a while... > > David Edmundson wrote: > It doesn't require Qt5.4. > > Martin Gräßlin wrote: > +1 for removing the fallback. > > Luigi Toscano wrote: > I guess the if

Re: Review Request 120422: Fix build with Qt 5.4 - Implement SystemTrayMenuItem::setIconSize

2014-10-01 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120422/#review67769 --- src/platformtheme/kdeplatformsystemtrayicon.cpp

Review Request 120450: Implement KDEPlatformSystemTrayIcon::isSystemTrayAvailable()

2014-10-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120450/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Re: Review Request 120449: Avoid infinite recursion in KSNI

2014-10-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120449/ --- (Updated Oct. 1, 2014, 4:43 p.m.) Review request for KDE Frameworks. Re

Re: Review Request 120449: Avoid infinite recursion in KSNI

2014-10-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120449/ --- (Updated Oct. 1, 2014, 4:43 p.m.) Review request for KDE Frameworks. Re

Re: Review Request 120448: Fix initial size of KCMultiDialog

2014-10-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120448/ --- (Updated Oct. 1, 2014, 4:51 p.m.) Status -- This change has been mar

Re: Review Request 120422: Fix build with Qt 5.4 - Implement SystemTrayMenuItem::setIconSize

2014-10-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120422/ --- (Updated Oct. 1, 2014, 4:57 p.m.) Status -- This change has been mar

Re: Review Request 120450: Implement KDEPlatformSystemTrayIcon::isSystemTrayAvailable()

2014-10-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120450/#review67772 --- Isn't that blocking? Do we know when it's called? - Aleix Pol

Jenkins build became unstable: ktexteditor_master_qt5 #696

2014-10-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120450: Implement KDEPlatformSystemTrayIcon::isSystemTrayAvailable()

2014-10-01 Thread David Edmundson
> On Oct. 1, 2014, 4:57 p.m., Aleix Pol Gonzalez wrote: > > Isn't that blocking? Do we know when it's called? yes it is. but it's a static method and there is no change signal. There isn't really any other option (without changing Qt). - David ---

Re: kio_trash

2014-10-01 Thread Nicolás Alvarez
2014-10-01 4:49 GMT-03:00 David Faure : > On Monday 22 September 2014 22:26:06 David Faure wrote: >> On Saturday 13 September 2014 20:29:18 Luigi Toscano wrote: >> > Luigi Toscano ha scritto: >> > > Nicolás Alvarez ha scritto: >> > >> 2014-09-13 15:13 GMT-03:00 Nicolás Alvarez : >> > >>> Done. The

Re: Review Request 120442: Fix comments in Haskell highlighting

2014-10-01 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120442/#review67784 --- This highlighting file extensively uses the RegExpr rules. Whi

Re: Review Request 119767: Add Hamlet and Haskell quasiquotation

2014-10-01 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119767/#review67786 --- Ship it! Well, I believe you know what you are doing, and sin

Jenkins build is back to stable : ktexteditor_master_qt5 #697

2014-10-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kconfigwidgets should install have kf5_entry.desktop

2014-10-01 Thread Albert Astals Cid
El Dimecres, 1 d'octubre de 2014, a les 10:14:59, David Faure va escriure: > On Tuesday 30 September 2014 20:25:59 Albert Astals Cid wrote: > > I can see the kconfigwidget commit to install kf5_entry.desktop but can't > > find any commit in release-tools that copies the .desktop files over. > > O

Re: kconfigwidgets should install have kf5_entry.desktop

2014-10-01 Thread David Faure
On Wednesday 01 October 2014 23:04:16 Albert Astals Cid wrote: > I find it very useful be able to do ./pack.sh kconfigwidgets and get the > same tarball that everyone would get if i do that But do you mean "I" as Albert the release dude, or "I" as anyone? In other words ./pack.sh gives the r

Re: kdelibs4support does not contain any .po

2014-10-01 Thread Albert Astals Cid
El Dimecres, 1 d'octubre de 2014, a les 10:51:05, David Faure va escriure: > On Wednesday 17 September 2014 23:07:50 Albert Astals Cid wrote: > > El Dimecres, 17 de setembre de 2014, a les 22:53:35, David Faure va > > escriure: > > > On Monday 15 September 2014 23:12:19 Albert Astals Cid wrote: >

Re: kconfigwidgets should install have kf5_entry.desktop

2014-10-01 Thread Albert Astals Cid
El Dimecres, 1 d'octubre de 2014, a les 23:08:30, David Faure va escriure: > On Wednesday 01 October 2014 23:04:16 Albert Astals Cid wrote: > > I find it very useful be able to do ./pack.sh kconfigwidgets and get the > > same tarball that everyone would get if i do that > > But do you mean "I" as

Re: kdelibs4support does not contain any .po

2014-10-01 Thread David Faure
On Wednesday 01 October 2014 23:08:29 Albert Astals Cid wrote: > But changing all the Messages.sh (along with adding support to scripty) may > be a bit hard, so i guess you can go with the "hopeful" grepping for now > if that works. Done. Works for my tests (kio & kde4support), we'll see about t

Review Request 120458: Port html, djvu and folder thumbcreators

2014-10-01 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120458/ --- Review request for KDE Frameworks. Bugs: 339456 https://bugs.kde.org/

Re: Review Request 120458: Port html, djvu and folder thumbcreators

2014-10-01 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120458/ --- (Updated Oct. 1, 2014, 9:59 p.m.) Review request for KDE Frameworks. Bu

Fwd: Qt DevDays is coming; do we want to print up some Frameworks Cookbooks to give to attendees?

2014-10-01 Thread Valorie Zimmerman
https://www.qtdeveloperdays.com/europe says that Qt DevDays happens October 6 – 8, at the Berlin Congress Centre in Berlin. If we want to print up some books to give away, we need some more chapters. See https://books.kde.org for more details. Valorie -- http://about.me/valoriez ___