Re: Review Request 120449: Avoid infinite recursion in KSNI

2014-10-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120449/#review67795 --- Ship it! Looks good src/kstatusnotifieritem.cpp

Re: Review Request 120450: Implement KDEPlatformSystemTrayIcon::isSystemTrayAvailable()

2014-10-02 Thread Martin Klapetek
On Oct. 1, 2014, 6:57 p.m., Aleix Pol Gonzalez wrote: Isn't that blocking? Do we know when it's called? David Edmundson wrote: yes it is. but it's a static method and there is no change signal. There isn't really any other option (without changing Qt). What if we make it the

Re: Review Request 120450: Implement KDEPlatformSystemTrayIcon::isSystemTrayAvailable()

2014-10-02 Thread David Edmundson
On Oct. 1, 2014, 4:57 p.m., Aleix Pol Gonzalez wrote: Isn't that blocking? Do we know when it's called? David Edmundson wrote: yes it is. but it's a static method and there is no change signal. There isn't really any other option (without changing Qt). Martin Klapetek wrote:

Re: Review Request 120450: Implement KDEPlatformSystemTrayIcon::isSystemTrayAvailable()

2014-10-02 Thread Martin Klapetek
On Oct. 1, 2014, 6:57 p.m., Aleix Pol Gonzalez wrote: Isn't that blocking? Do we know when it's called? David Edmundson wrote: yes it is. but it's a static method and there is no change signal. There isn't really any other option (without changing Qt). Martin Klapetek wrote:

Re: Review Request 120450: Implement KDEPlatformSystemTrayIcon::isSystemTrayAvailable()

2014-10-02 Thread David Edmundson
On Oct. 1, 2014, 4:57 p.m., Aleix Pol Gonzalez wrote: Isn't that blocking? Do we know when it's called? David Edmundson wrote: yes it is. but it's a static method and there is no change signal. There isn't really any other option (without changing Qt). Martin Klapetek wrote:

Re: Review Request 120450: Implement KDEPlatformSystemTrayIcon::isSystemTrayAvailable()

2014-10-02 Thread Martin Klapetek
On Oct. 1, 2014, 6:57 p.m., Aleix Pol Gonzalez wrote: Isn't that blocking? Do we know when it's called? David Edmundson wrote: yes it is. but it's a static method and there is no change signal. There isn't really any other option (without changing Qt). Martin Klapetek wrote:

Re: Review Request 120450: Implement KDEPlatformSystemTrayIcon::isSystemTrayAvailable()

2014-10-02 Thread David Edmundson
On Oct. 1, 2014, 4:57 p.m., Aleix Pol Gonzalez wrote: Isn't that blocking? Do we know when it's called? David Edmundson wrote: yes it is. but it's a static method and there is no change signal. There isn't really any other option (without changing Qt). Martin Klapetek wrote:

Re: Review Request 120449: Avoid infinite recursion in KSNI

2014-10-02 Thread David Edmundson
On Oct. 2, 2014, 7:10 a.m., Martin Klapetek wrote: src/kstatusnotifieritem.cpp, line 820 https://git.reviewboard.kde.org/r/120449/diff/2/?file=315991#file315991line820 I would merge it with the if (enabled... above, there's no point going forward from there if we're going to

Re: Review Request 120449: Avoid infinite recursion in KSNI

2014-10-02 Thread Martin Klapetek
On Oct. 2, 2014, 9:10 a.m., Martin Klapetek wrote: src/kstatusnotifieritem.cpp, line 820 https://git.reviewboard.kde.org/r/120449/diff/2/?file=315991#file315991line820 I would merge it with the if (enabled... above, there's no point going forward from there if we're going to

Re: Review Request 120243: Remove fallback QSystemTray support

2014-10-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120243/ --- (Updated Oct. 2, 2014, 2:25 p.m.) Status -- This change has been

Re: Review Request 120450: Implement KDEPlatformSystemTrayIcon::isSystemTrayAvailable()

2014-10-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120450/ --- (Updated Oct. 2, 2014, 2:26 p.m.) Status -- This change has been

Re: Review Request 120450: Implement KDEPlatformSystemTrayIcon::isSystemTrayAvailable()

2014-10-02 Thread David Edmundson
On Oct. 1, 2014, 4:57 p.m., Aleix Pol Gonzalez wrote: Isn't that blocking? Do we know when it's called? David Edmundson wrote: yes it is. but it's a static method and there is no change signal. There isn't really any other option (without changing Qt). Martin Klapetek wrote:

Re: Review Request 120449: Avoid infinite recursion in KSNI

2014-10-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120449/ --- (Updated Oct. 2, 2014, 2:29 p.m.) Status -- This change has been

Re: Qt DevDays is coming; do we want to print up some Frameworks Cookbooks to give to attendees?

2014-10-02 Thread Jeremy Whiting
Valorie, I'm a bit confused. books.kde.org says the book is hosted at flossmanuals, but that url takes me to the oldish KDE Dev Guide is thi Frameworks Cookbook a different thing than that old book, right? Is the current wip book available somewhere ? I guess if so we should point that link at it

Review Request 120467: Native Qt Quick FileDialog

2014-10-02 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120467/ --- Review request for KDE Frameworks and Frederik Gladhorn. Bugs: 334963

Why so many QStyles

2014-10-02 Thread Hugo Pereira Da Costa
hi all, I guess its a question to Qt experts or possibly low level KF5 experts. When comparing debugging outputs when running app + style against Qt4 and Qt5, I've noticed the following significant difference. In Qt4, as far as I can tell, QStyle was only instanciated one per QApp, and

Re: Why so many QStyles

2014-10-02 Thread Aleix Pol
On Thu, Oct 2, 2014 at 10:10 PM, Hugo Pereira Da Costa hugo.pere...@free.fr wrote: hi all, I guess its a question to Qt experts or possibly low level KF5 experts. When comparing debugging outputs when running app + style against Qt4 and Qt5, I've noticed the following significant