OSX/CI: kde-baseapps fails to build on branch frameworks

2014-10-08 Thread Marko Käning
Dolphin is currently broken on OSX: --- [ 49%] Building CXX object konqueror/src/CMakeFiles/kdeinit_konqueror.dir/konqviewmanager.cpp.o /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/views/dolphinview.cpp:571:25: error: use of undeclared identifier 'KFormat'

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2014-10-08 Thread Bhushan Shah
Hello On Wed, Oct 8, 2014 at 12:04 PM, Marko Käning mk-li...@email.de wrote: Dolphin is currently broken on OSX: #ifdef HAVE_BALOO #include Baloo/IndexerConfig -#include KFormat #endif +#include KFormat Can you try this? ___ Kde-frameworks-devel

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2014-10-08 Thread Marko Käning
Hi Bhushan, On 08 Oct 2014, at 08:44 , Bhushan Shah bhus...@gmail.com wrote: #ifdef HAVE_BALOO #include Baloo/IndexerConfig -#include KFormat #endif +#include KFormat Can you try this? that fixed some stuff, but not all: --- [ 91%] [ 91%] Building CXX object

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2014-10-08 Thread Marko Käning
Hi Bhushan, thanks, it worked eventually! Committed here: http://commits.kde.org/kde-baseapps/e2691b93cc078366261302f92821ba0672401099 What a luck that I do not have baloo installed, otherwise this would have went unnoticed even by Jenkins master, which does not test for a baloo-free setup. =)

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #827

2014-10-08 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #828

2014-10-08 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #829

2014-10-08 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kdelibs4support_master_qt5 #283

2014-10-08 Thread KDE CI System
See http://build.kde.org/job/kdelibs4support_master_qt5/283/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120519: Don't call 'enableTestMode' when QStandardPaths::isTestModeEnabled is false

2014-10-08 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120519/#review68091 --- Ship it! Seems sensible to me - Lukáš Tinkl On Říj. 7,

Jenkins build became unstable: kservice_master_qt5 #189

2014-10-08 Thread KDE CI System
See http://build.kde.org/job/kservice_master_qt5/189/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/ --- Review request for KDE Frameworks and Frederik Gladhorn. Repository:

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/ --- (Updated Oct. 8, 2014, 3:20 p.m.) Review request for KDE Frameworks,

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/#review68095 --- According to

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
On Oct. 8, 2014, 3:22 p.m., Albert Astals Cid wrote: According to https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ changing the const/volatile qualifiers of the function is BIC Now the thing is if we allow BIC changes in frameworks like attica or not is for

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Aleix Pol Gonzalez
On Oct. 8, 2014, 9:22 p.m., Albert Astals Cid wrote: According to https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ changing the const/volatile qualifiers of the function is BIC Now the thing is if we allow BIC changes in frameworks like attica or not is for

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
On Oct. 8, 2014, 3:22 p.m., Albert Astals Cid wrote: According to https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ changing the const/volatile qualifiers of the function is BIC Now the thing is if we allow BIC changes in frameworks like attica or not is for