Re: Review Request 120049: KDirNotify: Use QUrl::toStringList

2014-10-10 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120049/ --- (Updated Oct. 10, 2014, 10:32 a.m.) Status -- This change has been

Re: Review Request 119796: Add a --run-env option

2014-10-10 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119796/ --- (Updated Oct. 10, 2014, 11:03 a.m.) Status -- This change has been

Re: Review Request 120514: Add snippet extractor comments.

2014-10-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120514/#review68202 --- Ship it! Ship It! - David Edmundson On Oct. 6, 2014, 2:49

Re: Review Request 120539: Fix incorrect count of netwm atoms

2014-10-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120539/ --- (Updated Oct. 10, 2014, 3:06 p.m.) Status -- This change has been

Whoopsie in KF5::WindowSystem 5.3.0

2014-10-10 Thread Martin Graesslin
Hi all, unfortunately we have an embarrassing bug [1] in KWindowSystem 5.3.0 which can crash any application making use of KWindowSystem on the X11 Platform. This is fixed with commit [2]. I recommend to either do a 5.3.1 release for KWindowSystem with just that commit added or at least that

Re: Whoopsie in KF5::WindowSystem 5.3.0

2014-10-10 Thread Rolf Eike Beer
Am Freitag, 10. Oktober 2014, 17:14:41 schrieb Martin Graesslin: Hi all, unfortunately we have an embarrassing bug [1] in KWindowSystem 5.3.0 which can crash any application making use of KWindowSystem on the X11 Platform. This is fixed with commit [2]. I recommend to either do a 5.3.1

frameworks' cmake configs looking for other things

2014-10-10 Thread Harald Sitter
Alohas as described in [1] I think there is a bit of a problem how we track inter-dependencies in cmake configs right now (that is: the configs frameworks install to be found by 3rd party bits). If I write a 3rd party software that does this: find_package(KF5Runner) it will eventually trigger

Moving SVGTextureNode to KDeclarative

2014-10-10 Thread Aleix Pol
Hi, I'm looking into using QQuickItem to properly perform the QIconItem drawing, instead of QPainterItem. To do so, I thought it could be useful to use the SVGTextureNode for the ref-counting. It's quite a simple class, but it is quite useful. It's already used in 3 of the classes within plasma

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #830

2014-10-10 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Moving SVGTextureNode to KDeclarative

2014-10-10 Thread Aleix Pol
On Fri, Oct 10, 2014 at 6:23 PM, Marco Martin notm...@gmail.com wrote: On Friday 10 October 2014 17:58:04 Aleix Pol wrote: Hi, I'm looking into using QQuickItem to properly perform the QIconItem drawing, instead of QPainterItem. To do so, I thought it could be useful to use the

Review Request 120551: Enable test mode when starting kded5 from a unittest.

2014-10-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120551/ --- Review request for KDE Frameworks, Hrvoje Senjan and Lukáš Tinkl.

Re: Review Request 119767: Add Hamlet and Haskell quasiquotation

2014-10-10 Thread Bastian Holst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119767/ --- (Updated Oct. 10, 2014, 8:02 p.m.) Status -- This change has been

Re: Review Request 120551: Enable test mode when starting kded5 from a unittest.

2014-10-10 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120551/#review68227 --- Ship it! Ship It! - Hrvoje Senjan On Oct. 10, 2014, 9:58

Re: Review Request 120551: Enable test mode when starting kded5 from a unittest.

2014-10-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120551/ --- (Updated Oct. 10, 2014, 8:26 p.m.) Status -- This change has been

Re: Review Request 120075: KArchive: add support for rcc files

2014-10-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120075/ --- (Updated Oct. 10, 2014, 8:46 p.m.) Review request for KDE Frameworks,

Re: Review Request 120514: Add snippet extractor comments.

2014-10-10 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120514/ --- (Updated Oct. 10, 2014, 8:51 p.m.) Status -- This change has been

Re: Gerrit available for trial

2014-10-10 Thread David Faure
On Friday 12 September 2014 11:55:23 Kevin Krammer wrote: It is currently used for Trojita itself and at the Frameworks BoF at Akademy we decided to also test drive this with two of our actively developed frameworks. ... and these two frameworks are plasma-framework and kio. I tried pushing

Re: Split kde-baseapps?

2014-10-10 Thread David Faure
On Thursday 25 September 2014 01:01:27 Aleix Pol wrote: - kdialog: should go to kde-cli-tools? It's more interactive than other cli tools, but OK, I guess the biggest use case is to call it from scripts. - kioslave/about: I guess it should go either to kioslave-extras or konqueror itself. I

Re: Review Request 120382: Port comicbook thumbnailer to KF5

2014-10-10 Thread David Faure
On Sept. 26, 2014, 10:44 p.m., David Edmundson wrote: thumbnail/comiccreator.cpp, line 227 https://git.reviewboard.kde.org/r/120382/diff/1/?file=315507#file315507line227 Why do we run unrar manually when we're already linking against karchive elsewhere? (I understand

Re: Review Request 120393: Restore accidentally(?) removed strigi check

2014-10-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393/#review68234 --- right, it's inconsistent - but I wonder, how did this create

Re: Gerrit available for trial

2014-10-10 Thread Ben Cooksley
On Sat, Oct 11, 2014 at 9:57 AM, David Faure fa...@kde.org wrote: On Friday 12 September 2014 11:55:23 Kevin Krammer wrote: It is currently used for Trojita itself and at the Frameworks BoF at Akademy we decided to also test drive this with two of our actively developed frameworks. ... and

Re: Gerrit available for trial

2014-10-10 Thread Jan Kundrát
On Friday, 10 October 2014 22:57:26 CEST, David Faure wrote: Is there any chance we could import all of KDE identity into gerrit? Otherwise that doesn't really make it usable, until everyone has created an account there - which won't happen. I think with reviewboard we can add anyone with a KDE

Re: Moving SVGTextureNode to KDeclarative

2014-10-10 Thread David Faure
On Friday 10 October 2014 18:18:40 Marco Martin wrote: (but even if it doesn't export symbols i'm not sure removing target_link_libraries is bc?) Depends if it was a PUBLIC or PRIVATE library (in the target_link_libraries line). From your question I guess it wasn't specified, though, in which

Re: Review Request 120393: Restore accidentally(?) removed strigi check

2014-10-10 Thread Hrvoje Senjan
On Oct. 10, 2014, 11:12 p.m., David Faure wrote: right, it's inconsistent - but I wonder, how did this create a problem for you? i.e. did you miss the strigi-dependent code? I thought nothing used that anymore, and afaik strigi for qt5 doesn't exist? i wanted to check whether a feature

Re: Gerrit available for trial

2014-10-10 Thread David Faure
On Friday 10 October 2014 23:25:35 Jan Kundrát wrote: On Friday, 10 October 2014 22:57:26 CEST, David Faure wrote: Is there any chance we could import all of KDE identity into gerrit? Otherwise that doesn't really make it usable, until everyone has created an account there - which won't

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #135

2014-10-10 Thread KDE CI System
See http://build.kde.org/job/kde-baseapps_frameworks_qt5/135/changes Changes: [montel] kdelibs4support-- [montel] Fix includes [montel] Clean includes + port to QMenu -- [...truncated 1320 lines...]

Re: Gerrit available for trial

2014-10-10 Thread Jan Kundrát
On Friday, 10 October 2014 23:38:37 CEST, David Faure wrote: Another issue: could all incoming review requests for kio (and all other frameworks in the future, except plasma-framework which has a dedicated list) be sent to kde-frameworks-devel? I don't see a mail with my request there. Sure,

Re: Whoopsie in KF5::WindowSystem 5.3.0

2014-10-10 Thread David Faure
On Friday 10 October 2014 17:14:41 Martin Graesslin wrote: I recommend to either do a 5.3.1 release for KWindowSystem with just that commit added Done. kwindowsystem v5.3.1 49f34827a0cbd46320149c7b835abd8431287083 80765c897128907307558dbe28d914a31186ff7fd479b6c262a2704a979e20b9

Re: Whoopsie in KF5::WindowSystem 5.3.0

2014-10-10 Thread Nicolás Alvarez
2014-10-10 19:47 GMT-03:00 David Faure fa...@kde.org: On Friday 10 October 2014 17:14:41 Martin Graesslin wrote: I recommend to either do a 5.3.1 release for KWindowSystem with just that commit added Done. kwindowsystem v5.3.1 49f34827a0cbd46320149c7b835abd8431287083