Review Request 120878: Remove unused header

2014-10-28 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ --- Review request for KDE Frameworks, kdewin and Plasma. Repository: krunner

Replacement for KMimeType::isBinaryData?

2014-10-28 Thread Kevin Funk
Heya, I didn't find a suitable replacement for KMimeType::isBinaryData in KF5. Is there some? http://lxr.kde.org/ident?v=kf5-qt5&_i=isBinaryData&_remember=1 shows exactly two users of this function. Worth considering upstreaming to Qt? -- Kevin Funk | kf...@kde.org | http://kfunk.org ___

Re: Review Request 120813: Set shortcuts via invoked meta method

2014-10-28 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120813/ --- (Updated Oct. 28, 2014, 11:14 p.m.) Status -- This change has been m

Re: Review Request 120833: Handle absolute paths without extension in KPluginLoader::findPlugin()

2014-10-28 Thread Alexander Richardson
> On Okt. 28, 2014, 10:59 nachm., David Faure wrote: > > This should be done in Qt, IMHO. The docu (which I added in 418890e07) says > > "We recommend omitting the file's suffix in the file name" without > > specifying that this would only work for relative paths. > > David Faure wrote: >

Re: Review Request 120833: Handle absolute paths without extension in KPluginLoader::findPlugin()

2014-10-28 Thread David Faure
> On Oct. 28, 2014, 9:59 p.m., David Faure wrote: > > This should be done in Qt, IMHO. The docu (which I added in 418890e07) says > > "We recommend omitting the file's suffix in the file name" without > > specifying that this would only work for relative paths. I can look into adding that some

Re: Review Request 120833: Handle absolute paths without extension in KPluginLoader::findPlugin()

2014-10-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120833/#review69357 --- This should be done in Qt, IMHO. The docu (which I added in 41

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

2014-10-28 Thread Andrea Diamantini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120794/#review69318 --- src/application.cpp

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

2014-10-28 Thread Andrea Diamantini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120794/#review69317 --- src/application.cpp

Re: Review Request 120854: KPassivePopup - Set default hide delay

2014-10-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120854/#review69303 --- Should maybe be "delay < 0"? Either way, +1. - Aleix Pol Gon

Review Request 120854: KPassivePopup - Set default hide delay

2014-10-28 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120854/ --- Review request for KDE Frameworks. Bugs: 340238 https://bugs.kde.org/

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

2014-10-28 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120794/ --- (Updated Oct. 28, 2014, 2 p.m.) Review request for KDE Frameworks and rek

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

2014-10-28 Thread David Narváez
> On Oct. 28, 2014, 9:32 a.m., David Faure wrote: > > src/application.cpp, line 789 > > > > > > Note that you might want to use the cwd in order to resolve urls with > > it, so that "rekonq localfile.html" works

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-28 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/ --- (Updated Oct. 28, 2014, 1:37 p.m.) Status -- This change has been ma

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

2014-10-28 Thread David Narváez
> On Oct. 28, 2014, 9:32 a.m., David Faure wrote: > > src/application.cpp, line 785 > > > > > > It's a bit confusing because QCLP::process() is not the same, and also > > because of the other processCmdLine meth

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/#review69260 --- Ship it! Just one last thing, then push. src/widgets/krun.c

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-28 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/ --- (Updated Oct. 28, 2014, 5:13 p.m.) Review request for KDE Frameworks. R

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-28 Thread Arjun AK
> On Oct. 28, 2014, 3:35 p.m., David Faure wrote: > > src/widgets/executablefileopendialog.cpp, line 64 > > > > > > where is this slot used? Nowhere. The file was copy-pasted from the other patch - Arjun

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-28 Thread David Faure
> On Oct. 28, 2014, 10:05 a.m., David Faure wrote: > > src/widgets/krun.cpp, line 978 > > > > > > This should use the 4 args connect, in case the KRun gets deleted > > before the dialog. > > > > i.e. in

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-28 Thread Arjun AK
> On Oct. 28, 2014, 3:35 p.m., David Faure wrote: > > src/widgets/krun.cpp, line 978 > > > > > > This should use the 4 args connect, in case the KRun gets deleted > > before the dialog. > > > > i.e. ins

Jenkins build is back to stable : kservice_master_qt5 #195

2014-10-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/#review69246 --- src/widgets/executablefileopendialog.cpp

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

2014-10-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120794/#review69243 --- src/application.h

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-28 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/ --- (Updated Oct. 28, 2014, 1:20 p.m.) Review request for KDE Frameworks. R

Re: Review Request 120720: Open X-DocPath entries from Help button kcmshell5 in KHelpcenter

2014-10-28 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120720/ --- (Updated Oct. 28, 2014, 7:37 a.m.) Status -- This change has been ma