Re: Review Request 120728: Install public header for KNotifyPlugin and rename it to KNotificationPlugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120728/ --- (Updated Oct. 29, 2014, 10 a.m.) Review request for KDE Frameworks. Cha

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/ --- (Updated Oct. 29, 2014, 4:22 p.m.) Status -- This change has been ma

Review Request 120886: Show script execution prompt only if asked to

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120886/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 120886: Show script execution prompt only if asked to

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120886/#review69407 --- Sounds sane but dfaure will give you ship it! :) - Bhushan Sh

Re: Review Request 120886: Show script execution prompt only if asked to

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120886/#review69406 --- src/widgets/krun.h

Review Request 120887: add custom icons to KNotification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120887/ --- Review request for KDE Frameworks. Repository: knotifications Descripti

Re: Review Request 120887: add custom icons to KNotification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120887/#review69418 --- Ship it! Some minor comments, looking good! src/knotificati

Re: Review Request 120887: add custom icons to KNotification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120887/ --- (Updated Oct. 29, 2014, 11:49 a.m.) Review request for KDE Frameworks.

Re: Review Request 120887: add custom icons to KNotification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120887/#review69424 --- Ship it! Ship It! - Kai Uwe Broulik On Okt. 29, 2014, 11:4

Re: Review Request 120887: add custom icons to KNotification

Wait, I got a comment but can't post it from the phone, will be back in about an hour -- Sent from my Nokia N9 On 29.10.2014 12:57 Kai Uwe Broulik wrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120887/ Ship it! Ship It! - Kai Uwe

Re: Review Request 120887: add custom icons to KNotification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120887/#review69437 --- Ship it! Ahah, I thought I have spotted an issue before but n

Re: Review Request 120887: add custom icons to KNotification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120887/ --- (Updated Oct. 29, 2014, 1:33 p.m.) Status -- This change has been ma

Review Request 120888: add a new KNotification::Event with icon name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120888/ --- Review request for KDE Frameworks. Repository: knotifications Descripti

Re: Review Request 120888: add a new KNotification::Event with icon name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120888/#review69447 --- Ship it! src/knotification.h

Re: Review Request 120888: add a new KNotification::Event with icon name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120888/ --- (Updated Oct. 29, 2014, 1:56 p.m.) Status -- This change has been ma

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120794/ --- (Updated Oct. 29, 2014, 1:57 p.m.) Review request for KDE Frameworks and

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

> On Oct. 28, 2014, 6:09 p.m., Andrea Diamantini wrote: > > src/application.cpp, line 731 > > > > > > It's not clear to me why you chose parse() instead of process() here. > > Can you please argument this? I

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

> On Oct. 28, 2014, 6:09 p.m., Andrea Diamantini wrote: > > src/application.cpp, line 731 > > > > > > It's not clear to me why you chose parse() instead of process() here. > > Can you please argument this? >

Re: Review Request 120833: Handle absolute paths without extension in KPluginLoader::findPlugin()

> On Okt. 28, 2014, 10:59 nachm., David Faure wrote: > > This should be done in Qt, IMHO. The docu (which I added in 418890e07) says > > "We recommend omitting the file's suffix in the file name" without > > specifying that this would only work for relative paths. > > David Faure wrote: >

Review Request 120825: Fix KPluginInfo::entryPath() being empty when not loaded from .desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120825/ --- Review request for KDE Frameworks, David Faure and Sebastian Kügler. Repo

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

> On Okt. 21, 2014, 11:19 nachm., Sebastian Kügler wrote: > > I've looked at the patch and tested it, it looks like a really useful > > improvement, and one more step of untangling the plugin / metadata > > situation from KService/KSycoca. I don't feel comfortable enough hitting > > ship it, b

Re: Review Request 120825: Fix KPluginInfo::entryPath() being empty when not loaded from .desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120825/#review69495 --- autotests/kplugininfotest.cpp

Re: Review Request 120886: Show script execution prompt only if asked to

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120886/#review69497 --- Ship it! (after adding the @since 5.4) - David Faure On Oc

Review Request 120902: [KRatingPainter] Support monochrome icon themes (such as breeze)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120902/ --- Review request for KDE Frameworks. Bugs: 339863 https://bugs.kde.org/

Re: Review Request 120825: Fix KPluginInfo::entryPath() being empty when not loaded from .desktop

> On Okt. 29, 2014, 10:29 nachm., David Faure wrote: > > autotests/kplugininfotest.cpp, line 67 > > > > > > this comment doesn't match the expected result anymore Yeah, forgot to remove that comment. > On O

Review Request 120903: Fix typo in documentation.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120903/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti

Review Request 120904: [KCharSelect] [API] Add new methods to handle characters outside BMP

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120904/ --- Review request for KDE Frameworks and Daniel Laidig. Repository: kwidgets

Re: Review Request 120903: Fix typo in documentation.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120903/#review69503 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 30, 2014, 1