Re: Where are kwalletd autotests?

2014-11-01 Thread Valentin Rusu
On 01/11/14 02:19:05, Albert Astals Cid wrote: El Dissabte, 1 de novembre de 2014, a les 00:23:57, David Faure va escriure: On Friday 31 October 2014 01:00:41 Albert Astals Cid wrote: kwalletd has autotests in kde-runtime in kdelibs4 world but can't find them in KF5 land. Any

Re: Where are kwalletd autotests?

2014-11-01 Thread Marko Käning
Hi Albert, On 01 Nov 2014, at 02:19 , Albert Astals Cid aa...@kde.org wrote: No, these http://quickgit.kde.org/?p=kde-runtime.gita=treef=kwalletd%2Fautotests how did you actually spot that these tests suddenly had been gone? Greets, Marko ___

Re: Review Request 120926: Remove redundant code from KRun::KRunPrivate::isPromptNeeded()

2014-11-01 Thread Arjun AK
On Nov. 1, 2014, 1:39 a.m., David Faure wrote: I would rather that this is all encapsulated, so callers don't have to worry about it. (and Emmanuel seems to agree, in RR 120171). This is the way it's done for many other things. The dont show again acts just as if the message

Re: Review Request 120926: Remove redundant code from KRun::KRunPrivate::isPromptNeeded()

2014-11-01 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120926/ --- (Updated Nov. 1, 2014, 4:01 p.m.) Review request for KDE Frameworks and

Re: Review Request 120605: cleanup overlay icon usage

2014-11-01 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/#review69638 --- Ping? No git account? - Emmanuel Pescosta On Oct. 16,

Re: Where are kwalletd autotests?

2014-11-01 Thread Albert Astals Cid
El Dissabte, 1 de novembre de 2014, a les 10:31:01, Valentin Rusu va escriure: On 01/11/14 02:19:05, Albert Astals Cid wrote: El Dissabte, 1 de novembre de 2014, a les 00:23:57, David Faure va escriure: On Friday 31 October 2014 01:00:41 Albert Astals Cid wrote: kwalletd has autotests

Re: Where are kwalletd autotests?

2014-11-01 Thread Albert Astals Cid
El Dissabte, 1 de novembre de 2014, a les 10:32:35, Marko Käning va escriure: Hi Albert, On 01 Nov 2014, at 02:19 , Albert Astals Cid aa...@kde.org wrote: No, these http://quickgit.kde.org/?p=kde-runtime.gita=treef=kwalletd%2Fautotests how did you actually spot that these tests suddenly

Re: Review Request 120605: cleanup overlay icon usage

2014-11-01 Thread Albert Astals Cid
On nov. 1, 2014, 12:38 p.m., Emmanuel Pescosta wrote: Ping? No git account? He does have an account as you can see in http://websvn.kde.org/trunk/kde-common/accounts?view=markup But you can still commit it yourself, don't forget to use --author in the git commit line and that's it :) -

Re: Review Request 120605: cleanup overlay icon usage

2014-11-01 Thread Stefan Brüns
On Nov. 1, 2014, 12:38 p.m., Emmanuel Pescosta wrote: Ping? No git account? Albert Astals Cid wrote: He does have an account as you can see in http://websvn.kde.org/trunk/kde-common/accounts?view=markup But you can still commit it yourself, don't forget to use --author in

Re: Review Request 120909: in kio_smb: Set inode/directory mimetype for folders

2014-11-01 Thread Mark Gaiser
On okt 31, 2014, 8:52 a.m., David Faure wrote: Hmm, not sure which change in KFileItem you're referring to. But maybe this is the change from KMimeType (which used a mode_t argument) to QMimeType (which doesn't). We could add some logic in KFileItem to preserve behavior compat for

Re: Ksshaskpass ?

2014-11-01 Thread Jeremy Whiting
Ok, pushed to scratch/whiting/ksshaskpass the original sources from 0.5.3 on first commit, and a commit to port to kf5 which seems to work ok here. I removed the RPATH exception since that made the binary not able to find KF5CoreAddons.so here. If it should be left in and some other method works

Jenkins build became unstable: kio_master_qt5 #422

2014-11-01 Thread KDE CI System
See http://build.kde.org/job/kio_master_qt5/422/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel