Re: Review Request 121090: Move kio-mtp to kio-extras

2014-11-13 Thread Jan Grulich
On Lis. 12, 2014, 10:04 odp., Àlex Fiestas wrote: I would move this perhaps to plasma-workspace since this slave is really important for nowadays usage of the desktop (android phones etc). Aleix Pol Gonzalez wrote: Well, there's important kio's as well in kio-extras. Question is,

libnm-qt - a new KF5 framework for Tier 1?

2014-11-13 Thread Jan Grulich
Hi guys, we would like to finally move on with our libnm-qt library and become a part of KDE Frameworks 5. We plan do the same with libmm-qt, but we don't have proper unit tests yet so let's just do this one first. If you don't know, libnm-qt (NetworkManagerQt) is a dbus wrapper for

Re: libnm-qt - a new KF5 framework for Tier 1?

2014-11-13 Thread David Edmundson
++ to the idea moving it. Super fast review: in the dbus folder the are 3 files called hand_edits.diff in different capitalisation. I'm not a fan of the propertiesChanged() method making it into the public API which we see in most classes, it's very much an implementation detail for

Re: libnm-qt - a new KF5 framework for Tier 1?

2014-11-13 Thread Albert Astals Cid
El Dijous, 13 de novembre de 2014, a les 16:20:41, David Edmundson va escriure: ++ to the idea moving it. Super fast review: in the dbus folder the are 3 files called hand_edits.diff in different capitalisation. I'm not a fan of the propertiesChanged() method making it into the public

Re: libnm-qt - a new KF5 framework for Tier 1?

2014-11-13 Thread Albert Astals Cid
El Dijous, 13 de novembre de 2014, a les 16:27:20, Albert Astals Cid va escriure: El Dijous, 13 de novembre de 2014, a les 16:20:41, David Edmundson va escriure: ++ to the idea moving it. Super fast review: in the dbus folder the are 3 files called hand_edits.diff in different

Re: Review Request 120760: Fix bug #340212: incorrect soft-tabs alignment after beginning-of-line

2014-11-13 Thread Michael Hansen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120760/ --- (Updated Nov. 13, 2014, 9:49 a.m.) Review request for KDE Frameworks and

Re: Review Request 121090: Move kio-mtp to kio-extras

2014-11-13 Thread David Faure
On Nov. 12, 2014, 10:04 p.m., Àlex Fiestas wrote: I would move this perhaps to plasma-workspace since this slave is really important for nowadays usage of the desktop (android phones etc). Aleix Pol Gonzalez wrote: Well, there's important kio's as well in kio-extras. Question is,

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-13 Thread David Faure
On Nov. 11, 2014, 2:39 p.m., Albert Astals Cid wrote: I sincerely think this is a *VERY BAD* idea. I don't want my app behaving differently depending if a third party misterious compononent that is not documented anywhere is installed or not. If you have a dependency, well put it in

Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/#review70338 --- +1, having this behaviour was a pain in the ass. Also it

Review Request 121115: Use all of QT_PLUGIN_PATH paths rather than just QLibraryInfo path to look for plugins.

2014-11-13 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121115/ --- Review request for KDE Frameworks and Frederik Gladhorn. Repository:

Re: Review Request 121115: Use all of QT_PLUGIN_PATH paths rather than just QLibraryInfo path to look for plugins.

2014-11-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121115/#review70351 --- Ship it! Ship It! - David Edmundson On Nov. 13, 2014,

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/#review70354 --- +1 If you have to be blocking, use the proper blocking

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-13 Thread Aleix Pol Gonzalez
On Nov. 13, 2014, 11:44 p.m., Albert Astals Cid wrote: +1 If you have to be blocking, use the proper blocking methods. Obviosuly it'd be better if no blocking call is used but since i know nothing about the code i'll just shut up now :D We've been going through the code with david

Re: Review Request 121115: Use all of QT_PLUGIN_PATH paths rather than just QLibraryInfo path to look for plugins.

2014-11-13 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121115/ --- (Updated Nov. 14, 2014, 1:02 a.m.) Status -- This change has been