Re: Review Request 119607: Support for ".hidden" files

> On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote: > > src/core/kfileitem.h, line 262 > > > > > > Since we probably do not want to make it possible that all users of > > this class can make items "hidden",

Re: Review Request 119607: Support for ".hidden" files

> On Sept. 14, 2014, 3:27 nachm., Frank Reininghaus wrote: > > src/core/kfileitem.h, line 262 > > > > > > Since we probably do not want to make it possible that all users of > > this class can make items "hidden

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

> On Aug. 12, 2014, 11:33 a.m., Aleix Pol Gonzalez wrote: > > After some discussion with the SDK and Book groups in the sprint, I think > > we should move this into the kde:kwidgetsaddons repository, in an examples > > subdirectory. > > Laurent Navet wrote: > do you want me to move this fr

Re: Review Request 119607: Support for ".hidden" files

> On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote: > > src/core/kfileitem.h, line 262 > > > > > > Since we probably do not want to make it possible that all users of > > this class can make items "hidden",

Re: Review Request 119607: Support for ".hidden" files

> On Nov. 8, 2014, 10:02 p.m., David Faure wrote: > > src/core/kcoredirlister.cpp, line 1241 > > > > > > After this line, try adding > > > > if (!url.isLocalFile()) { > > const QString l

Re: Review Request 119607: Support for ".hidden" files

> On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote: > > src/core/kcoredirlister.h, line 420 > > > > > > I think that you should not make this part of the public API. AFAICS, > > you're not using it anywhere

Re: Review Request 119607: Support for ".hidden" files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119607/ --- (Updated Dez. 4, 2014, 9:55 p.m.) Review request for KDE Frameworks and D

Re: Review Request 121356: Do not change the volume when playing a notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71379 --- Ship it! Ship It! - David Edmundson On Dec. 4, 2014, 9:12

Re: Review Request 121356: Do not change the volume when playing a notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71372 --- Ship it! Ship It! - Jeremy Whiting On Dec. 4, 2014, 2:12 p

Review Request 121356: Do not change the volume when playing a notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/ --- Review request for KDE Frameworks and David Edmundson. Repository: knotif

Re: Review Request 119607: Support for ".hidden" files

> On Nov. 8, 2014, 10:02 p.m., David Faure wrote: > > src/core/kcoredirlister.cpp, line 1241 > > > > > > After this line, try adding > > > > if (!url.isLocalFile()) { > > const QString l

Re: Review Request 119607: Support for ".hidden" files

> On Nov. 8, 2014, 10:02 p.m., David Faure wrote: > > src/core/kcoredirlister.cpp, line 1241 > > > > > > After this line, try adding > > > > if (!url.isLocalFile()) { > > const QString l

Re: Review Request 119607: Support for ".hidden" files

> On Nov. 8, 2014, 10:02 p.m., David Faure wrote: > > src/core/kcoredirlister.cpp, line 1241 > > > > > > After this line, try adding > > > > if (!url.isLocalFile()) { > > const QString l

FYI: watch out for Q_GADGET with cmake2.8

alohas Qt has a magic macro Q_GADGET which according to a websearch falls slightly short of magic. It apparently allows non-QObject classes to grow a metaobject such that one can use properties/enums/invokables. Now the problem with that is that Q_GADGET is not supported by the cmake2.8 automoc c

Re: Review Request 119607: Support for ".hidden" files

> On Nov. 8, 2014, 10:02 p.m., David Faure wrote: > > src/core/kcoredirlister.cpp, line 1241 > > > > > > After this line, try adding > > > > if (!url.isLocalFile()) { > > const QString l

Jenkins build is back to normal : kemoticons_stable_qt5 #4

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kemoticons_master_qt5 #82

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kemoticons_stable_qt5 #3

See Changes: [Daniel Vrátil] Add KEmoticonsIntegrationPlugin for KTextToHTML from KCoreAddons -- [...truncated 26 lines...] > git config core.sparsecheckout # timeout=10 > git checkout -f ef27cc0

Build failed in Jenkins: kemoticons_master_qt5 #81

See Changes: [Daniel Vrátil] Add KEmoticonsIntegrationPlugin for KTextToHTML from KCoreAddons -- [...truncated 26 lines...] > git config core.sparsecheckout # timeout=10 > git checkout -f ef27cc

Re: Review Request 121118: KEmoticons: Add a KEmoticonsIntegrationPlugin for KTextToHTML from KCoreAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121118/ --- (Updated Dec. 4, 2014, 10 a.m.) Status -- This change has been marke

Re: Review Request 121303: detect kde4 home better in kde4 migration

> On Dec. 4, 2014, 8:42 a.m., David Faure wrote: > > src/lib/util/kdelibs4migration.cpp, line 52 > > > > > > These 3 lines could be removed then - if KDE4_DEFAULT_HOME doesn't > > exist, there isn't much point in

Re: Review Request 121303: detect kde4 home better in kde4 migration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121303/ --- (Updated Dec. 4, 2014, 9:07 a.m.) Status -- This change has been mar

Re: Review Request 121303: detect kde4 home better in kde4 migration

> On Dec. 4, 2014, 8:42 a.m., David Faure wrote: > > src/lib/util/kdelibs4migration.cpp, line 52 > > > > > > These 3 lines could be removed then - if KDE4_DEFAULT_HOME doesn't > > exist, there isn't much point in

Re: Review Request 121303: detect kde4 home better in kde4 migration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121303/#review71323 --- Ship it! src/lib/util/kdelibs4migration.cpp

Re: Review Request 121303: detect kde4 home better in kde4 migration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121303/ --- (Updated Dec. 4, 2014, 8:22 a.m.) Review request for KDE Frameworks, Davi