Re: Review Request 120904: [KCharSelect] [API] Add new methods to handle characters outside BMP

2014-12-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120904/#review71459 --- Indeed given the QChar API I don't see a better way.

Re: MultiPart HTTP requests

2014-12-06 Thread David Faure
On Friday 05 December 2014 16:14:45 Aleix Pol wrote: Hi all, Every now and then I end up having to generate MultiPart HTTP requests to implement some of those fancy HTTP API's to upload images. I know we have many implementation for this, namely one in kipi, then forked in ktp [1], one in

Re: Review Request 121258: Restart KDirWatch after a failed delete operation

2014-12-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121258/#review71460 --- Ship it! Ship It! - David Faure On Nov. 26, 2014, 6:49

Re: Review Request 119607: Support for .hidden files

2014-12-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119607/#review71461 --- src/core/kcoredirlister.cpp

Re: Review Request 121265: Make modified flag work for KMainWindow::setCaption(QString, bool)

2014-12-06 Thread David Faure
On Nov. 27, 2014, 8:18 a.m., Martin Gräßlin wrote: weird suggestion: why not let the window manager handle it? Expose it as an X11 property which gets read by the window manager/desktop shell and applies a semantic way to highlight that it's modified. This would require changes in Qt,

Re: Review Request 121265: Make modified flag work for KMainWindow::setCaption(QString, bool)

2014-12-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121265/#review71464 --- Ship it! - David Faure On Nov. 27, 2014, 3:10 a.m.,

Change in kio[master]: Fix runtime warnings about listing empty URL.

2014-12-06 Thread David Faure (Code Review)
David Faure has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/201 Change subject: Fix runtime warnings about listing empty URL. .. Fix runtime warnings about listing empty URL. QWARN :

OSX/CI: KFileMetaData fails to build on branch master

2014-12-06 Thread Marko Käning
Building CXX object src/CMakeFiles/KF5FileMetaData.dir/simpleextractionresult.cpp.o Generating moc_office2007extractortest.cpp Generating moc_office2007extractor.cpp [ 41%] [ 41%] Built target officeextractortest_automoc Building CXX object src/CMakeFiles/KF5FileMetaData.dir/typeinfo.cpp.o [ 43%]

Jenkins build is back to stable : kio_master_qt5 #449

2014-12-06 Thread KDE CI System
See http://build.kde.org/job/kio_master_qt5/449/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kio_stable_qt5 #12

2014-12-06 Thread KDE CI System
See http://build.kde.org/job/kio_stable_qt5/12/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: KFileMetaData fails to build on branch master

2014-12-06 Thread David Faure
On Saturday 06 December 2014 13:08:19 Marko Käning wrote: /Users/marko/WC/KDECI-builds/kfilemetadata/src/usermetadata.cpp:140:13: error: use of undeclared identifier 'errno' return (errno != ENODATA); ^ Fixed. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE

Re: OSX/CI: KFileMetaData fails to build on branch master

2014-12-06 Thread Marko Käning
Hi David, On 06 Dec 2014, at 14:53 , David Faure fa...@kde.org wrote: On Saturday 06 December 2014 13:08:19 Marko Käning wrote: /Users/marko/WC/KDECI-builds/kfilemetadata/src/usermetadata.cpp:140:13: error: use of undeclared identifier 'errno' return (errno != ENODATA); ^

OSX/CI: kfilemetadata fails to build on branch master

2014-12-06 Thread Marko Käning
The inclusion of MacPorts’ taglib fails on OSX. See the below discussions about this problem from September. kfilemetadata.log.gz Description: GNU Zip compressed data Begin forwarded message: From: Marko Käning mk-li...@email.de Subject: taglib inclusion on OSX Date: 13 Sep 2014 22:54:07

KF 5.5.0 changelog

2014-12-06 Thread David Faure
Here's the changelog I wrote for 5.5.0. Please everyone remember to use CHANGELOG in your commits, with a standalone description of the issue (i.e. which doesn't use the modified filenames as implicit context). I tried to grab what I could from the commit logs, but I don't always understand

Re: KF 5.5.0 changelog

2014-12-06 Thread Jeremy Whiting
Looks good to me on the attica/knewstuff entries. On Sat, Dec 6, 2014 at 7:59 AM, David Faure fa...@kde.org wrote: Here's the changelog I wrote for 5.5.0. Please everyone remember to use CHANGELOG in your commits, with a standalone description of the issue (i.e. which doesn't use the

Re: Review Request 121299: Add NET::OSD window type

2014-12-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121299/#review71479 --- Ping? - Kai Uwe Broulik On Dez. 1, 2014, 6:49 nachm., Kai

Debugging failures in KIO when using custom CI environment

2014-12-06 Thread Jan Kundrát
Hi, I'm working on a testing setup which plugs into Gerrit to add info whether a proposed change still builds and tests continue to pass. This is using a modified version of KDE's own Jenkins' CI scripts, but the environment is very likely much different. It runs within a sanitized environment

Change in kio[master]: Fix check for missing `kioslave` executable

2014-12-06 Thread Code Review
Jan Kundrát has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/202 Change subject: Fix check for missing `kioslave` executable .. Fix check for missing `kioslave` executable The old version checked a

Re: Debugging failures in KIO when using custom CI environment

2014-12-06 Thread Jan Kundrát
It seems that the problem is related to how a kioslave is launched along with using different installation dirs. Here's what got me to the right path: 13032 execve(/home/turbo-hipster/target/el7-x86_64-gcc/kf5-qt5/frameworks/kio/inst/lib64/libexec/kf5/kioslave,

Change in kio[master]: Add diagnostics when KIO Connection server fails to initialize

2014-12-06 Thread Code Review
Jan Kundrát has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/203 Change subject: Add diagnostics when KIO Connection server fails to initialize .. Add diagnostics when KIO Connection server fails to

GenericConfigLocation missing in qtpaths tool

2014-12-06 Thread Marko Käning
Hi folks, there is a ConfigLocation path type: --- $ /opt/kde/install/darwin/mavericks/clang/kf5-qt5/qt5/inst/bin/qtpaths --paths ConfigLocation /Users/marko/Library/Preferences $ /opt/kde/install/darwin/mavericks/clang/kf5-qt5/qt5/inst/bin/qtpaths --paths GenericConfigLocation Unknown

Re: GenericConfigLocation missing in qtpaths tool

2014-12-06 Thread David Faure
On Saturday 06 December 2014 20:10:33 Marko Käning wrote: Hi folks, there is a ConfigLocation path type: --- $ /opt/kde/install/darwin/mavericks/clang/kf5-qt5/qt5/inst/bin/qtpaths --paths ConfigLocation /Users/marko/Library/Preferences $

Re: Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark

2014-12-06 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121075/ --- (Updated Dec. 6, 2014, 8:20 p.m.) Status -- This change has been

Review Request 121372: Differeniate between bookmarks for documents and the web

2014-12-06 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121372/ --- Review request for KDE Frameworks, Localization and Translation (l10n) and

Re: Review Request 121372: Differeniate between bookmarks for documents and the web

2014-12-06 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121372/ --- (Updated Dec. 6, 2014, 3:49 p.m.) Review request for KDE Frameworks,