Re: Re: Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-15 Thread Martin Gräßlin
On Monday 15 December 2014 19:29:03 Martin Klapetek wrote: > On Mon, Dec 15, 2014 at 1:55 PM, Martin Gräßlin wrote: > > Given the basically non-existing feedback on the thread (modulo Alex's > > reply) > > I would assume that everything is fine and we can just move the code. If > > you > > want to

Re: Review Request 121536: Actually set the palette when it changes

2014-12-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121536/ --- (Updated Dec. 15, 2014, 11:02 p.m.) Status -- This change has been m

Jenkins build became unstable: kservice_stable_qt5 #13

2014-12-15 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121536: Actually set the palette when it changes

2014-12-15 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121536/#review72102 --- Could we test this somehow? - Àlex Fiestas On des. 15, 2014

OSX/CI: QSP patch ( was "KF5 Update Meeting Minutes 2014-w28" )

2014-12-15 Thread Marko Käning
Hi David, back to our discussion during this summer: On 10 Jul 2014, at 11:57 , David Faure wrote: > Wrong approach. XDG is a freedesktop thing which doesn't apply to Mac. > > This should be fixed the other way around: > 1) finding out how Mac OS lets people configure the location for their fil

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-15 Thread Alex Merry
> On Dec. 12, 2014, 2:08 p.m., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > > > > > Would this actually work? The code looks to me like pattern_rx would > > just be the filename again, so fn wou

Change in kio[master]: Import KCM documentation from plasma-desktop.git.

2014-12-15 Thread Eike Hein (Code Review)
Eike Hein has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/243 Change subject: Import KCM documentation from plasma-desktop.git. .. Import KCM documentation from plasma-desktop.git. This moves the han

Re: Baloo Framework - License Exception

2014-12-15 Thread Albert Astals Cid
El Dilluns, 15 de desembre de 2014, a les 13:13:12, Sebastian Kügler va escriure: > Hi, > > On Monday, December 15, 2014 10:34:46 Jonathan Riddell wrote: > > On Mon, Dec 15, 2014 at 09:27:48AM +0100, Martin Gräßlin wrote: > > > > Baloo is still LGPL, when you aggregate it current Xapian code the

Re: Baloo Framework - License Exception

2014-12-15 Thread Albert Astals Cid
El Dilluns, 15 de desembre de 2014, a les 12:21:38, Ivan Čukić va escriure: > > Albert is right, Baloo is LGPL but the resulting binaries will be GPL. > > Again, this serves no purpose other than 'we are using LGPL' since libbaloo > clients can not be non-free - they will have to link to the GPL b

Re: Relicensing parts of kglobalacceld

2014-12-15 Thread Andreas Hartmetz
On Monday 15 December 2014 18:59:56 Martin Klapetek wrote: > Hey guys, > > we're in the process of moving kglobalacceld as part of the > kglobalaccel framework. > The framework is licensed under LGPLv2.1+ and the runtime daemon was > licensed > under LGPLv2+ so it got relicensed to LGPLv2.1+. > >

Re: Relicensing parts of kglobalacceld

2014-12-15 Thread Michael Jansen
Hi Do with it anything you want :). That applies to all my kde code contributions. Is that enough? (i am not subscribed to frameworks-devel). Mike On Monday 15 December 2014 18:59:56 you wrote: > Hey guys, > > we're in the process of moving kglobalacceld as part of the kglobalaccel > framewo

Re: Baloo Framework - License Exception

2014-12-15 Thread Ivan Čukić
> If we make Baloo GPL and then happen to change the database > used we would have to relicense all of Baloo. That would be a lot > of admin work contacting all developers. I'm not advocating changing the library headers to GPL*, just not saying the library is LGPL, when it can not be *used* as an

Re: Review Request 121536: Actually set the palette when it changes

2014-12-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121536/#review72081 --- Ship it! Ship It! - Martin Gräßlin On Dec. 15, 2014, 6:10

Re: OSX/CI: kmime fails to build on branch master

2014-12-15 Thread Marko Käning
Hi Aleix, On 15 Dec 2014, at 03:01 , Aleix Pol wrote: > Thanks for looking into this! :) I won’t look any deeper for now, as it is an issue with the build system itself. I hope this can be clarified once an official OSX build slave is up and running. Greets, Marko _

Re: Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-15 Thread Martin Klapetek
On Mon, Dec 15, 2014 at 1:55 PM, Martin Gräßlin wrote: > > > Given the basically non-existing feedback on the thread (modulo Alex's > reply) > I would assume that everything is fine and we can just move the code. If > you > want to take care of it, I would certainly appreciate this. > I've relice

Relicensing parts of kglobalacceld

2014-12-15 Thread Martin Klapetek
Hey guys, we're in the process of moving kglobalacceld as part of the kglobalaccel framework. The framework is licensed under LGPLv2.1+ and the runtime daemon was licensed under LGPLv2+ so it got relicensed to LGPLv2.1+. But one file, the main.cpp, is still LGPLv2 and you're the copyright holders

Re: Baloo Framework - License Exception

2014-12-15 Thread David Edmundson
On Mon, Dec 15, 2014 at 12:21 PM, Ivan Čukić wrote: > > > Albert is right, Baloo is LGPL but the resulting binaries will be GPL. > > Again, this serves no purpose other than 'we are using LGPL' since > libbaloo clients can not be non-free - they will have to link to the GPL > binary. > > I'd rathe

Re: Review Request 121536: Actually set the palette when it changes

2014-12-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121536/ --- (Updated Dec. 15, 2014, 5:10 p.m.) Review request for KDE Frameworks. R

Re: Review Request 121536: Actually set the palette when it changes

2014-12-15 Thread Martin Gräßlin
> On Dec. 15, 2014, 5:58 p.m., Martin Gräßlin wrote: > > src/platformtheme/khintssettings.cpp, lines 209-211 > > > > > > shouldn't that be QGuiApplication? > > David Edmundson wrote: > You would have thought

Re: Review Request 121536: Actually set the palette when it changes

2014-12-15 Thread David Edmundson
> On Dec. 15, 2014, 4:58 p.m., Martin Gräßlin wrote: > > src/platformtheme/khintssettings.cpp, lines 209-211 > > > > > > shouldn't that be QGuiApplication? You would have thought so, but it doesn't work. I coul

Re: Review Request 121536: Actually set the palette when it changes

2014-12-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121536/#review72074 --- src/platformtheme/khintssettings.cpp

Review Request 121536: Actually set the palette when it changes

2014-12-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121536/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Re: Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-15 Thread Martin Gräßlin
On Friday 12 December 2014 12:38:20 Martin Klapetek wrote: > On Fri, Oct 3, 2014 at 1:16 PM, Alex Merry wrote: > > On 2014-09-17 10:47, Martin Gräßlin wrote: > >> Hi all, > >> > >> I just prepared moving kglobalacceld from plasma-workspace into > >> kglobalaccel. > >> You can find the code in my

Re: Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

2014-12-15 Thread Martin Gräßlin
On Friday 12 December 2014 13:04:59 Aleix Pol wrote: > On Wed, Sep 17, 2014 at 11:47 AM, Martin Gräßlin wrote: > > Hi all, > > > > I just prepared moving kglobalacceld from plasma-workspace into > > kglobalaccel. You can find the code in my personal clone of kglobalaccel > > at [1] in branch mast

Re: Baloo Framework - License Exception

2014-12-15 Thread Sebastian Kügler
Hi, On Monday, December 15, 2014 10:34:46 Jonathan Riddell wrote: > On Mon, Dec 15, 2014 at 09:27:48AM +0100, Martin Gräßlin wrote: > > > Baloo is still LGPL, when you aggregate it current Xapian code the > > > result > > > becomes GPL, but I could write something different with the same header >

Re: KF 5.6 and Plasma 5.2

2014-12-15 Thread Sebastian Kügler
On Sunday, December 14, 2014 01:04:53 David Edmundson wrote: > That's the plan. > > Plasma releases have already been shifted to account for that. > Plasma 5.2 Beta is being tagged on the 8th of Jan, releasing on the 13th. > Frameworks are released in the first week of every month. > > I believe

Re: Baloo Framework - License Exception

2014-12-15 Thread Ivan Čukić
> Albert is right, Baloo is LGPL but the resulting binaries will be GPL. Again, this serves no purpose other than 'we are using LGPL' since libbaloo clients can not be non-free - they will have to link to the GPL binary. I'd rather have an exception to the rule than having something that will con

Re: Baloo Framework - License Exception

2014-12-15 Thread Jonathan Riddell
On Mon, Dec 15, 2014 at 10:32:53AM +0100, Martin Gräßlin wrote: > well yes, that's how the blob drivers like NVIDIA do not need to be GPL - at > least that's what the affected parties claim. the Nvidia drivers do need to be GPL, that they're not just means they're important enough that people tol

Re: Baloo Framework - License Exception

2014-12-15 Thread Jonathan Riddell
On Mon, Dec 15, 2014 at 09:27:48AM +0100, Martin Gräßlin wrote: > > Baloo is still LGPL, when you aggregate it current Xapian code the result > > becomes GPL, but I could write something different with the same header > > interface as Xapian and make it LGPL, and then the aggregation would be > > L

Re: Review Request 121471: Port KDirSelectDialog to QFileDialog

2014-12-15 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121471/ --- (Updated Pro. 15, 2014, 9:59 dop.) Review request for KDE Frameworks, Bhu

Re: Re: Re: Baloo Framework - License Exception

2014-12-15 Thread Ivan Čukić
> well yes, that's how the blob drivers like NVIDIA do not need to be GPL - > at > least that's what the affected parties claim. > There is a difference there. The kernel modules are a bit of a special case for some reason. They are only implementing an interface, and they are not distributed as

Change in kio[master]: New job: KIO::DropJob *KIO::drop(QDropEvent* ev, QUrl destUrl).

2014-12-15 Thread David Faure (Code Review)
David Faure has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/241 Change subject: New job: KIO::DropJob *KIO::drop(QDropEvent* ev, QUrl destUrl). .. New job: KIO::DropJob *KIO::drop(QDropEvent* ev, QUrl

Re: Re: Re: Baloo Framework - License Exception

2014-12-15 Thread Martin Gräßlin
On Monday 15 December 2014 10:11:30 Ivan Čukić wrote: > > not. If there is baloo internal an abstraction allowing to easily > > > > swap out Xapian by something different I would say it's not > > > > derived work. But if Xapian is deeply wired into Baloo I would say > > > > it's derived work. >

Re: Re: Baloo Framework - License Exception

2014-12-15 Thread Ivan Čukić
> not. If there is baloo internal an abstraction allowing to easily > swap out Xapian by something different I would say it's not > derived work. But if Xapian is deeply wired into Baloo I would say > it's derived work. >From "Why you shouldn't use the Lesser GPL for your next library", a docu

Re: Re: Baloo Framework - License Exception

2014-12-15 Thread Martin Gräßlin
On Sunday 14 December 2014 00:33:20 Albert Astals Cid wrote: > El Dimarts, 9 de desembre de 2014, a les 15:22:15, Vishesh Handa va escriure: > > Hey guys > > > > I would like to promote Baloo to be a framework for 5.6. > > > > All of Baloo's code is LGPL, however, we internally use Xapian as a f

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-15 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/ --- (Updated Dez. 15, 2014, 9:01 vorm.) Review request for Extra Cmake Module