Re: Review Request 121712: Add install target for the KF5 Book

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121712/#review72687 --- looks right to me - Sune Vuorela On Dec. 28, 2014, 11:58 p.

[kapidox] src: Workaround broken metadata in the NetworkManager-Qt Framework which broke all Frameworks API generation on api.kde.org.

Git commit 6843f218411db3dba8d5fb53a578564dcb67d50e by Ben Cooksley. Committed on 29/12/2014 at 10:10. Pushed by bcooksley into branch 'master'. Workaround broken metadata in the NetworkManager-Qt Framework which broke all Frameworks API generation on api.kde.org. CCMAIL: release-t...@kde.org CCM

Re: Review Request 121581: Plotter in kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121581/ --- (Updated Dec. 29, 2014, 12:17 p.m.) Review request for KDE Frameworks and

Re: Review Request 120388: Do not sync if wallet file does not exist

> On Dec. 29, 2014, 3:58 a.m., David Faure wrote: > > low-level review: no need to create a QFile, use QFile::exists(path) > > > > higher-level review: ensuring that a file exists before calling KSaveFile, > > which *creates* the file, sounds weird. I mean, isn't this exactly what > > will hap

Re: Review Request 120388: Do not sync if wallet file does not exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/ --- (Updated Dec. 29, 2014, 6:47 p.m.) Review request for KDE Frameworks, Àle

Build failed in Jenkins: plasma-framework_stable_qt5 » All,LINBUILDER #43

See Changes: [notmart] migrate to KPackage -- Started by upstream project "plasma-framework_stable_qt5" build number 43 originally caused by: Started by remo

Build failed in Jenkins: plasma-framework_stable_qt5 » NoX11,LINBUILDER #43

See Changes: [notmart] migrate to KPackage -- Started by upstream project "plasma-framework_stable_qt5" build number 43 originally caused by: Started by re

Jenkins build became unstable: plasma-framework_master_qt5 » All,LINBUILDER #932

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_stable_qt5 » All,LINBUILDER #44

See Changes: [kde] Set visibility on mainItem to match Dialog -- Started by upstream project "plasma-framework_stable_qt5" build number 44 originally caused b

Build failed in Jenkins: plasma-framework_stable_qt5 » NoX11,LINBUILDER #44

See Changes: [kde] Set visibility on mainItem to match Dialog -- Started by upstream project "plasma-framework_stable_qt5" build number 44 originally caused

Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #933

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121618: Better name for kdoctools translation domain

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121618/ --- (Updated Dec. 29, 2014, 2:32 p.m.) Status -- This change has been ma

Re: OSX/CI: QSP patch ( was "KF5 Update Meeting Minutes 2014-w28" )

Hi Interesting. Would you mind giving some context, arguments behind choices and things like that? Also, do I understand correctly that you set Oxygen as the default style? Does it work correctly on Ms Windows? On 28 Dec 2014, at 01:24, Andrius da Costa Ribas wrote: > In our Windows Emerge s

Build failed in Jenkins: krunner_master_qt5 #114

See Changes: [me] Do not detect anything with a '.' as a NetworkLocation [me] Fix unused variables warnings [me] RunnerManager: Remove unused variable loadAll [me] QueryMatchPrivate: Rename local variable --

Required and supported Qt versions

Hi, is there a minimal required Qt version which applies to all of KF5? I see that most of the modules I currently have checked out say that they need 5.2.0 while polkit-qt-1 declares itself compatible with 5.1.0. - Is that information correct? Is 5.2.0 universally supported? - Is there any va

Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121737/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Re: Review Request 121315: Allow using kded modules with JSON metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121315/ --- (Updated Dez. 29, 2014, 5:55 nachm.) Review request for KDE Frameworks an

Re: Review Request 121315: Allow using kded modules with JSON metadata

> On Dez. 20, 2014, 11:58 vorm., David Faure wrote: > > Looks good to me overall (for the details, you're the expert ;) > > > > Good example of how to port from KServiceTypeTrader to KPluginMetaData. Is > > that documented somewhere else BTW? > > > > (Right now I would even need a solution for

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121737/#review72724 --- propertyNames() includes the common stuff like Name, Comment,

Re: Review Request 121315: Allow using kded modules with JSON metadata

> On Dec. 20, 2014, 11:58 a.m., David Faure wrote: > > Looks good to me overall (for the details, you're the expert ;) > > > > Good example of how to port from KServiceTypeTrader to KPluginMetaData. Is > > that documented somewhere else BTW? > > > > (Right now I would even need a solution for

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

> On Dez. 29, 2014, 5:56 nachm., David Faure wrote: > > propertyNames() includes the common stuff like Name, Comment, etc. > > > > So maybe this removes the need for the code that follows? Or at least a > > good part of it? Yeah we probably don't want those properties, do you think letting KPl

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

> On Dec. 29, 2014, 5:56 p.m., David Faure wrote: > > propertyNames() includes the common stuff like Name, Comment, etc. > > > > So maybe this removes the need for the code that follows? Or at least a > > good part of it? > > Alex Richardson wrote: > Yeah we probably don't want those prope

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

> On Dez. 29, 2014, 5:56 nachm., David Faure wrote: > > propertyNames() includes the common stuff like Name, Comment, etc. > > > > So maybe this removes the need for the code that follows? Or at least a > > good part of it? > > Alex Richardson wrote: > Yeah we probably don't want those pro

Jenkins build is back to normal : plasma-framework_stable_qt5 » All,LINBUILDER #45

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121737/ --- (Updated Dez. 29, 2014, 7:30 nachm.) Review request for KDE Frameworks an

Jenkins build is back to normal : plasma-framework_stable_qt5 » NoX11,LINBUILDER #45

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121737/ --- (Updated Dez. 29, 2014, 7:34 nachm.) Review request for KDE Frameworks an

Re: Review Request 121737: KPluginInfo: Fix properties not being copied from KService::Ptr

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121737/#review72744 --- Yep, looks better to me. Could be unittested? - David Faure

Re: Review Request 121461: Fix for bug 341773 and minor changes

> On Dec. 26, 2014, 8:14 a.m., David Faure wrote: > > This has been reverted for now, it broke the kio_trash unittest, because it > > doesn't preserve extensions anymore. Please revisit. > > Arjun AK wrote: > Like i said in the ML, what should be done with the following files: > `.txt`

Re: Review Request 120388: Do not sync if wallet file does not exist

> On Sept. 27, 2014, 11:59 a.m., Arjun AK wrote: > > src/runtime/kwalletd/backend/kwalletbackend.cc, line 421 > > > > > > Is the return value correct? Perhaps better file a bug report? - Valentin ---

Re: Review Request 120388: Do not sync if wallet file does not exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review72750 --- Ship it! Looks goot to me. - Valentin Rusu On Dec. 29, 201

Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121747/ --- Review request for KDE Frameworks, Lukáš Tinkl, Mark Gaiser, and Martin Kl

Re: Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121747/#review72758 --- +1 I like it. Some late-night nitpicking. Feel free to ignore

Re: Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121747/#review72757 --- Ship it! autotests/kfiledialog_unittest.cpp

Build failed in Jenkins: kio_stable_qt5 #56

See Changes: [Kevin Funk] Quick MSVC build fix for Qt < v5.4 -- [...truncated 895 lines...] [ 13%] Scanning dependencies of target udsentry_benchmark_automoc Generating kurlrequestertest.moc Built target