Re: Review Request 121786: Fix crash accessing dangling pointer in NotifyByPopup

2015-01-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121786/ --- (Updated Jan. 2, 2015, 12:27 a.m.) Status -- This change has been ma

Re: Review Request 121786: Fix crash accessing dangling pointer in NotifyByPopup

2015-01-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121786/#review72889 --- Ship it! Oh good catch...I would have thought it would just c

Review Request 121786: Fix crash accessing dangling pointer in NotifyByPopup

2015-01-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121786/ --- Review request for KDE Frameworks. Repository: knotifications Descripti

Re: Review Request 119607: Support for ".hidden" files

2015-01-01 Thread Bruno Nova
> On Jan. 1, 2015, 10:02 p.m., David Faure wrote: > > Thanks for the updated patch. > > > > I wrote a unittest for it, it works, so I pushed both, to wrap this up. > > Feel free to extend the test if you see missing testcases. > > > > I'm not too happy about the sleep(1s) in the unittest, but

Re: Review Request 119607: Support for ".hidden" files

2015-01-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119607/#review72882 --- Ship it! Thanks for the updated patch. I wrote a unittest fo

Re: Review Request 119607: Support for ".hidden" files

2015-01-01 Thread Bruno Nova
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119607/ --- (Updated Jan. 1, 2015, 9:55 p.m.) Status -- This change has been mar

Re: Review Request 121299: Add NET::OSD window type

2015-01-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121299/#review72873 --- Ping Is there anything else missing? 5.6 tagging is Saturday