Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

> On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: > > Hi Christoph, > > > > I’ve found that these projects do not make use of > > KF5_INSTALL_TARGETS_DEFAULT_ARGS at the moment: > > > > - systemsettings > > - muon > > - rocs > > - libkdegames > > - kiten > > - cantor > > - kolourpa

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: > Hi Christoph, > > I’ve found that these projects do not make use of > KF5_INSTALL_TARGETS_DEFAULT_ARGS at the moment: > > - systemsettings > - muon > - rocs > - libkdegames > - kiten > - cantor > - kolourpaint > - libkmahjongg > >

Re: Review Request 121885: Properly check for systray being available

> On Jan. 6, 2015, 7:20 p.m., David Edmundson wrote: > > src/platformtheme/kdeplatformsystemtrayicon.cpp, line 330 > > > > > > the statusnotifierwatcher is a kded module, which means if another kded > > module t

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

> On gen. 6, 2015, 11:55 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 5 > > > > > > Unrelated. And why? Because not all of us are bleeding edge that have everything up to date and requiring ecm 1.6 he

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121838/#review73316 --- CMakeLists.txt

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121838/ --- (Updated Jan. 6, 2015, 11:55 p.m.) Status -- This change has been ma

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121838/#review73314 --- Ship it! Thanks, LGTM. If possible, could you please split t

Re: OSX/CI: kfilemetadata fails to build on branch master

On 07 Jan 2015, at 00:23 , David Faure wrote: > Thanks, but now I think it was the wrong fix. > > The right fix is https://github.com/taglib/taglib/pull/495 > > Once that's in, I'll revert my changes to kfilemetadata and plasma- > mediacenter. ah, I see. So my assumption in the corresponding RR

Re: OSX/CI: kfilemetadata fails to build on branch master

On Tuesday 06 January 2015 21:46:16 Marko Käning wrote: > Hi David, > > thanks for taking care of the taglib issue. > > The kfilemetadata FW eventually built successfully on OSX/MacPorts. Thanks, but now I think it was the wrong fix. The right fix is https://github.com/taglib/taglib/pull/495 O

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

Yes, ecm changed recently. On Tue, Jan 6, 2015 at 3:55 PM, Marko Käning wrote: > Hi Christoph, > > I’ve found that these projects do not make use of > KF5_INSTALL_TARGETS_DEFAULT_ARGS > at the moment: > > - systemsettings > - muon > - rocs > - libkdegames > - kiten > - cantor > - kolourpa

Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

Hi Christoph, I’ve found that these projects do not make use of KF5_INSTALL_TARGETS_DEFAULT_ARGS at the moment: - systemsettings - muon - rocs - libkdegames - kiten - cantor - kolourpaint - libkmahjongg See for details below in order of appearance. I figure this is only the beginning o

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121838/ --- (Updated gen. 6, 2015, 10:41 p.m.) Review request for KDE Frameworks and

Re: OSX/CI: kio-extras fails to build on branch master

Perfect, I'll try that. On Tue, Jan 6, 2015 at 2:53 PM, Marko Käning wrote: > Hi Jeremy, > > I had to use "-dbus-linked" for qt5 to make it work at the time [1]. Never > tried something else up to now. > > Marko > > > [1] > https://trac.macports.org/wiki/KDEProblems/KDEMacPortsCI/Status#Setupbui

Re: OSX/CI: kio-extras fails to build on branch master

Hi Jeremy, I had to use "-dbus-linked" for qt5 to make it work at the time [1]. Never tried something else up to now. Marko [1] https://trac.macports.org/wiki/KDEProblems/KDEMacPortsCI/Status#SetupbuildenvironmentforQt5 ___ Kde-frameworks-devel mail

Re: OSX/CI: kio-extras fails to build on branch master

Well, I just attempted to try building kio-extras (I guess it's in kde/workspace in projects.kde.org right? And my qt build doesn't have dbus somehow, what do you use when you configure Qt to build in the CI system ? I've been talking to thiago in #qt and he said some of his changes just hit the 5.

Re: OSX/CI: kio-extras fails to build on branch master

Hi Jeremy, On 06 Jan 2015, at 22:39 , Jeremy Whiting wrote: > I think this is the same problem that kconfig had last week. i.e. we need to > change INSTALL_TARGET_ARGS to KDE_INSTALL_TARGET_ARGS. I'll take a look. yes, see the discussion with Milian and Christopher in thread “OSX/CI: konsole

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

> On Jan. 4, 2015, 12:02 p.m., David Faure wrote: > > This undoes 4846b50aea0bc2262238963a85ab3556c22412e4 > > (https://git.reviewboard.kde.org/r/117010/), basically. > > > > However looking back at the discussions with Alexander Richardson, this > > might be only a revert of the part that wen

Re: OSX/CI: kio-extras fails to build on branch master

I think this is the same problem that kconfig had last week. i.e. we need to change INSTALL_TARGET_ARGS to KDE_INSTALL_TARGET_ARGS. I'll take a look. On Tue, Jan 6, 2015 at 12:59 PM, Marko Käning wrote: > kio-extras fails due to this: > --- > CMake Error at network/network/CMakeLists.txt:69 (ins

AW: Re: OSX/CI: konsole fails to build on branch master

Sure. I can patch that then if i have a list. - Marko Käning schrieb: > Hi Christoph, > > On 06 Jan 2015, at 22:18 , Christoph Cullmann wrote: > > Just patch all occurences and avoid sending mails for that, I did only > > patch the frameworks that I did try to build on the Mac. > > ok, I

Re: OSX/CI: konsole fails to build on branch master

Hi Christoph, On 06 Jan 2015, at 22:18 , Christoph Cullmann wrote: > Just patch all occurences and avoid sending mails for that, I did only patch > the frameworks that I did try to build on the Mac. ok, I personally don’t want to mess in all the projects the CI system is going to fail on in th

Re: OSX/CI: konsole fails to build on branch master

> On Tuesday 06 January 2015 22:14:06 Marko Käning wrote: > > Hi Christoph, > > > > On 06 Jan 2015, at 22:10 , Christoph Cullmann wrote: > > > I think the problem is that it should be > > > KF5_INSTALL_TARGETS_DEFAULT_ARGS, > > > the prefix is missing in many cmake files. > > > > yep, now I do r

Re: OSX/CI: konsole fails to build on branch master

On Tuesday 06 January 2015 22:14:06 Marko Käning wrote: > Hi Christoph, > > On 06 Jan 2015, at 22:10 , Christoph Cullmann wrote: > > I think the problem is that it should be KF5_INSTALL_TARGETS_DEFAULT_ARGS, > > the prefix is missing in many cmake files. > > yep, now I do remember one of your co

Re: OSX/CI: konsole fails to build on branch master

Hi Christoph, On 06 Jan 2015, at 22:10 , Christoph Cullmann wrote: > I think the problem is that it should be KF5_INSTALL_TARGETS_DEFAULT_ARGS, > the prefix is missing in many cmake files. yep, now I do remember one of your commits from a few days back… So this is the same issue found i

INSTALL_TARGETS_DEFAULT_ARGS (was "OSX/CI: .* fails to build on branch .*")

Hi Milian, On 06 Jan 2015, at 21:57 , Milian Wolff wrote: > On Tuesday 06 January 2015 21:43:03 Marko Käning wrote: >> CMake Error at src/CMakeLists.txt:178 (install): >> install TARGETS given no LIBRARY DESTINATION for shared library target >> "konsoleprivate". > > Again, please stop this spa

Re: OSX/CI: konsole fails to build on branch master

> On Tuesday 06 January 2015 21:43:03 Marko Käning wrote: > > CMake Error at src/CMakeLists.txt:178 (install): > > install TARGETS given no LIBRARY DESTINATION for shared library target > > "konsoleprivate". > > Again, please stop this spamming. Group the mails, they _all_ show the same > erro

OSX/CI: kde-baseapps fails to build on branch frameworks

CMake Error at keditbookmarks/kbookmarkmodel/CMakeLists.txt:23 (install): install TARGETS given unknown argument "BUNDLE". CMake Error at keditbookmarks/CMakeLists.txt:48 (install): install TARGETS given unknown argument "BUNDLE”. CMake Error at keditbookmarks/CMakeLists.txt:82 (install):

Re: OSX/CI: konsole fails to build on branch master

On Tuesday 06 January 2015 21:43:03 Marko Käning wrote: > CMake Error at src/CMakeLists.txt:178 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "konsoleprivate". Again, please stop this spamming. Group the mails, they _all_ show the same error. And it's b

Re: OSX/CI: kdev-ruby fails to build on branch master

Hi Albert, On 06 Jan 2015, at 21:47 , Albert Astals Cid wrote: > Why are you sending kdev-ruby build failures to this list instead of to the > kdevelop list? thanks for pointing that out. Wrong addressee, yes, indeed! :-) I’ve resent it to kdevelop. Happy New Year to you! Marko __

Re: OSX/CI: kdev-ruby fails to build on branch master

Why are you sending kdev-ruby build failures to this list instead of to the kdevelop list? Cheers, Albert El Dimarts, 6 de gener de 2015, a les 21:13:38, Marko Käning va escriure: > CMake Error at parser/CMakeLists.txt:35 (install): > install TARGETS given no LIBRARY DESTINATION for shared l

Re: OSX/CI: kfilemetadata fails to build on branch master

Hi David, thanks for taking care of the taglib issue. The kfilemetadata FW eventually built successfully on OSX/MacPorts. Happy New Year to you, Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listi

OSX/CI: konsole fails to build on branch master

CMake Error at src/CMakeLists.txt:178 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "konsoleprivate". CMake Error at src/CMakeLists.txt:198 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "kdeinit_konsole". ___

OSX/CI: oxygen fails to build on branch master

CMake Error at liboxygen/CMakeLists.txt:78 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "oxygenstyle5". CMake Error at liboxygen/CMakeLists.txt:148 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "oxygenstyleconfig5".

OSX/CI: libkpeople fails to build on branch master

CMake Error at src/widgets/CMakeLists.txt:51 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "KPeopleWidgets". ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/k

OSX/CI: kdev-ruby fails to build on branch master

CMake Error at parser/CMakeLists.txt:35 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "kdevrubyparser". CMake Error at duchain/CMakeLists.txt:35 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "kdevrubyduchain". CMake

Build failed in Jenkins: kglobalaccel_stable_qt5 #8

See Changes: [mklapetek] Replace Q_WS_* macros to Q_OS_* macros -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUIL

Jenkins build is back to normal : kglobalaccel_master_qt5 #75

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kglobalaccel_stable_qt5 #7

See Changes: [mklapetek] Set the translation domain of the daemon to kglobalaccel5 -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave -

OSX/CI: kio-extras fails to build on branch master

kio-extras fails due to this: --- CMake Error at network/network/CMakeLists.txt:69 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "molletnetwork". --- ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.or

Build failed in Jenkins: kglobalaccel_stable_qt5 #6

See Changes: [mklapetek] Remove #include for removed header [mklapetek] Extract i18n strings into kglobalaccel5.pot -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit

Build failed in Jenkins: kglobalaccel_master_qt5 #74

See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace

Re: Linux/CI & OSX/CI: kglobalaccel is failing to build on branches stable and master

Hi Martin, On 06 Jan 2015, at 20:00 , Martin Klapetek wrote: > Ahh yes, I prepared this and then got carried away by other work, this needs > to be done. ok, I will commit these changes then right away. > KGlobalAccel got the runtime daemon added into the framework today > and is now tier3 (s

Re: Linux/CI & OSX/CI: kglobalaccel is failing to build on branches stable and master

Hey, On Tue, Jan 6, 2015 at 7:56 PM, Marko Käning wrote: > Hi devs, > > kglobalaccel is currently failing on Jenkins [1]. > > > This can partially be fixed by inserting some dependencies for it: > --- > diff --git a/dependency-data-kf5-qt5 b/dependency-data-kf5-qt5 > index 55b4141..91ac810 10064

Linux/CI & OSX/CI: kglobalaccel is failing to build on branches stable and master

Hi devs, kglobalaccel is currently failing on Jenkins [1]. This can partially be fixed by inserting some dependencies for it: --- diff --git a/dependency-data-kf5-qt5 b/dependency-data-kf5-qt5 index 55b4141..91ac810 100644 --- a/dependency-data-kf5-qt5 +++ b/dependency-data-kf5-qt5 @@ -16,6 +16,

Re: Review Request 121885: Properly check for systray being available

> On Jan. 6, 2015, 7:20 p.m., David Edmundson wrote: > > src/platformtheme/kdeplatformsystemtrayicon.cpp, line 330 > > > > > > the statusnotifierwatcher is a kded module, which means if another kded > > module t

Re: Review Request 121885: Properly check for systray being available

> On Jan. 6, 2015, 7:20 p.m., David Edmundson wrote: > > src/platformtheme/kdeplatformsystemtrayicon.cpp, line 330 > > > > > > the statusnotifierwatcher is a kded module, which means if another kded > > module t

Re: Review Request 121885: Properly check for systray being available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121885/#review73291 --- src/platformtheme/kdeplatformsystemtrayicon.cpp

Review Request 121885: Properly check for systray being available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121885/ --- Review request for KDE Frameworks. Bugs: 339707 https://bugs.kde.org/

Re: Baloo Framework - License Exception

On Tuesday 06 January 2015 11:01:19 David Faure wrote: > Well, that's interesting, I didn't expect you would reply that :-) You probably picture me as wanting KF to grow wide and large as much as possible. That'd be wrong. I actually have this concern that we might reach a point of "too much stu

Re: Review Request 121862: Move the kglobalaccel runtime into the framework

> On Jan. 6, 2015, 5:35 p.m., Hrvoje Senjan wrote: > > src/runtime/CMakeLists.txt, line 1 > > > > > > i guess this should now be kglobalaccel5? > > Martin Klapetek wrote: > The Messages.sh extracts it to kglob

Re: Review Request 121862: Move the kglobalaccel runtime into the framework

> On Jan. 6, 2015, 5:35 p.m., Hrvoje Senjan wrote: > > src/runtime/CMakeLists.txt, line 1 > > > > > > i guess this should now be kglobalaccel5? > > Martin Klapetek wrote: > The Messages.sh extracts it to kglob

Re: Review Request 121862: Move the kglobalaccel runtime into the framework

> On Jan. 6, 2015, 5:35 p.m., Hrvoje Senjan wrote: > > src/runtime/CMakeLists.txt, line 1 > > > > > > i guess this should now be kglobalaccel5? The Messages.sh extracts it to kglobalaccel.pot, so this is correct.

Re: Review Request 121862: Move the kglobalaccel runtime into the framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121862/#review73277 --- src/runtime/CMakeLists.txt

Re: Review Request 121471: Port KDirSelectDialog to QFileDialog

> On Led. 4, 2015, 5:12 odp., David Faure wrote: > > Just like we have KFileWidget for an embeddable file-selection-widget, we > > could very well have a KDirSelectWidget for an embeddable > > dir-selection-widget. > > > > The code is currently in > > frameworkintegration/src/platformtheme/kd

Re: Review Request 121862: Move the kglobalaccel runtime into the framework

> On Jan. 6, 2015, 3:35 p.m., Martin Klapetek wrote: > > What should I do with the framework version number? Right now it says 5.6 > > but given this won't be in 5.6, should this be bumped now? That way we can > > put a check in plasma for it and disable building the internal copy. Also > > is

Re: Baloo Framework - License Exception

On Tue, Jan 6, 2015 at 11:01 AM, David Faure wrote: > > Bottom line: since there's the possibility of a non-xapian backend making > > Baloo effectively LGPL and not effectively GPL, I'd be in favor of > waiting > > for it to be reality. > > We need a much shorter term solution than that, for prac

Build failed in Jenkins: kglobalaccel_stable_qt5 #5

See Changes: [mklapetek] Move the runtime component into the framework [mklapetek] Upgrade KF5 version to 5.7.0. [mklapetek] Remove the QWS part of the runtime module -- Started by remote host

Build failed in Jenkins: kglobalaccel_master_qt5 #73

See Changes: [mklapetek] Move the runtime component into the framework [mklapetek] Upgrade KF5 version to 5.7.0. [mklapetek] Remove the QWS part of the runtime module -- Started by remote host

Re: Review Request 121862: Move the kglobalaccel runtime into the framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121862/ --- (Updated Jan. 6, 2015, 2:56 p.m.) Status -- This change has been mar

Re: Review Request 121862: Move the kglobalaccel runtime into the framework

> On Jan. 6, 2015, 2:35 p.m., Martin Klapetek wrote: > > What should I do with the framework version number? Right now it says 5.6 > > but given this won't be in 5.6, should this be bumped now? That way we can > > put a check in plasma for it and disable building the internal copy. Also > > is

Re: Review Request 121862: Move the kglobalaccel runtime into the framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121862/#review73267 --- What should I do with the framework version number? Right now

Re: Review Request 121862: Move the kglobalaccel runtime into the framework

> On Jan. 6, 2015, 9:19 a.m., David Faure wrote: > > src/runtime/CMakeLists.txt, line 27 > > > > > > Hmm, this can be killed, no? :) QWS no longer exists. > > Martin Klapetek wrote: > Yup, the implementation

Re: Review Request 121862: Move the kglobalaccel runtime into the framework

> On Jan. 6, 2015, 3:25 p.m., David Faure wrote: > > src/runtime/CMakeLists.txt, line 4 > > > > > > QString("..") is fine as long as you don't remove the other one, > > QT_NO_CAST_FROM_ASCII. > > > > It's

Re: Review Request 121862: Move the kglobalaccel runtime into the framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121862/#review73263 --- src/runtime/CMakeLists.txt

Re: Review Request 121862: Move the kglobalaccel runtime into the framework

> On Jan. 6, 2015, 9:19 a.m., David Faure wrote: > > src/runtime/CMakeLists.txt, line 4 > > > > > > Is this one really necessary? Casting QString to char* is EVIL. There's quite some usage of QString("..")s in the

Re: Baloo Framework - License Exception

On Tuesday 06 January 2015 14:18:16 Albert Astals Cid wrote: > El Dimarts, 6 de gener de 2015, a les 13:06:19, David Faure va escriure: > > On Tuesday 06 January 2015 12:04:02 Albert Astals Cid wrote: > > > El Dimarts, 6 de gener de 2015, a les 11:01:19, David Faure va escriure: > > > > The problem

Re: Baloo Framework - License Exception

El Dimarts, 6 de gener de 2015, a les 13:06:19, David Faure va escriure: > On Tuesday 06 January 2015 12:04:02 Albert Astals Cid wrote: > > El Dimarts, 6 de gener de 2015, a les 11:01:19, David Faure va escriure: > > > The problem (and the reason I talk about shooting ourselves in the foot) > > > i

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

> On gen. 4, 2015, 5:02 p.m., David Faure wrote: > > This undoes 4846b50aea0bc2262238963a85ab3556c22412e4 > > (https://git.reviewboard.kde.org/r/117010/), basically. > > > > However looking back at the discussions with Alexander Richardson, this > > might be only a revert of the part that went

Re: Jenkins build became unstable: frameworkintegration_master_qt5 #150

On Tuesday 06 January 2015 10:56:46 KDE CI System wrote: > See FAIL! : KdePlatformTheme_UnitTest::testPlatformHints() Compared values are not the same Actual (m_qpa->themeHint(QPlatformTheme::CursorFlashTime).toInt()): 1

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

> On Jan. 4, 2015, 5:02 p.m., David Faure wrote: > > This undoes 4846b50aea0bc2262238963a85ab3556c22412e4 > > (https://git.reviewboard.kde.org/r/117010/), basically. > > > > However looking back at the discussions with Alexander Richardson, this > > might be only a revert of the part that went

Re: Baloo Framework - License Exception

On Tuesday 06 January 2015 12:04:02 Albert Astals Cid wrote: > El Dimarts, 6 de gener de 2015, a les 11:01:19, David Faure va escriure: > > The problem (and the reason I talk about shooting ourselves in the foot) > > is > > ... what do we do instead, then, to solve the KDE issue? > > We need to be

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

> On gen. 4, 2015, 5:02 p.m., David Faure wrote: > > This undoes 4846b50aea0bc2262238963a85ab3556c22412e4 > > (https://git.reviewboard.kde.org/r/117010/), basically. > > > > However looking back at the discussions with Alexander Richardson, this > > might be only a revert of the part that went

Re: Baloo Framework - License Exception

El Dimarts, 6 de gener de 2015, a les 11:01:19, David Faure va escriure: > The problem (and the reason I talk about shooting ourselves in the foot) is > ... what do we do instead, then, to solve the KDE issue? > We need to be able to use baloo in both "KDE Workspace" and "KDE > applications", which

Jenkins build became unstable: frameworkintegration_master_qt5 #150

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Baloo Framework - License Exception

Well, that's interesting, I didn't expect you would reply that :-) > That's assuming people will look for those details. I'm unsure they will. My suggestion is to make this fact as pro-eminent as possible. If the framework code itself was GPL, I would advocate calling the framework baloo-gpl. I

Re: Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

> On Jan. 4, 2015, 5:02 p.m., David Faure wrote: > > This undoes 4846b50aea0bc2262238963a85ab3556c22412e4 > > (https://git.reviewboard.kde.org/r/117010/), basically. > > > > However looking back at the discussions with Alexander Richardson, this > > might be only a revert of the part that went

Re: Review Request 121862: Move the kglobalaccel runtime into the framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121862/#review73243 --- Ship it! Looks good to me, apart from these few things. src