Review Request 121908: Fix unit test failure on machines with an empty ~/.qttest.

2015-01-07 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121908/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Re: Review Request 121903: Clean up how we deal with debug input

2015-01-07 Thread Martin Gräßlin
> On Jan. 7, 2015, 7:18 p.m., David Edmundson wrote: > > startkde/startkde.cmake, line 12 > > > > > > Order of evaluation: > > QtProject/qtlogging.ini > > setFilterRules() > > QT_LOGGING_CO

Jenkins build is back to normal : kglobalaccel_stable_qt5 #10

2015-01-07 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins build became unstable: frameworkintegration_master_qt5 #150

2015-01-07 Thread Ben Cooksley
On Thu, Jan 8, 2015 at 3:10 PM, Aleix Pol wrote: > On Tue, Jan 6, 2015 at 2:12 PM, David Faure wrote: >> On Tuesday 06 January 2015 10:56:46 KDE CI System wrote: >>> See >> >> FAIL! : KdePlatformTheme_UnitTest::testPlatformHi

Re: Jenkins build became unstable: frameworkintegration_master_qt5 #150

2015-01-07 Thread Aleix Pol
On Tue, Jan 6, 2015 at 2:12 PM, David Faure wrote: > On Tuesday 06 January 2015 10:56:46 KDE CI System wrote: >> See > > FAIL! : KdePlatformTheme_UnitTest::testPlatformHints() Compared values are > not the same >Actual (

Review Request 121907: Small code review

2015-01-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121907/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Re: Review Request 121903: Clean up how we deal with debug input

2015-01-07 Thread Aleix Pol Gonzalez
> On Jan. 7, 2015, 6:18 p.m., David Edmundson wrote: > > startkde/startkde.cmake, line 12 > > > > > > Order of evaluation: > > QtProject/qtlogging.ini > > setFilterRules() > > QT_LOGGING_CO

Re: Re: Compile KF5 into Docker

2015-01-07 Thread David Gil Oliva
Hi! 2015-01-07 2:25 GMT+01:00 Mathieu Tarral : > Hi David, > > Le 04/01/2015 13:55, David Gil Oliva a écrit : > > Hi! > > > > El dia 04/01/2015 12:39, "Mathieu Tarral" > > va escriure: > >> > >> Hi, > >> > >> as you know, building KF5 from source may not be an ea

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

2015-01-07 Thread Alex Merry
On Wednesday 07 January 2015 20:15:54 Christoph Cullmann wrote: > Hi, > > I see why KDE_INSTALL_TARGETS_DEFAULT_ARGS and INSTALL_TARGETS_DEFAULT_ARGS > fail on Mac, typo: > > # on the Mac support an extra install directory for application bundles > if(APPLE) > set(KDE_INSTALL_TARGETS_DEFAULT_

Re: Re: Compile KF5 into Docker

2015-01-07 Thread Mathieu Tarral
Hi David, Le 04/01/2015 13:55, David Gil Oliva a écrit : > Hi! > > El dia 04/01/2015 12:39, "Mathieu Tarral" > va escriure: >> >> Hi, >> >> as you know, building KF5 from source may not be an easy task, due to >> build dependencies which may or may not be availab

Re: Review Request 121885: Properly check for systray being available

2015-01-07 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121885/ --- (Updated Jan. 7, 2015, 9:10 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 121903: Clean up how we deal with debug input

2015-01-07 Thread Martin Klapetek
> On Jan. 7, 2015, 7:18 p.m., David Edmundson wrote: > > startkde/startkde.cmake, line 12 > > > > > > Order of evaluation: > > QtProject/qtlogging.ini > > setFilterRules() > > QT_LOGGING_CO

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

2015-01-07 Thread Marko Käning
On 07 Jan 2015, at 20:15 , Christoph Cullmann wrote: > will patch that ;=) Thanks for patching this so promptly! :-) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

2015-01-07 Thread Christoph Cullmann
Hi, I see why KDE_INSTALL_TARGETS_DEFAULT_ARGS and INSTALL_TARGETS_DEFAULT_ARGS fail on Mac, typo: # on the Mac support an extra install directory for application bundles if(APPLE) set(KDE_INSTALL_TARGETS_DEFAULT_ARGS ${INSTALL_TARGETS_DEFAULT_ARGS}

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

2015-01-07 Thread Marko Käning
Hi Alex, Hi Ben, Happy New Year, for a start! :) On 07 Jan 2015, at 19:48 , Alex Merry wrote: > On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: >> P.P.S.: I realised by now that there are no changes on the production >> branch, which probably means that there was some change in ECM or w

Re: Review Request 121903: Clean up how we deal with debug input

2015-01-07 Thread Aleix Pol Gonzalez
> On Jan. 7, 2015, 6:18 p.m., David Edmundson wrote: > > startkde/startkde.cmake, line 12 > > > > > > Order of evaluation: > > QtProject/qtlogging.ini > > setFilterRules() > > QT_LOGGING_CO

Jenkins build is back to normal : kdelibs_stable #1253

2015-01-07 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

2015-01-07 Thread Jeremy Whiting
I hit the same issues reported by Marko here on OS X also, and have no KDE_INSTALL_DIRS_NO_DEPRECATED set either. Maybe the logic in ecm is broken somehow? On Wed, Jan 7, 2015 at 11:48 AM, Alex Merry wrote: > On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: > > P.P.S.: I realised by now t

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

2015-01-07 Thread Alex Merry
On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: > P.P.S.: I realised by now that there are no changes on the production > branch, which probably means that there was some change in ECM or wherever > provoking these issues... I'm somewhat puzzled, as INSTALL_TARGET_DEFAULT_ARGS should still

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

2015-01-07 Thread Alex Merry
On Wednesday 07 January 2015 08:38:27 Kevin Funk wrote: > On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: > > Hi Christoph, > > > > I’ve found that these projects do not make use of > > > > KF5_INSTALL_TARGETS_DEFAULT_ARGS at the moment: > > - systemsettings > > - muon > > - rocs > >

Re: Review Request 121903: Clean up how we deal with debug input

2015-01-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121903/#review73399 --- +1 to removing the custom handler startkde/startkde.cmake

Jenkins build is back to normal : kio_master_qt5 #512

2015-01-07 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121903: Clean up how we deal with debug input

2015-01-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121903/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-workspac

Re: KF 5.6 changelog

2015-01-07 Thread Kåre Särs
On Wednesday 07 January 2015 15:01:39 Jonathan Riddell wrote: > > * Depend on libgit2 0.21.0 rather than unreleased 0.22.0 > > This seems not to be the case, top changelog item in ktexteditor currently > is "Depend on libgit2 v0.22.0 (older version is broken)" > Yes that commit to depend on 0.21

Re: KF 5.6 changelog

2015-01-07 Thread Jonathan Riddell
> * Depend on libgit2 0.21.0 rather than unreleased 0.22.0 This seems not to be the case, top changelog item in ktexteditor currently is "Depend on libgit2 v0.22.0 (older version is broken)" Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Baloo Framework - License Exception

2015-01-07 Thread Vishesh Handa
Hello people It seems that some people really do not want Baloo to become a framework as long as it is effectively GPL. We might want to think about not restricting ourselves in this way. If we didn't have plans to move away from Xapian it would effectively become a core library that a lot of appl

Re: Review Request 121895: Fix local issues in KIO build

2015-01-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121895/ --- (Updated Jan. 7, 2015, 1:41 p.m.) Status -- This change has been dis

Re: Review Request 121885: Properly check for systray being available

2015-01-07 Thread David Faure
> On Jan. 7, 2015, 8:10 a.m., David Faure wrote: > > src/platformtheme/kdeplatformsystemtrayicon.cpp, line 330 > > > > > > I don't see a deadlock here, unless StatusNotifierWatcher calls this > > method itself :

Re: Review Request 121895: Fix local issues in KIO build

2015-01-07 Thread Jeremy Whiting
> On Jan. 7, 2015, 5:35 a.m., Jeremy Whiting wrote: > > Ship It! Fixes it here. - Jeremy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121895/#review73359 -

Re: Review Request 121895: Fix local issues in KIO build

2015-01-07 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121895/#review73359 --- Ship it! Ship It! - Jeremy Whiting On Jan. 7, 2015, 4:52 a

Re: Review Request 121885: Properly check for systray being available

2015-01-07 Thread Martin Klapetek
> On Jan. 6, 2015, 7:20 p.m., David Edmundson wrote: > > src/platformtheme/kdeplatformsystemtrayicon.cpp, line 330 > > > > > > the statusnotifierwatcher is a kded module, which means if another kded > > module t

Re: Review Request 121885: Properly check for systray being available

2015-01-07 Thread Martin Klapetek
> On Jan. 7, 2015, 9:10 a.m., David Faure wrote: > > src/platformtheme/kdeplatformsystemtrayicon.cpp, line 330 > > > > > > I don't see a deadlock here, unless StatusNotifierWatcher calls this > > method itself :

Review Request 121895: Fix local issues in KIO build

2015-01-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121895/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 121885: Properly check for systray being available

2015-01-07 Thread David Edmundson
> On Jan. 6, 2015, 6:20 p.m., David Edmundson wrote: > > src/platformtheme/kdeplatformsystemtrayicon.cpp, line 330 > > > > > > the statusnotifierwatcher is a kded module, which means if another kded > > module t

Re: Review Request 121885: Properly check for systray being available

2015-01-07 Thread Martin Gräßlin
> On Jan. 6, 2015, 7:20 p.m., David Edmundson wrote: > > src/platformtheme/kdeplatformsystemtrayicon.cpp, line 330 > > > > > > the statusnotifierwatcher is a kded module, which means if another kded > > module t

Re: Review Request 121885: Properly check for systray being available

2015-01-07 Thread David Edmundson
> On Jan. 6, 2015, 6:20 p.m., David Edmundson wrote: > > src/platformtheme/kdeplatformsystemtrayicon.cpp, line 330 > > > > > > the statusnotifierwatcher is a kded module, which means if another kded > > module t

Build failed in Jenkins: kglobalaccel_stable_qt5 #9

2015-01-07 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUIL

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

2015-01-07 Thread David Faure
On Wednesday 07 January 2015 08:38:27 Kevin Funk wrote: > On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: > > Hi Christoph, > > > > I’ve found that these projects do not make use of > > > > KF5_INSTALL_TARGETS_DEFAULT_ARGS at the moment: > > - systemsettings > > - muon > > - rocs > >

Re: Review Request 121885: Properly check for systray being available

2015-01-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121885/#review73331 --- src/platformtheme/kdeplatformsystemtrayicon.cpp