Review Request 122007: Fix KTcpSocket to return correct negotiated protocol

2015-01-11 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122007/ --- Review request for KDE Frameworks, David Faure and Thiago Macieira. Repos

Review Request 122006: Manually access dtmf D-Bus interface.

2015-01-11 Thread Diane Trout
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122006/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: ktp

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121991/ --- (Updated Jan. 11, 2015, 10:39 p.m.) Status -- This change has been m

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121991/#review73791 --- Ship it! kf5/convert-to-cmake-automoc.pl

Re: OSX/CI: kactivities fails to build on branch master

2015-01-11 Thread Ivan Čukić
Hi, Some boost versions require exceptions (have bugs related to non-exception builds). Which version of boost is it? Ivan p.s. You can try building with -DKACTIVITIES_ENABLE_EXCEPTIONS ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

OSX/CI: kactivities fails to build on branch master

2015-01-11 Thread Marko Käning
Sorry, this meant of course kactivities and not captivities. :) Looks like a sole boost issue... > Gesendet: Freitag, 09. Januar 2015 um 19:03 Uhr > Von: "Marko Käning" > An: kde-frameworks-devel > Betreff: OSX/CI: captivities fails to build on branch master > > Linux/CI is quiet, but here on O

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121991/ --- (Updated Jan. 11, 2015, 7:29 p.m.) Review request for KDE Frameworks and

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121991/ --- (Updated Jan. 11, 2015, 7:26 p.m.) Review request for KDE Frameworks. C

Re: Review Request 121210: Provide an accessible name for KLed

2015-01-11 Thread José Millán Soto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121210/ --- (Updated Jan. 11, 2015, 7:11 p.m.) Status -- This change has been ma

Jenkins build is back to stable : kservice_stable_qt5 #25

2015-01-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kservice_stable_qt5 #24

2015-01-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121972: Make ksycocadicttest work when sycoca does not exist yet.

2015-01-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121972/ --- (Updated Jan. 11, 2015, 4:19 p.m.) Status -- This change has been ma

Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121991/ --- Review request for KDE Frameworks. Repository: kde-dev-scripts Descript

Re: Review Request 121922: support stringlists as properties

2015-01-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121922/#review73739 --- This sounds like something that could do with having a unittes

Re: Review Request 121972: Make ksycocadicttest work when sycoca does not exist yet.

2015-01-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121972/#review73736 --- Ship it! Oh! I see. OK. - David Faure On Jan. 10, 2015, 7:

Jenkins build is back to normal : kio_master_qt5 #521

2015-01-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kio_master_qt5 #520

2015-01-11 Thread KDE CI System
See Changes: [ralf.habacker] MingW32 cross compile fix. -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspa

Re: Review Request 121852: Fix cross compile error not using the correct case for windows api include file

2015-01-11 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121852/ --- (Updated Jan. 11, 2015, 10:47 vorm.) Status -- This change has been

Re: Review Request 121972: Make ksycocadicttest work when sycoca does not exist yet.

2015-01-11 Thread Alex Merry
> On Jan. 11, 2015, 1:03 a.m., David Faure wrote: > > Can you explain to me what the patch really changes? AFAICS this is a > > no-op. The same logic with a different syntax. > > Alex Merry wrote: > Lazy evaluation of || means that if KSycoca::isAvailable() returns false, > KServiceType::s

Re: Review Request 121972: Make ksycocadicttest work when sycoca does not exist yet.

2015-01-11 Thread Alex Merry
> On Jan. 11, 2015, 1:03 a.m., David Faure wrote: > > Can you explain to me what the patch really changes? AFAICS this is a > > no-op. The same logic with a different syntax. Lazy evaluation of || means that if KSycoca::isAvailable() returns false, KServiceType::serviceType("FakePluginType") i