Re: Move thumbnail kioslave and thumbcreator service type to kio?

2015-01-20 Thread David Faure
On Tuesday 20 January 2015 01:39:43 David Narvaez wrote: On Sun, Jan 18, 2015 at 2:38 PM, David Narvaez david.narv...@computer.org wrote: Coincidentially, I am transplanting a protocol into KIO right now, so I can do this move also. So this transplant required some heavier porting to

Re: KF 5.6 changelog

2015-01-20 Thread Marco Martin
On Thursday 08 January 2015, Daniel Vrátil wrote: On Saturday, January 03, 2015 02:16:30 PM David Faure wrote: With cookies to Kai Uwe Broulik for using CHANGELOG: in most of his commits! The KPackage frameworks is Tier 2 and depends on KDocTools, which is also Tier 2, which, if I read

Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-20 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122168/ --- Review request for KDE Frameworks. Repository: kcmutils Description

Re: Review Request 119337: Wait for KMainWindow size restoring before auto saving the size

2015-01-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119337/ --- (Updated Jan. 20, 2015, 4:46 p.m.) Status -- This change has been

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122168/#review74403 --- src/kcmoduleproxy.cpp

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-20 Thread Hugo Pereira Da Costa
On Jan. 20, 2015, 4:16 p.m., David Faure wrote: src/kcmoduleproxy.cpp, line 99 https://git.reviewboard.kde.org/r/122168/diff/1/?file=343470#file343470line99 ... while this line is happy with dots. ok. Got it now. Thanks ! - Hugo

Re: Review Request 121864: Get rid of KDBusMenuExporter and use DBusMenuExporter directly

2015-01-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121864/ --- (Updated Jan. 20, 2015, 3:24 p.m.) Status -- This change has been

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-20 Thread Hugo Pereira Da Costa
On Jan. 20, 2015, 3:52 p.m., David Faure wrote: for the path yes, but there is no reason to remove that from the service name mmm. Maybe I am confused with the comment. Still, I just checked that passing X-KDE-Library=kstyle_breeze_config.so in the kcmodule .desktop also crashes dbus

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122168/#review74399 --- for the path yes, but there is no reason to remove that from

Re: Review Request 122168: Also replace '.' by '_' when registering dbus path names from X_KDE_Library

2015-01-20 Thread Hugo Pereira Da Costa
On Jan. 20, 2015, 3:52 p.m., David Faure wrote: for the path yes, but there is no reason to remove that from the service name Hugo Pereira Da Costa wrote: mmm. Maybe I am confused with the comment. Still, I just checked that passing X-KDE-Library=kstyle_breeze_config.so

Review Request 122177: some minor fixes for windows

2015-01-20 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122177/ --- Review request for KDE Frameworks and kdewin. Repository: kglobalaccel

Re: Review Request 122177: some minor fixes for windows

2015-01-20 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122177/#review74449 --- src/runtime/main.cpp

Re: Review Request 122177: some minor fixes for windows

2015-01-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122177/#review74446 --- src/runtime/main.cpp