Re: Review Request 122438: Notiy config leak fix try 2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122438/ --- (Updated Feb. 5, 2015, 9:34 p.m.) Status -- This change has been mar

strange problem with KConfig

Hi all, I was investigating this bug.. https://bugs.kde.org/show_bug.cgi?id=343583 but after digging and digging, it looks like more and more an issue in KConfig.. basically if there is a config file in a system-wide location (to give default configs that would then be overridden by whatever oth

Re: KDE Frameworks Sprint

El Dimecres, 4 de febrer de 2015, a les 01:33:00, Aleix Pol va escriure: > Hello, > Do we want a KDE Frameworks sprint? I think it's a great idea. > > I think it could be interesting, at least to recapitulate about the > first year of KF5, find what we liked and decide how to keep going. > > Wh

Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122445/ --- Review request for KDE Frameworks, Cornelius Schumacher, Nicolás Alvarez, a

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

> On Jan. 27, 2015, 3:55 p.m., Matthew Dawson wrote: > > Unforunately, this cause test system failures in the the > > kconfigskeletontest test suite. I'm not sure why this should create issues > > there. > > > > However, I have a partial solution that avoids creating a full > > KSharedConfig

Re: Review Request 122438: Notiy config leak fix try 2

> On Feb. 5, 2015, 10:31 a.m., Mark Gaiser wrote: > > src/knotificationplugin.h, line 60 > > > > > > Why wait? > > > > You can do that now and deprecate this function, right? You just can't > > remove it

Change in kio[master]: cleanup: simplify fooPtr != NULL and related

Jan Kundrát has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/362 Change subject: cleanup: simplify fooPtr != NULL and related .. cleanup: simplify fooPtr != NULL and related Also use nullptr on adjace

Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin

> On Feb. 3, 2015, 11:10 p.m., Ivan Čukić wrote: > > This does fix the switching, but I don't agree it is the right place for it > > (I don't like that this plugin exists at all tbh). > > > > When switching the activities, there needs to be a (UI) feedback - the > > switcher needs to show up.

Re: KDE Frameworks Sprint

On Wednesday 04 February 2015 01:33:00 Aleix Pol wrote: > > Do we want a KDE Frameworks sprint? > > I think it could be interesting, at least to recapitulate about the > first year of KF5, find what we liked and decide how to keep going. > > Who would be interested? I would be interested, especi

Re: Review Request 122438: Notiy config leak fix try 2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122438/#review75461 --- src/knotificationplugin.h

Re: Review Request 122438: Notiy config leak fix try 2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122438/#review75460 --- Ship it! Thank you! - Martin Klapetek On Feb. 5, 2015, 10:

Re: Review Request 122430: add optional properties rangeMax and rangeMin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122430/ --- (Updated Feb. 5, 2015, 9:50 a.m.) Status -- This change has been mar

Review Request 122438: Notiy config leak fix try 2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122438/ --- Review request for KDE Frameworks and Martin Klapetek. Repository: knotif