On Feb. 9, 2015, 12:59 a.m., Mark Gaiser wrote:
-1
You use C-Style casts. Oke, the frameworks coding style doesn't seem to
explicitly forbid it (casts are not mentioned), but if i recall correctly
we use the Qt style + some of our own which means we should obey the Qt
style [1]
On Monday 09 February 2015, Matthew Dawson wrote:
However, I think the bug can be worked around in the short term for the kcm
by having the KSharedConfigs in question use only the file they are
pointed at. I think that is actually the correct behaviour, as those files
are not supposed to use
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122493/
---
(Updated Feb. 9, 2015, 8:31 a.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122495/#review75704
---
Ship it!
Ship It!
- Friedrich W. H. Kossebau
On Feb. 9,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122481/
---
(Updated Feb. 9, 2015, 3:17 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122487/
---
(Updated Feb. 9, 2015, 5:04 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122495/
---
(Updated Feb. 9, 2015, 4:11 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120185/
---
(Updated Feb. 9, 2015, 5:41 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121447/#review75726
---
+1
- Mark Gaiser
On feb 9, 2015, 5:51 p.m., Àlex Fiestas
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122493/
---
(Updated Feb. 9, 2015, 7:26 p.m.)
Status
--
This change has been
Eike,
On Mon, Feb 9, 2015 at 1:03 PM, Eike Hein h...@kde.org wrote:
Hi,
we currently have numerous dynamic search fields across KDE
apps that, for performance reasons, disregard input shorter
than a particular QString::length(). Examples are KMail and
some things in KRunner. It's a common
On Feb. 9, 2015, 12:59 a.m., Mark Gaiser wrote:
-1
You use C-Style casts. Oke, the frameworks coding style doesn't seem to
explicitly forbid it (casts are not mentioned), but if i recall correctly
we use the Qt style + some of our own which means we should obey the Qt
style [1]
On Feb. 9, 2015, 12:59 a.m., Mark Gaiser wrote:
-1
You use C-Style casts. Oke, the frameworks coding style doesn't seem to
explicitly forbid it (casts are not mentioned), but if i recall correctly
we use the Qt style + some of our own which means we should obey the Qt
style [1]
On Feb. 8, 2015, 8:45 p.m., David Faure wrote:
Which magic tool did you come up with this time, to detect such things? :-)
Aleix Pol Gonzalez wrote:
+1 :D I too want to know!
It's still very much WIP, the code is in kde:scratch/vkrause/elf-dissector but
be aware that it still
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122459/
---
(Updated Feb. 9, 2015, 5:22 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122493/#review75723
---
Ship it!
Ship It!
- Marco Martin
On Feb. 9, 2015, 3:31
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122493/#review75724
---
Yes, this lets it build on OSX/CI.
Thanks, Jeremy!
- Marko
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122493/#review75725
---
Ship it!
Ship It!
- Marko Käning
On Feb. 9, 2015, 4:31
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121447/
---
(Updated feb. 9, 2015, 5:51 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122478/
---
(Updated Feb. 9, 2015, 5:29 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121447/
---
(Updated feb. 9, 2015, 5:45 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122493/#review75719
---
Ship it!
Seems ok to me
- Ivan Čukić
On Feb. 9, 2015,
See http://build.kde.org/job/kservice_master_qt5/235/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120185/#review75682
---
Ship it!
libexec/kf5 sounds sensible to me. I'd say, barring
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122498/
---
Review request for Kate and KDE Frameworks.
Repository: kate
On feb. 9, 2015, 7:24 p.m., David Faure wrote:
This should not be done if the slave has provided a UDS_MIME_TYPE. E.g.
kio_smb sends mimetypes that derive from inode/directory, such as
application/x-smb-server and application/x-smb-workgroup. If you think this
works with the current
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122499/
---
Review request for KDE Frameworks and David Faure.
Bugs: 213972
Hi,
we currently have numerous dynamic search fields across KDE
apps that, for performance reasons, disregard input shorter
than a particular QString::length(). Examples are KMail and
some things in KRunner. It's a common pattern.
This is very English-centric behavior; many scripts are
more
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121084/
---
(Updated Feb. 9, 2015, 10:48 p.m.)
Status
--
This change has been
On feb. 9, 2015, 7:24 p.m., David Faure wrote:
This should not be done if the slave has provided a UDS_MIME_TYPE. E.g.
kio_smb sends mimetypes that derive from inode/directory, such as
application/x-smb-server and application/x-smb-workgroup. If you think this
works with the current
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121447/#review75730
---
This should not be done if the slave has provided a
31 matches
Mail list logo