Review Request 122614: Fix a porting bug in the http ioslave

2015-02-18 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122614/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 122616: Use KIO::FileSystemFreeSpaceJob in KPropertiesDialog

2015-02-18 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122616/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 122614: Fix a porting bug in the http ioslave

2015-02-18 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122614/ --- (Updated Feb. 18, 2015, 9:11 a.m.) Review request for KDE Frameworks.

Re: Review Request 122608: Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback

2015-02-18 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122608/ --- (Updated Feb. 18, 2015, 9:38 a.m.) Status -- This change has been

Review Request 122620: Implement quota-used-bytes and quota-available-bytes in http ioslave

2015-02-18 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122620/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 122619: [KPluginMetaData] Add support for Hidden key

2015-02-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122619/ --- Review request for KDE Frameworks, Plasma, Alex Richardson, David Faure,

Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

2015-02-18 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122621/ --- Review request for KDE Frameworks and Andreas Schneider. Repository:

Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)

2015-02-18 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/#review76245 --- autotests/kurlcomboboxtest.cpp

Re: Review Request 122549: Avoid code path that leaves local config files locked

2015-02-18 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/#review76254 --- Ship it! Makes sense to me, not the maintainer but seems

Re: Review Request 122616: Use KIO::FileSystemFreeSpaceJob in KPropertiesDialog

2015-02-18 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122616/#review76244 --- src/widgets/kpropertiesdialog.cpp

Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)

2015-02-18 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- (Updated feb. 18, 2015, 8:46 p.m.) Review request for KDE Frameworks.

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

2015-02-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183/#review76264 --- Ship it! src/currency.cpp