Re: Review Request 122206: [kio] Make tests optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122206/#review77603 --- I know this is merged already but this patch is being applied

Re: Review Request 122484: KCodecs: Fix i18n of character set names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122484/ --- (Updated maalis 17, 2015, 12:19 ap) Review request for KDE Frameworks.

Re: Review Request 122484: KCodecs: Fix i18n of character set names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122484/ --- (Updated maalis 17, 2015, 12:15 ap) Review request for KDE Frameworks.

Re: What's the point of tiers if we bend the definition of them?

+1 On Mon, Mar 16, 2015 at 4:16 PM, Albert Astals Cid wrote: > We have KPackage depending on kdoctools but since it's optional we pretend > it's not a real dependency and call KPackage tier2 > > What's in it for us other than lying to ourselves? What's so bad about > KPackage being tier 3? > > I

What's the point of tiers if we bend the definition of them?

We have KPackage depending on kdoctools but since it's optional we pretend it's not a real dependency and call KPackage tier2 What's in it for us other than lying to ourselves? What's so bad about KPackage being tier 3? It'd still have only 3 dependencies and be totally usable, no? Cheers, A

Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/ --- Review request for KDE Frameworks, Martin Gräßlin and Thomas Lübking. Rep

Re: Review Request 122978: Add unit test for crash of bug 343976

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122978/#review77586 --- Ship it! Ship It! - Marco Martin On March 16, 2015, 12:04

Review Request 122979: Add a unit test which performs testing a shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122979/ --- Review request for KDE Frameworks and Thomas Lübking. Repository: kglobal

Re: New framework: ModemManagerQt

On Thursday 12 of March 2015 14:12 David Edmundson wrote: > Looks good to me. > 2 minor comments. > > All classes are namespaced, but generictypes.h is not. > Given these names could easily clash with something else and are publicly > included, it might be worth putting them in the same namespace.

Re: Review Request 122978: Add unit test for crash of bug 343976

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122978/#review77578 --- +1 from me - Lukáš Tinkl On Bře. 16, 2015, 1:04 odp., Marti

Re: Review Request 122978: Add unit test for crash of bug 343976

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122978/#review77577 --- src/platformtheme/kdeplatformsystemtrayicon.cpp

Re: Review Request 122978: Add unit test for crash of bug 343976

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122978/#review77574 --- Ship it! +2 from me -- it fixes a crash for me. +I don't kno

Re: Review Request 122876: Delay notifications a bit on Plasma startup

> On March 12, 2015, 8:48 a.m., Martin Gräßlin wrote: > > timer looks wrong to me, too. Not because it's ugly, but because Plasma > > notifications will not go above the splash screen. The fallback might be > > ugly, but as I have seen: it goes above the splash screen. > > > > Thus I suggest t

Re: Review Request 122978: Add unit test for crash of bug 343976

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122978/ --- (Updated March 16, 2015, 1:04 p.m.) Review request for KDE Frameworks.

Re: Review Request 122978: Add unit test for crash of bug 343976

> On March 16, 2015, 12:26 p.m., Jan Kundrát wrote: > > This doesn't fix the problem triggered by Trojita: > > > > ``` > > Program received signal SIGSEGV, Segmentation fault. > > QWidget::removeAction (this=0x0, action=0x55bf88a0) at > > /var/tmp/portage/dev-qt/qtwidgets-5.5./work/qtwi

Re: Review Request 122908: Fix segfaults due to missing screens

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122908/ --- (Updated March 16, 2015, 11:28 a.m.) Status -- This change has been

Re: Review Request 122978: Add unit test for crash of bug 343976

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122978/#review77566 --- This doesn't fix the problem triggered by Trojita: ``` Progra

Review Request 122978: Add unit test for crash of bug 343976

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122978/ --- Review request for KDE Frameworks. Bugs: 343976 https://bugs.kde.org/

Re: Review Request 122770: Support KWindowSystem::icon with NETWinInfo on all platforms

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122770/ --- (Updated March 16, 2015, 9:42 a.m.) Status -- This change has been m

Re: Review Request 122800: Add a Wayland implementation for KWindowSystemPrivate

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122800/ --- (Updated March 16, 2015, 9:42 a.m.) Status -- This change has been m