Re: Review Request 122313: Expose to world whether KPty has been built with utempter library

2015-03-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122313/#review77724 --- Ship it! - David Faure On Jan. 29, 2015, 6:54 p.m., Hrvoje

Re: Review Request 120393: [kdelibs4support] Kill dead code

2015-03-19 Thread Hrvoje Senjan
On March 19, 2015, 12:23 a.m., Vishesh Handa wrote: I'm all for getting rid of the Nepomuk code. However, I'm not too sure about the strigi part. That should still work. It does not ;-) Originally, this review added back the find_package(Strigi) call which was removed a while back (at

Re: Review Request 122313: Expose to world whether KPty has been built with utempter library

2015-03-19 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122313/ --- (Updated March 19, 2015, 11:18 a.m.) Status -- This change has been

Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-19 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123075/#review3 --- Ship it! Ship It! - Jeremy Whiting On March 19, 2015,

Review Request 123075: do not require X11 on Mac OS X

2015-03-19 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123075/ --- Review request for KDE Frameworks and Michael Palimaka. Repository:

cmake CMP0028 missing targets - what does one do about it?

2015-03-19 Thread Harald Sitter
alohas While investigating a wall of build failures in the kubuntu ci this morning I stumbled upon a very interesting problem. Problem tldr: target A links library B, A doesn't get the includes of link libraries of B by default. e.g. A links B, B links karchive, A doesn't have access to the

Re: cmake CMP0028 missing targets - what does one do about it?

2015-03-19 Thread Aleix Pol
On Thu, Mar 19, 2015 at 2:16 PM, Harald Sitter sit...@kde.org wrote: alohas While investigating a wall of build failures in the kubuntu ci this morning I stumbled upon a very interesting problem. Problem tldr: target A links library B, A doesn't get the includes of link libraries of B by

Change in kio[master]: Consolidate find_package calls

2015-03-19 Thread Hrvoje Senjan (Code Review)
Hello Aleix Pol Gonzalez, David Faure, I'd like you to do a code review. Please visit https://gerrit.vesnicky.cesnet.cz/r/432 to review the following change. Change subject: Consolidate find_package calls .. Consolidate