Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123075/#review9 --- as in other similar requests: -2 from my side - Martin

Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-20 Thread Martin Gräßlin
On March 20, 2015, 8:07 a.m., Martin Gräßlin wrote: as in other similar requests: -2 from my side To extend: I think the way is wrong. If it now builds on MacOS the required is wrong. It should be an optional find_package properly ifdefed. - Martin

Re: Review Request 122979: Add a unit test which performs testing a shortcut

2015-03-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122979/ --- (Updated March 20, 2015, 9:40 a.m.) Status -- This change has been

Re: Review Request 122616: Use KIO::FileSystemFreeSpaceJob in KPropertiesDialog

2015-03-20 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122616/ --- (Updated March 20, 2015, 11:18 a.m.) Status -- This change has been

Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-20 Thread Martin Gräßlin
On March 20, 2015, 8:07 a.m., Martin Gräßlin wrote: as in other similar requests: -2 from my side Martin Gräßlin wrote: To extend: I think the way is wrong. If it now builds on MacOS the required is wrong. It should be an optional find_package properly ifdefed. Christoph Cullmann

Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-20 Thread Martin Gräßlin
On March 20, 2015, 8:07 a.m., Martin Gräßlin wrote: as in other similar requests: -2 from my side Martin Gräßlin wrote: To extend: I think the way is wrong. If it now builds on MacOS the required is wrong. It should be an optional find_package properly ifdefed. Christoph Cullmann

Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-20 Thread Martin Gräßlin
On March 20, 2015, 8:07 a.m., Martin Gräßlin wrote: as in other similar requests: -2 from my side Martin Gräßlin wrote: To extend: I think the way is wrong. If it now builds on MacOS the required is wrong. It should be an optional find_package properly ifdefed. Christoph Cullmann

Re: Review Request 123081: sftp ioslave: Check for stat...@openssh.com extension in sftpProtocol::fileSystemFreeSpace

2015-03-20 Thread Andreas Schneider
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123081/#review77829 --- Ship it! Ship It! - Andreas Schneider On March 20, 2015,

Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-20 Thread Christoph Cullmann
On March 20, 2015, 7:07 a.m., Martin Gräßlin wrote: as in other similar requests: -2 from my side Martin Gräßlin wrote: To extend: I think the way is wrong. If it now builds on MacOS the required is wrong. It should be an optional find_package properly ifdefed. Christoph Cullmann

Review Request 123082: Add missing license

2015-03-20 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123082/ --- Review request for KDE Frameworks. Repository: kauth Description

Re: Review Request 123082: Add missing license

2015-03-20 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123082/ --- (Updated March 20, 2015, 1:02 p.m.) Review request for KDE Frameworks.

Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-20 Thread Christoph Cullmann
On March 20, 2015, 7:07 a.m., Martin Gräßlin wrote: as in other similar requests: -2 from my side Martin Gräßlin wrote: To extend: I think the way is wrong. If it now builds on MacOS the required is wrong. It should be an optional find_package properly ifdefed. Actually, you don't

Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-20 Thread Christoph Cullmann
On March 20, 2015, 7:07 a.m., Martin Gräßlin wrote: as in other similar requests: -2 from my side Martin Gräßlin wrote: To extend: I think the way is wrong. If it now builds on MacOS the required is wrong. It should be an optional find_package properly ifdefed. Christoph Cullmann

Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-20 Thread Martin Gräßlin
On March 20, 2015, 8:07 a.m., Martin Gräßlin wrote: as in other similar requests: -2 from my side Martin Gräßlin wrote: To extend: I think the way is wrong. If it now builds on MacOS the required is wrong. It should be an optional find_package properly ifdefed. Christoph Cullmann

Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-20 Thread Christoph Cullmann
On March 20, 2015, 7:07 a.m., Martin Gräßlin wrote: as in other similar requests: -2 from my side Martin Gräßlin wrote: To extend: I think the way is wrong. If it now builds on MacOS the required is wrong. It should be an optional find_package properly ifdefed. Christoph Cullmann

Re: Review Request 123081: sftp ioslave: Check for stat...@openssh.com extension in sftpProtocol::fileSystemFreeSpace

2015-03-20 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123081/ --- (Updated March 20, 2015, 2:50 p.m.) Status -- This change has been

Re: Review Request 123082: Add missing license

2015-03-20 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123082/#review77839 --- Ship it! Ship It! - Christophe Giboudeaux On March 20,

Re: Review Request 123082: Add missing license

2015-03-20 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123082/ --- (Updated March 20, 2015, 3:44 p.m.) Status -- This change has been

Review Request 123081: sftp ioslave: Check for stat...@openssh.com extension in sftpProtocol::fileSystemFreeSpace

2015-03-20 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123081/ --- Review request for KDE Frameworks and Andreas Schneider. Repository: