Re: Review Request 123216: Save some memory in kglobalaccel runtime

2015-04-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123216/#review78389 --- hmm just wondering: why does it need to be a QApplication?

Re: Review Request 123223: [Preliminary] Fix bug 344614: kservice splits filename wrong

2015-04-02 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123223/#review78424 --- Good catch, maybe we can use QFileInfo::completeBaseName()

Re: cmake CMP0028 missing targets - what does one do about it?

2015-04-02 Thread Harald Sitter
On Wed, Apr 1, 2015 at 10:41 PM, Alex Merry alex.me...@kde.org wrote: On Wednesday 01 April 2015 21:39:45 Alex Merry wrote: This appears to be a regression with the 3.0 branch of CMake. 2.8.12 doesn't have an issue, and neither does 3.1.3. For reference:

Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-04-02 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123095/ --- (Updated April 2, 2015, 12:41 p.m.) Status -- This change has been

Re: Syncing ECM release number with KF5

2015-04-02 Thread Stephen Kelly
I have no particular objection, So, what needs to be done to get this synced up? Bump the version in the CMakeLists.txt and update some release-tarball-creating script? David I guess the latter is for you? Thanks, Steve. On Fri, Mar 27, 2015 at 7:49 PM, Michael Palimaka kensing...@gentoo.org

Re: Review Request 123223: [Preliminary] Fix bug 344614: kservice splits filename wrong

2015-04-02 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123223/ --- (Updated April 2, 2015, 11:55 a.m.) Review request for KDE Frameworks.

Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-04-02 Thread Gregor Mi
On March 30, 2015, 9:33 p.m., Gilles Caulier wrote: yes. libkipi is fully ported to KF5. Kipi-plugins is partially ported (only 6 tools). It's enough to test. https://techbase.kde.org/Projects/Digikam/CodingSprint2014 I explicitly did `./kdesrc-build libkipi libkexiv2 libkdcraw

Review Request 123223: [Preliminary] Fix bug 344614: kservice splits filename wrong

2015-04-02 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123223/ --- Review request for KDE Frameworks. Repository: kservice Description

Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-04-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

2015-04-02 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/ --- (Updated April 2, 2015, 2:56 p.m.) Review request for KDE Frameworks,

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

2015-04-02 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review78410 --- I finally managed to make most the master unit tests pass:

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

2015-04-02 Thread Gregor Mi
On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote: src/kglobalaccel.h, line 260 https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260 typo in following Gregor Mi wrote: About why it is needed: see

Re: Review Request 122910: Introduce KMoreTools

2015-04-02 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated April 2, 2015, 4:48 p.m.) Review request for KDE Frameworks and