Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

> On avr. 12, 2015, 8:03 matin, Laurent Montel wrote: > > Perhaps it's time to create an unittest :) > > We need to be sure that it will save when we change settings no ? > > Kåre Särs wrote: > Any hints on how to test that QSettings::setValue() is called properly > (or save()) without writ

Re: Review Request 123348: NetworkManagerQt: fix the building of the examples, and the installed headers.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123348/#review78876 --- Ship it! Ship It! - Lamarque Souza On April 12, 2015, 7:51

Re: Review Request 123349: NetworkManagerQt: comment out unneeded lines from example/CMakeLists.txt

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123349/#review78875 --- examples/CMakeLists.txt (line 5)

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

> On April 12, 2015, 10:43 a.m., Jeremy Whiting wrote: > > Looks good to me. The explanation makes sense also. I did see most dialogs > > working after Lukas' fix, but the one launched from chromium via kdialog > > still hung after that. This should fix that (I'll test it later today) Yep, chr

Review Request 123349: NetworkManagerQt: comment out unneeded lines from example/CMakeLists.txt

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123349/ --- Review request for KDE Frameworks and Jan Grulich. Repository: networkman

Review Request 123348: NetworkManagerQt: fix the building of the examples, and the installed headers.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123348/ --- Review request for KDE Frameworks and Jan Grulich. Repository: networkman

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

> On April 12, 2015, 8:03 a.m., Laurent Montel wrote: > > Perhaps it's time to create an unittest :) > > We need to be sure that it will save when we change settings no ? Any hints on how to test that QSettings::setValue() is called properly (or save()) without writing/modifying the Sonnet sett

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/ --- (Updated April 12, 2015, 5:57 p.m.) Review request for KDE Frameworks and

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/#review78864 --- Looks good to me. The explanation makes sense also. I did see

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated April 12, 2015, 11:54 a.m.) Review request for KDE Frameworks an

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/ --- (Updated April 12, 2015, 11:17 a.m.) Review request for KDE Frameworks an

Re: OSX/CI: kdepimlibs fails to build on branch master

Here is now the detailed information available from the new CI system: https://build-sandbox.kde.org/job/kdepimlibs%20master%20kf5-qt5/9/PLATFORM=OSX,compiler=clang/console Smells like a real Qt bug, indeed. signature.asc Description: Message signed with OpenPGP using GPGMail _

New KDE/CI: qca fails to build on branch qt5 for branch group kf5-qt5 on platform OSX

https://build-sandbox.kde.org/job/qca%20qt5%20kf5-qt5/PLATFORM=OSX,compiler=clang/7/console ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120649: Encode the URIs which end up in DTD files

> On Oct. 24, 2014, 12:05 a.m., Marko Käning wrote: > > I will have to test this in a specially configured OSX/CI VM. Will report > > back on it. Herewith I can report, that on Scarlett's new CI system we were able to verify that the file ```/opt/kde/install/darwin/mavericks/clang/kf5-qt5/fra

Re: OSX/CI: kdepimlibs fails to build on branch master

Hi Daniel, On 12 Apr 2015, at 11:18 , Daniel Vrátil wrote: > Ok, let's play it safe and keep the file then ;) thanks. :) >> Go for it, please! :-) > > Done OK, now I get further, but get stopped cold by some Qt’ish error: --- /opt/kde/install/darwin/mavericks/clang/kf5-qt5/qt5/inst/include/

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/ --- (Updated April 12, 2015, 9:20 a.m.) Review request for KDE Frameworks, Da

Re: OSX/CI: kdepimlibs fails to build on branch master

On Sunday, April 12, 2015 09:57:54 AM Marko Käning wrote: > Hi Daniel, > > On 12 Apr 2015, at 09:50 , Daniel Vrátil wrote: > > it's referring to a file in kdepim-runtime.git/resources (where Knut > > originally was before it was moved to kdepimlibs auto tests). > > I see. > > > I don't understa

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/#review78846 --- Perhaps it's time to create an unittest :) We need to be sure

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/#review78845 --- src/core/settings.cpp (line 77)

Re: OSX/CI: kdepimlibs fails to build on branch master

Hi Daniel, On 12 Apr 2015, at 09:50 , Daniel Vrátil wrote: > it's referring to a file in kdepim-runtime.git/resources (where Knut > originally was before it was moved to kdepimlibs auto tests). I see. > I don't understand Mac much, but is the file actually needed for the Knut > resource? We

Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Re: OSX/CI: kdepimlibs fails to build on branch master

On Saturday, April 11, 2015 10:32:10 PM Marko Käning wrote: > Hi folks, > > after a long time I am finally able to build kmime [1] and thus also kimap > and kmbox needed for kdepimlibs! > :-D > > Now I can tackle kdepimlibs again, but the build fails because of a missing > template file: --- > --