Re: Review Request 123329: Don't crash if notification has no widget and notification is set to notify by taskbar

2015-04-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123329/ --- (Updated April 13, 2015, 9:10 a.m.) Review request for KDE Frameworks.

Re: Review Request 123349: NetworkManagerQt: comment out unneeded lines from example/CMakeLists.txt

2015-04-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123349/#review78882 --- examples/CMakeLists.txt (line 5)

Re: Review Request 123349: NetworkManagerQt: comment out unneeded lines from example/CMakeLists.txt

2015-04-13 Thread Lamarque Souza
On April 13, 2015, 7:13 a.m., David Faure wrote: examples/CMakeLists.txt, line 5 https://git.reviewboard.kde.org/r/123349/diff/1/?file=361005#file361005line5 well i thought maybe someone wants to see how to use this in their app... but ok IIRC it also shows that on api.kde.org

Re: Review Request 123298: Add option to show metadata of an .so file to desktoptojson

2015-04-13 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123298/ --- (Updated April 13, 2015, 10:38 a.m.) Status -- This change has been

Re: Review Request 123298: Add option to show metadata of an .so file to desktoptojson

2015-04-13 Thread Sebastian Kügler
On April 10, 2015, 8:38 a.m., David Faure wrote: -1, qtplugininfo (added by Volker Krause to qttools for Qt 5.5) does the same. No point in duplicating that. Coolio, I'll drop this one then. - Sebastian --- This is an

Re: Review Request 123349: NetworkManagerQt: comment out unneeded lines from example/CMakeLists.txt

2015-04-13 Thread Jan Grulich
On Dub. 13, 2015, 7:13 dop., David Faure wrote: examples/CMakeLists.txt, line 5 https://git.reviewboard.kde.org/r/123349/diff/1/?file=361005#file361005line5 well i thought maybe someone wants to see how to use this in their app... but ok IIRC it also shows that on api.kde.org +1

Re: Review Request 123349: NetworkManagerQt: comment out unneeded lines from example/CMakeLists.txt

2015-04-13 Thread Jan Grulich
On Dub. 13, 2015, 7:13 dop., David Faure wrote: examples/CMakeLists.txt, line 5 https://git.reviewboard.kde.org/r/123349/diff/1/?file=361005#file361005line5 well i thought maybe someone wants to see how to use this in their app... but ok IIRC it also shows that on api.kde.org

Re: Review Request 123329: Don't crash if notification has no widget and notification is set to notify by taskbar

2015-04-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123329/#review78883 --- Ship it! src/notifybytaskbar.cpp (line 45)

Re: Review Request 123329: Don't crash if notification has no widget and notification is set to notify by taskbar

2015-04-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123329/ --- (Updated April 13, 2015, 11:01 a.m.) Status -- This change has been

Re: Review Request 123349: NetworkManagerQt: comment out unneeded lines from example/CMakeLists.txt

2015-04-13 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123349/#review78887 --- Ship it! Ship It! - Jan Grulich On Dub. 12, 2015, 7:57