Review Request 123654: Improve performance of KFileItem and KDirSortFilterProxyModel

2015-05-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123654/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 123632: Fix the i18n after Jerome's patch

2015-05-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123632/#review79927 --- Ship it! Ship It! - Albert Astals Cid On mai. 5, 2015, 9:1

Re: Review Request 123595: Fix KUser test for Mac.

2015-05-05 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123595/#review79919 --- Looks like the test is still failing: https://build.kde.org/

Re: Versioning of Frameworks

2015-05-05 Thread Christoph Cullmann
> > Ok, they are not that obvious too me. Wouldn't it be possible to add > > something like maintainerManagesVersionOnItsOn=false to a file in all the > > frameworks (isn't there already a file in each frameworks for stuff like > > platforms, etc.?) and modify the release-scripts (David or anybody

Re: CI for kf5-qt5 is not green anymore

2015-05-05 Thread Marko Käning
Hi Scarlett, I’ve logged onto my VM as user jenkins, i.e. a GUI session is now available. So you could run a test-build for a project which failed before on you. Let me know how it goes. Greets, Marko signature.asc Description: Message signed with OpenPGP using GPGMail

Re: Re: Versioning of Frameworks

2015-05-05 Thread Martin Gräßlin
On Tuesday 05 May 2015 17:30:05 Mario Fux wrote: > Am Dienstag, 05. Mai 2015, 13.46:16 schrieb Martin Gräßlin: > > Morning > > [snip] > > > > If master is always releasable, you should indeed only merge into master > > > with a change of a version number. > > > If you don't want to maintain diff

Re: Versioning of Frameworks

2015-05-05 Thread Mario Fux
Am Dienstag, 05. Mai 2015, 13.46:16 schrieb Martin Gräßlin: Morning [snip] > > If master is always releasable, you should indeed only merge into master > > with a change of a version number. > > If you don't want to maintain different versions for whatever reason > > (and I think that's an entir

Re: Review Request 123630: Remove unused dependency.

2015-05-05 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123630/ --- (Updated May 5, 2015, 2:16 p.m.) Status -- This change has been mark

Re: Review Request 123631: Only add a '/' if the url does not end with one

2015-05-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123631/ --- (Updated May 5, 2015, 12:44 p.m.) Status -- This change has been mar

Re: Review Request 123111: Only add a '/' if the url does not end with one

2015-05-05 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123111/ --- (Updated May 5, 2015, 12:44 p.m.) Status -- This change has been mar

Re: Re: Versioning of Frameworks

2015-05-05 Thread Martin Gräßlin
On Tuesday 05 May 2015 13:40:24 Christian Mollekopf wrote: > On Tue, May 5, 2015, at 01:31 PM, Martin Gräßlin wrote: > > On Tuesday 05 May 2015 13:20:25 Christian Mollekopf wrote: > > > On Tue, May 5, 2015, at 12:09 PM, Martin Gräßlin wrote: > > > > On Tuesday 05 May 2015 11:33:03 Christian Molleko

Re: Versioning of Frameworks

2015-05-05 Thread Christian Mollekopf
On Tue, May 5, 2015, at 01:31 PM, Martin Gräßlin wrote: > On Tuesday 05 May 2015 13:20:25 Christian Mollekopf wrote: > > On Tue, May 5, 2015, at 12:09 PM, Martin Gräßlin wrote: > > > On Tuesday 05 May 2015 11:33:03 Christian Mollekopf wrote: > > > > What the regular releases IMO should be doing,

Re: Re: Versioning of Frameworks

2015-05-05 Thread Martin Gräßlin
On Tuesday 05 May 2015 13:20:25 Christian Mollekopf wrote: > On Tue, May 5, 2015, at 12:09 PM, Martin Gräßlin wrote: > > On Tuesday 05 May 2015 11:33:03 Christian Mollekopf wrote: > > > What the regular releases IMO should be doing, is to take the latest > > > version from the "always releasable" m

Re: Re: Versioning of Frameworks

2015-05-05 Thread Martin Gräßlin
On Tuesday 05 May 2015 13:14:08 Christian Mollekopf wrote: > On Tue, May 5, 2015, at 12:11 PM, Martin Gräßlin wrote: > > On Tuesday 05 May 2015 11:45:19 Christian Mollekopf wrote: > > > On Wed, Apr 29, 2015, at 09:45 PM, David Faure wrote: > > > > On Wednesday 29 April 2015 15:00:32 Christian Molle

Re: Versioning of Frameworks

2015-05-05 Thread Christian Mollekopf
On Tue, May 5, 2015, at 12:09 PM, Martin Gräßlin wrote: > On Tuesday 05 May 2015 11:33:03 Christian Mollekopf wrote: > > What the regular releases IMO should be doing, is to take the latest > > version from the "always releasable" master branch, > > and be done with it (and that means not touchin

Re: Versioning of Frameworks

2015-05-05 Thread Christian Mollekopf
On Tue, May 5, 2015, at 12:11 PM, Martin Gräßlin wrote: > On Tuesday 05 May 2015 11:45:19 Christian Mollekopf wrote: > > On Wed, Apr 29, 2015, at 09:45 PM, David Faure wrote: > > > On Wednesday 29 April 2015 15:00:32 Christian Mollekopf wrote: > > > > You don't have to maintain any other combinat

Re: Re: Versioning of Frameworks

2015-05-05 Thread Martin Gräßlin
On Tuesday 05 May 2015 11:45:19 Christian Mollekopf wrote: > On Wed, Apr 29, 2015, at 09:45 PM, David Faure wrote: > > On Wednesday 29 April 2015 15:00:32 Christian Mollekopf wrote: > > > You don't have to maintain any other combinations that what you already > > > do. > > > Just because the cmake

Re: Re: Versioning of Frameworks

2015-05-05 Thread Martin Gräßlin
On Tuesday 05 May 2015 11:33:03 Christian Mollekopf wrote: > What the regular releases IMO should be doing, is to take the latest > version from the "always releasable" master branch, > and be done with it (and that means not touching the library version, > because that's not the responsibility of

Re: Review Request 123542: [runtime] Move platform specific code into plugins

2015-05-05 Thread Martin Gräßlin
> On May 5, 2015, 11:05 a.m., Martin Klapetek wrote: > > Looks good; though let's first ship > > https://git.reviewboard.kde.org/r/122680/ - I think it will be easier to > > rebase your changes on top of this rather than the other way around. I'll > > fix the https://git.reviewboard.kde.org/r/

Re: Versioning of Frameworks

2015-05-05 Thread Christian Mollekopf
On Wed, Apr 29, 2015, at 09:45 PM, David Faure wrote: > On Wednesday 29 April 2015 15:00:32 Christian Mollekopf wrote: > > You don't have to maintain any other combinations that what you already > > do. > > Just because the cmake versions aren't automatically bumped doesn't mean > > you suddenly

Re: Versioning of Frameworks

2015-05-05 Thread Christian Mollekopf
Hey David, Sorry for the late response. On Wed, Apr 29, 2015, at 08:34 PM, David Faure wrote: > On Tuesday 28 April 2015 12:17:00 Christian Mollekopf wrote: > > Our dependency tree is now indeed reduced, but if we want to update a > > single library, we are forced to update all libraries, due to

Re: Review Request 123632: Fix the i18n after Jerome's patch

2015-05-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123632/ --- (Updated May 5, 2015, 11:12 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 123632: Fix the i18n after Jerome's patch

2015-05-05 Thread Martin Klapetek
> On May 4, 2015, 10:36 p.m., Albert Astals Cid wrote: > > Sorry, that's not enough you need to add the loader to the sources, see > > CMakeLists.txt of the daemon. > > > > And maybe you want to share your new acquired knowldge in the wiki? Ah ok, update incoming. - Martin

Re: Review Request 123542: [runtime] Move platform specific code into plugins

2015-05-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123542/#review79889 --- Ship it! Looks good; though let's first ship https://git.revi