Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-05-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123669/#review80001 --- +1 seems sensible. autotests/kpluginloadertest.cpp (line 357

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Sebastian Kügler
> On May 6, 2015, 10:54 p.m., Sebastian Kügler wrote: > > I've read and tested it, everything still works nicely. Good job! > > > > I like how the patch moves much of the query language into simple C++, > > avoids a lot of query parsing and moves some of the error paths to compile > > time. h

Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-05-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123669/ --- Review request for KDE Frameworks, Alex Richardson and David Faure. Repos

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/#review7 --- Ship it! I've read and tested it, everything still works nice

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Sebastian Kügler
> On May 6, 2015, 5:38 p.m., Hrvoje Senjan wrote: > > >I would keep this for safety until Plasma 5.4 is released, then try to > > >remove it again > > > > First, sorry for being the bad cop, i'd just like to avoid any future > > (irreversible) problems, and that distros delivering monthly KF5

IRC and Email notifications

2015-05-06 Thread Scarlett Clark
Please help me help you, I do not have lists containing who needs / wants what and where.. I tried my best to make some educated guesses. I do not take rejection well and so I ask anyone that wishes to have your CI builds in email or IRC please tell me the rpoject and places you want them to go

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Marco Martin
> On May 6, 2015, 5:38 p.m., Hrvoje Senjan wrote: > > >I would keep this for safety until Plasma 5.4 is released, then try to > > >remove it again > > > > First, sorry for being the bad cop, i'd just like to avoid any future > > (irreversible) problems, and that distros delivering monthly KF5

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/#review79977 --- >I would keep this for safety until Plasma 5.4 is released, th

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 5:21 p.m.) Review request for KDE Frameworks and Pl

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 5:20 p.m.) Review request for KDE Frameworks and Pl

Re: Review Request 123595: Fix KUser test for Mac.

2015-05-06 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123595/#review79976 --- I'm not sure, after reading http://pig.made-it.com/uidgid.html

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 6, 2015, 2:35 p.m.) Review request for KDE Frameworks and Pl

Re: Review Request 123632: Fix the i18n after Jerome's patch

2015-05-06 Thread Martin Klapetek
> On May 4, 2015, 10:36 p.m., Albert Astals Cid wrote: > > Sorry, that's not enough you need to add the loader to the sources, see > > CMakeLists.txt of the daemon. > > > > And maybe you want to share your new acquired knowldge in the wiki? > > Martin Klapetek wrote: > Ah ok, update incomi

Re: Review Request 123632: Fix the i18n after Jerome's patch

2015-05-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123632/ --- (Updated May 6, 2015, 1:19 p.m.) Status -- This change has been mark

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

2015-05-06 Thread Jerome Leclanche
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/ --- (Updated May 6, 2015, 1:19 p.m.) Status -- This change has been mark

Re: Versioning of Frameworks

2015-05-06 Thread Jan Kundrát
Hi Christian, I think that the stuff you're looking for (reducing version churn) can also be provided by having stable branches for selected parts of KF5. IMHO this can be quite an elegant solution given the usual cat-herding problem of FLOSS where people just do what they want to do. Those wh

Re: Review Request 123654: Improve performance of KFileItem and KDirSortFilterProxyModel

2015-05-06 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123654/#review79958 --- generally +1 from my side except for the open question for the

Re: Review Request 123595: Fix KUser test for Mac.

2015-05-06 Thread David Faure
> On May 5, 2015, 9:08 p.m., Marko Käning wrote: > > Looks like the test is still failing: > > > > https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/24/PLATFORM=OSX,compiler=clang/testReport/(root)/TestSuite/kusertest/ > > > > Anything I could do? Yes, you could try applying the patch