Re: Review Request 123575: Improve debug information for some plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123575/ --- (Updated May 14, 2015, 12:57 a.m.) Status -- This change has been ma

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123742/ --- (Updated May 14, 2015, 12:47 a.m.) Status -- This change has been ma

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

> On May 13, 2015, 11:09 p.m., Aleix Pol Gonzalez wrote: > > I'm not against the patch, but in general urls without scheme > > Aleix Pol Gonzalez wrote: > Eh sorry, I published before finishing the sentence. > > I'm not against the patch, but in general urls without scheme usually

Re: Review Request 123784: Make sure we're not magically converting from QString to QUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123784/ --- (Updated May 14, 2015, 12:21 a.m.) Status -- This change has been ma

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

> On May 14, 2015, 1:09 a.m., Aleix Pol Gonzalez wrote: > > I'm not against the patch, but in general urls without scheme > > Aleix Pol Gonzalez wrote: > Eh sorry, I published before finishing the sentence. > > I'm not against the patch, but in general urls without scheme usually >

Re: Review Request 123784: Make sure we're not magically converting from QString to QUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123784/#review80324 --- Ship it! Ship It! - Eike Hein On May 14, 2015, 12:02 a.m.,

Review Request 123784: Make sure we're not magically converting from QString to QUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123784/ --- Review request for KDE Frameworks and Plasma. Repository: kio-extras De

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

> On May 13, 2015, 11:09 p.m., Aleix Pol Gonzalez wrote: > > I'm not against the patch, but in general urls without scheme > > Aleix Pol Gonzalez wrote: > Eh sorry, I published before finishing the sentence. > > I'm not against the patch, but in general urls without scheme usually

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

> On May 14, 2015, 1:09 a.m., Aleix Pol Gonzalez wrote: > > I'm not against the patch, but in general urls without scheme Eh sorry, I published before finishing the sentence. I'm not against the patch, but in general urls without scheme usually sound like QUrl API misuse. - Aleix -

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123781/#review80321 --- I'm not against the patch, but in general urls without scheme

Re: Review Request 123439: Coding Style for karchive_p.h kbzip2filter.h kcompressiondevice.h kfilterbase.h kfilterdev.h klimitediodevice_p.h kxzfilter.h kzip.h

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123439/ --- (Updated May 14, 2015, 1:08 a.m.) Review request for Akonadi, KDE Framewo

Re: Review Request 123745: Stop producing warnings about CMP0037 policy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123745/ --- (Updated May 13, 2015, 8:02 p.m.) Status -- This change has been mar

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123781/ --- (Updated May 13, 2015, 7:38 p.m.) Review request for KDE Frameworks, Plas

Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123781/ --- Review request for KDE Frameworks, David Faure and Fredrik Höglund. Repos

Re: Install location of myframework_version.h headers

On Wednesday 13 May 2015 08:37:19 Kevin Funk wrote: > Right, and I just noticed a problem I didn't think of before: There's no > $PREFIX/include/KF5/$myframework/ where I could install > ${myframework}_version.h into for some of the frameworks :) > > KConfig for instance has two libs, but only ins

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 13, 2015, 5:37 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123735: version of QmlObject with a static engine

> On May 12, 2015, 5:45 p.m., Mark Gaiser wrote: > > src/kdeclarative/qmlobjectsharedengine.h, line 57 > > > > > > std::unique_ptr<...> ... > > then you can also forget about the delete in the destructor. buh

Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/ --- (Updated May 13, 2015, 5:26 p.m.) Status -- This change has been mar

Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/#review80313 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 13, 2015, 7:

Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123737/ --- (Updated May 13, 2015, 5:13 p.m.) Review request for KDE Frameworks. Ch

Review Request 123778: Fix crash when DBus call ends with error

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123778/ --- Review request for KDE Frameworks and Ivan Čukić. Repository: kactivities

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

> On May 13, 2015, 7:10 a.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 8 > > > > > > I insist, feature_sumary goes at the bottom. (and is already there) Is > > it needed to have it twice? > > Jeremy Whi

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

> On May 13, 2015, 7:10 a.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 8 > > > > > > I insist, feature_sumary goes at the bottom. (and is already there) Is > > it needed to have it twice? Yes, otherwise

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123742/#review80299 --- CMakeLists.txt (line 8)

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123742/ --- (Updated May 13, 2015, 7 a.m.) Review request for KDE Frameworks and Jere

Re: Review Request 123743: Fix missing category to silence `desktop-file-validate`

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123743/ --- (Updated May 13, 2015, 12:50 p.m.) Status -- This change has been ma

Re: Kross module loading is broken since KF5.0.0

2015-05-12 14:39 GMT+03:00 Vishesh Handa : > > On Mon, May 11, 2015 at 6:37 PM, Alexander Potashev > wrote: >> >> 3. Make module names case insensitive. This can be implemented in >> Kross framework by listing and filtering directory contents instead of >> checking for a specific file. It will be

Re: Review Request 123768: port to new ecm_add_test PROPERTIES argument

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123768/#review80283 --- Ship it! Ship It! - Jan Grulich On Kvě. 13, 2015, 9 dop.,

Review Request 123768: port to new ecm_add_test PROPERTIES argument

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123768/ --- Review request for KDE Frameworks and Network Management. Repository: mod