---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123768/#review80283
---
Ship it!
Ship It!
- Jan Grulich
On Kvě. 13, 2015, 9 dop.,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123768/
---
Review request for KDE Frameworks and Network Management.
Repository:
On May 13, 2015, 7:10 a.m., Aleix Pol Gonzalez wrote:
CMakeLists.txt, line 8
https://git.reviewboard.kde.org/r/123742/diff/3/?file=368712#file368712line8
I insist, feature_sumary goes at the bottom. (and is already there) Is
it needed to have it twice?
Yes, otherwise we only get
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123742/
---
(Updated May 13, 2015, 7 a.m.)
Review request for KDE Frameworks and
On May 13, 2015, 7:10 a.m., Aleix Pol Gonzalez wrote:
CMakeLists.txt, line 8
https://git.reviewboard.kde.org/r/123742/diff/3/?file=368712#file368712line8
I insist, feature_sumary goes at the bottom. (and is already there) Is
it needed to have it twice?
Jeremy Whiting wrote:
2015-05-12 14:39 GMT+03:00 Vishesh Handa m...@vhanda.in:
On Mon, May 11, 2015 at 6:37 PM, Alexander Potashev aspotas...@gmail.com
wrote:
3. Make module names case insensitive. This can be implemented in
Kross framework by listing and filtering directory contents instead of
checking for a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123743/
---
(Updated May 13, 2015, 12:50 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123742/#review80299
---
CMakeLists.txt (line 8)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123781/
---
Review request for KDE Frameworks, David Faure and Fredrik Höglund.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123781/
---
(Updated May 13, 2015, 7:38 p.m.)
Review request for KDE Frameworks,
On Wednesday 13 May 2015 08:37:19 Kevin Funk wrote:
Right, and I just noticed a problem I didn't think of before: There's no
$PREFIX/include/KF5/$myframework/ where I could install
${myframework}_version.h into for some of the frameworks :)
KConfig for instance has two libs, but only
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123439/
---
(Updated May 14, 2015, 1:08 a.m.)
Review request for Akonadi, KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123784/
---
Review request for KDE Frameworks and Plasma.
Repository: kio-extras
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123784/#review80324
---
Ship it!
Ship It!
- Eike Hein
On May 14, 2015, 12:02
On May 13, 2015, 11:09 p.m., Aleix Pol Gonzalez wrote:
I'm not against the patch, but in general urls without scheme
Aleix Pol Gonzalez wrote:
Eh sorry, I published before finishing the sentence.
I'm not against the patch, but in general urls without scheme usually
sound
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123781/#review80321
---
I'm not against the patch, but in general urls without scheme
On May 14, 2015, 1:09 a.m., Aleix Pol Gonzalez wrote:
I'm not against the patch, but in general urls without scheme
Eh sorry, I published before finishing the sentence.
I'm not against the patch, but in general urls without scheme usually sound
like QUrl API misuse.
- Aleix
On May 13, 2015, 11:09 p.m., Aleix Pol Gonzalez wrote:
I'm not against the patch, but in general urls without scheme
Aleix Pol Gonzalez wrote:
Eh sorry, I published before finishing the sentence.
I'm not against the patch, but in general urls without scheme usually
sound
On May 14, 2015, 1:09 a.m., Aleix Pol Gonzalez wrote:
I'm not against the patch, but in general urls without scheme
Aleix Pol Gonzalez wrote:
Eh sorry, I published before finishing the sentence.
I'm not against the patch, but in general urls without scheme usually
sound
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123784/
---
(Updated May 14, 2015, 12:21 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123778/
---
Review request for KDE Frameworks and Ivan Čukić.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123742/
---
(Updated May 14, 2015, 12:47 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123575/
---
(Updated May 14, 2015, 12:57 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123737/#review80313
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On May 13, 2015,
On May 12, 2015, 5:45 p.m., Mark Gaiser wrote:
src/kdeclarative/qmlobjectsharedengine.h, line 57
https://git.reviewboard.kde.org/r/123735/diff/5/?file=368396#file368396line57
std::unique_ptr... ...
then you can also forget about the delete in the destructor.
buh, fine
On
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123737/
---
(Updated May 13, 2015, 5:26 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
---
(Updated May 13, 2015, 5:37 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123737/
---
(Updated May 13, 2015, 5:13 p.m.)
Review request for KDE Frameworks.
On Monday 04 May 2015 14:11:14 Kevin Funk wrote:
On Monday 04 May 2015 13:11:05 David Faure wrote:
On Monday 04 May 2015 12:29:39 David Faure wrote:
On Monday 04 May 2015 12:23:32 Kevin Funk wrote:
The issue could be easily fixed by moving the myframework_version.h
into
On May 13, 2015, 6:45 a.m., Kevin Funk wrote:
I'd reorder the code:
```
...
include(FeatureSummary)
find_package(ECM ...)
set_target_properties(ECM ...)
feature_summary(...)
...
```
I know that it is a bit harder to script this way , but helps code
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123742/#review80275
---
I'd reorder the code:
```
...
include(FeatureSummary)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123745/
---
(Updated May 13, 2015, 8:02 p.m.)
Status
--
This change has been
32 matches
Mail list logo
