Re: Proposal: move KWalletManager inside KWallet framework

2015-06-02 Thread Stefan Bruens
On Friday 29 May 2015 22:31:00 Valentin Rusu wrote: Ok, I should also test this. Do you have a KDE commiter account? Can you push a branch with your patched code, in the KWallet framework, please? I have pushed a kwalletd4_dbus_compat branch Kind regards, Stefan -- Stefan BrĂ¼ns /

Re: Review Request 123930: Reduce temporary allocations.

2015-06-02 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123930/ --- (Updated June 2, 2015, 9:13 p.m.) Status -- This change has been

Re: [kio] autotests: Add unit test for KIO::AccessManager

2015-06-02 Thread Aleix Pol
On Tue, Jun 2, 2015 at 5:17 PM, Aleix Pol aleix...@kde.org wrote: On Mon, Jun 1, 2015 at 1:08 AM, David Faure fa...@kde.org wrote: On Monday 20 April 2015 15:23:26 Aleix Pol wrote: Git commit 1c1501b5d98e30a42b4052d011dbce5a645b7545 by Aleix Pol. Committed on 20/04/2015 at 15:22. Pushed by

Re: Review Request 123939: KAssistantDialog: Re-add the Help button that was present in KDELibs4 version

2015-06-02 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123939/ --- (Updated June 2, 2015, 9:30 p.m.) Status -- This change has been

Re: [kio] autotests: Add unit test for KIO::AccessManager

2015-06-02 Thread Aleix Pol
On Mon, Jun 1, 2015 at 1:08 AM, David Faure fa...@kde.org wrote: On Monday 20 April 2015 15:23:26 Aleix Pol wrote: Git commit 1c1501b5d98e30a42b4052d011dbce5a645b7545 by Aleix Pol. Committed on 20/04/2015 at 15:22. Pushed by apol into branch 'master'. Add unit test for KIO::AccessManager I

Re: Review Request 123924: Optimize KIconEngine::availableSizes()

2015-06-02 Thread Aleix Pol Gonzalez
On May 28, 2015, 5:18 p.m., Milian Wolff wrote: src/kiconengine.cpp, line 116 https://git.reviewboard.kde.org/r/123924/diff/1/?file=378265#file378265line116 in KF6, this should also not use QList, but QVector instead. on 32bit platforms, a QListQSize is pretty damn slow That's

Re: Review Request 123924: Optimize KIconEngine::availableSizes()

2015-06-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123924/ --- (Updated June 2, 2015, 4:04 p.m.) Status -- This change has been