Re: Review Request 124143: Implement PersonsModel filtering facilities

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124143/ --- (Updated June 22, 2015, 7:47 a.m.) Review request for KDE Frameworks, KDE

Re: Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123872/#review81646 --- Ship it! LGTM, thanks for adding the unit tests! I have just

Re: Review Request 124138: Install kconfig_compiler into libexec

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124138/#review81644 --- +1, but again I'd like someone to check off the CMake foo as w

Re: Review Request 124143: Implement PersonsModel filtering facilities

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124143/#review81641 --- +1 autotests/personsproxymodeltest.cpp (line 44)

Re: Review Request 124147: Create Data Dir If it Does Not Exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124147/ --- (Updated June 22, 2015, 12:27 a.m.) Review request for KDE Frameworks.

Re: Review Request 124147: Create Data Dir If it Does Not Exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124147/#review81637 --- src/ioslaves/http/kcookiejar/kcookieserver.cpp (line 55)

Review Request 124147: Create Data Dir If it Does Not Exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124147/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

> On Јун 6, 2015, 10:21 пре п., David Faure wrote: > > A test doesn't really need ki18n, it could just define its own i18n() > > function. > > > > Alternatively, you can put the test in a higher level framework, like > > frameworkintegration. I took the first approach, by adding a fake klocal

Re: Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123872/ --- (Updated Јун 21, 2015, 10:47 по п.) Review request for KDE Frameworks, Al

Re: KCoreaddons build failiure on ARM

On Fri, June 19, 2015 20:40:39 Rohan Garg wrote: > Hi > I'm trying to compile kcoreaddons on ARM with clang and I'm hitting > this build failiure : > > 06:22:27 ../../../src/lib/io/kfilesystemtype.cpp:112:10: error: case > value evaluates to 2240043254, which cannot be narrowed to type > '__fsword

Re: Review Request 124143: Implement PersonsModel filtering facilities

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124143/#review81630 --- I'm not very fond of the customProperty().isNull method, maybe

Review Request 124143: Implement PersonsModel filtering facilities

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124143/ --- Review request for KDE Frameworks, KDEPIM and Martin Klapetek. Repository

Re: Review Request 121446: Ignore child mtp devices

> On des. 11, 2014, 1:17 p.m., Aleix Pol Gonzalez wrote: > > +1 makes sense to me, less of a workaround as it used to be. ping? - Àlex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

> On June 20, 2015, 9:10 p.m., Martin Klapetek wrote: > > +1 for adding all that info > > -1 for putting it into its own tab; previously it was visible right away, > > now an additional click is needed. Maybe it could be stacked all under the > > application name? I mean it's just 2 more lines