Re: Review Request 124288: [kwindowsystem] Install private headers for platform plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124288/ --- (Updated July 9, 2015, 8:03 a.m.) Status -- This change has been mar

Re: Review Request 124289: [kidletime] Install private headers for platform plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124289/ --- (Updated July 9, 2015, 8:06 a.m.) Status -- This change has been mar

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124282/#review82252 --- some style nitpicks from my side, but it looks very good alrea

Review Request 124303: KFileWidget: provide the displayed filter text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124303/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 124303: KFileWidget: provide the displayed filter text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124303/#review82253 --- What's the use case? - Aleix Pol Gonzalez On July 9, 2015,

Re: Review Request 124303: KFileWidget: provide the displayed filter text

> On Lug. 9, 2015, 10:02 a.m., Aleix Pol Gonzalez wrote: > > What's the use case? Basically more user-friendly messages for the users. See RR 120204 and in particular this screenshot: https://git.reviewboard.kde.org/r/120204/file/2145/ - Elvis ---

Re: Review Request 124303: KFileWidget: provide the displayed filter text

> On July 9, 2015, 12:02 p.m., Aleix Pol Gonzalez wrote: > > What's the use case? > > Elvis Angelaccio wrote: > Basically more user-friendly messages for the users. > See RR 120204 and in particular this screenshot: > https://git.reviewboard.kde.org/r/120204/file/2145/ Why don't you us

Re: Review Request 124303: KFileWidget: provide the displayed filter text

> On Lug. 9, 2015, 10:02 a.m., Aleix Pol Gonzalez wrote: > > What's the use case? > > Elvis Angelaccio wrote: > Basically more user-friendly messages for the users. > See RR 120204 and in particular this screenshot: > https://git.reviewboard.kde.org/r/120204/file/2145/ > > Aleix Pol Go

Re: Review Request 124303: KFileWidget: provide the displayed filter text

> On July 9, 2015, 12:02 p.m., Aleix Pol Gonzalez wrote: > > What's the use case? > > Elvis Angelaccio wrote: > Basically more user-friendly messages for the users. > See RR 120204 and in particular this screenshot: > https://git.reviewboard.kde.org/r/120204/file/2145/ > > Aleix Pol Go

Re: Review Request 124303: KFileWidget: provide the displayed filter text

> On Lug. 9, 2015, 10:02 a.m., Aleix Pol Gonzalez wrote: > > What's the use case? > > Elvis Angelaccio wrote: > Basically more user-friendly messages for the users. > See RR 120204 and in particular this screenshot: > https://git.reviewboard.kde.org/r/120204/file/2145/ > > Aleix Pol Go

Re: Review Request 124303: KFileWidget: provide the displayed filter text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124303/ --- (Updated Lug. 9, 2015, 11:29 a.m.) Status -- This change has been di

Review Request 124304: Reduce the KDBusService timeout from 5 minutes to 25 seconds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124304/ --- Review request for KDE Frameworks and David Faure. Repository: kdbusaddon

Re: Review Request 124304: Reduce the KDBusService timeout from 5 minutes to 25 seconds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124304/#review82262 --- +1 makes sense to me. - Aleix Pol Gonzalez On July 9, 2015,

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281/ --- (Updated July 9, 2015, 3:10 p.m.) Review request for KDE Frameworks and M

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281/#review82269 --- src/knotificationmanager.cpp (lines 28 - 29)

Review Request 124306: Don't choke on empty QIconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

> On July 9, 2015, 4 p.m., Kai Uwe Broulik wrote: > > src/knotificationmanager.cpp, lines 28-29 > > > > > > Unused Fixed locally, thanks. - Martin --- T

Re: Review Request 124306: Don't choke on empty QIconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/#review82271 --- src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp (line 137)

Re: Review Request 124306: Don't choke on empty QIconItem

> On jul 9, 2015, 2:22 p.m., Mark Gaiser wrote: > > src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp, line 138 > > > > > > (nitpick) a missing sace. > > img = m_... space* - Mark --

Review Request 124307: Remove Theme tree debug entry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124307/ --- Review request for KDE Frameworks, Antonio Larrosa Jimenez and Christoph Fe

Re: Review Request 124307: Remove Theme tree debug entry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124307/#review82273 --- +1 - Kai Uwe Broulik On Juli 9, 2015, 2:55 nachm., Aleix Po

Re: Review Request 124304: Reduce the KDBusService timeout from 5 minutes to 25 seconds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124304/#review82275 --- also +1 from my side - Milian Wolff On July 9, 2015, 11:48

Re: Review Request 124306: Don't choke on empty QIconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/#review82276 --- Ship it! Ship It! - Sebastian Kügler On July 9, 2015, 2:07

Re: Review Request 124304: Reduce the KDBusService timeout from 5 minutes to 25 seconds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124304/#review82277 --- a clear +1 - not having blocking dbus calls taking 5 minutes i

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124282/ --- (Updated heinä 9, 2015, 10:41 ip) Review request for KDE Frameworks and M