---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124811/
---
(Updated Aug. 20, 2015, 8:07 a.m.)
Review request for KDE Frameworks and
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/ksshaskpass%20Plasma-5.4%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Aug 2015 12:23:33 +
Build duration: 1 min 44 sec
CHANGE SET
No changes
JUNIT RESULTS
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124811/#review84094
---
Ship it!
lgtm, but I don't like that kiconthemes_unittests_se
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124811/#review84095
---
Sorry, still doesn't seem to fix KMail's QIcon::fromTheme() us
> On Aug. 20, 2015, 4:54 p.m., Volker Krause wrote:
> > Sorry, still doesn't seem to fix KMail's QIcon::fromTheme() usage here,
> > hits the disk as before.
IIUC insertion into the persistent cache only happens when actually rendering
the icon, right? I am trying to debug this with KMail, my c
> On ago. 19, 2015, 7:41 p.m., Albert Astals Cid wrote:
> > I meant all the explicit, not only this one, by declaring it explicit we
> > are changing the source compatibility, personally i'd reduce the patch to
> > just the foreach const &
>
> Boris Egorov wrote:
> Ah, I see. So these warn
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124821/#review84113
---
Ship it!
Ship It!
- Albert Astals Cid
On ago. 20, 2015, 3:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124856/
---
Review request for KDE Frameworks and Thiago Macieira.
Repository: kdelib
> On Aug. 19, 2015, 7:41 p.m., Albert Astals Cid wrote:
> > I meant all the explicit, not only this one, by declaring it explicit we
> > are changing the source compatibility, personally i'd reduce the patch to
> > just the foreach const &
>
> Boris Egorov wrote:
> Ah, I see. So these warn
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124821/
---
(Updated Aug. 21, 2015, 3:25 a.m.)
Status
--
This change has been ma
10 matches
Mail list logo