Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

2015-08-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124811/ --- (Updated Aug. 20, 2015, 8:07 a.m.) Review request for KDE Frameworks and

Jenkins-kde-ci: ksshaskpass Plasma-5.4 stable-kf5-qt5 ยป Linux,gcc - Build # 1 - Successful!

2015-08-20 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ksshaskpass%20Plasma-5.4%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Aug 2015 12:23:33 + Build duration: 1 min 44 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

2015-08-20 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124811/#review84094 --- Ship it! lgtm, but I don't like that kiconthemes_unittests_se

Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

2015-08-20 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124811/#review84095 --- Sorry, still doesn't seem to fix KMail's QIcon::fromTheme() us

Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

2015-08-20 Thread Volker Krause
> On Aug. 20, 2015, 4:54 p.m., Volker Krause wrote: > > Sorry, still doesn't seem to fix KMail's QIcon::fromTheme() usage here, > > hits the disk as before. IIUC insertion into the persistent cache only happens when actually rendering the icon, right? I am trying to debug this with KMail, my c

Re: Review Request 124821: karchive: Fix krazy2 warnings (foreach usage)

2015-08-20 Thread Albert Astals Cid
> On ago. 19, 2015, 7:41 p.m., Albert Astals Cid wrote: > > I meant all the explicit, not only this one, by declaring it explicit we > > are changing the source compatibility, personally i'd reduce the patch to > > just the foreach const & > > Boris Egorov wrote: > Ah, I see. So these warn

Re: Review Request 124821: karchive: Fix krazy2 warnings (foreach usage)

2015-08-20 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124821/#review84113 --- Ship it! Ship It! - Albert Astals Cid On ago. 20, 2015, 3:

Review Request 124856: Be a bit stubborn calling newInstance

2015-08-20 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124856/ --- Review request for KDE Frameworks and Thiago Macieira. Repository: kdelib

Re: Review Request 124821: karchive: Fix krazy2 warnings (foreach usage)

2015-08-20 Thread Boris Egorov
> On Aug. 19, 2015, 7:41 p.m., Albert Astals Cid wrote: > > I meant all the explicit, not only this one, by declaring it explicit we > > are changing the source compatibility, personally i'd reduce the patch to > > just the foreach const & > > Boris Egorov wrote: > Ah, I see. So these warn

Re: Review Request 124821: karchive: Fix krazy2 warnings (foreach usage)

2015-08-20 Thread Boris Egorov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124821/ --- (Updated Aug. 21, 2015, 3:25 a.m.) Status -- This change has been ma