Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread Harald Sitter
On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: I've got both Gentoo and Arch saying this causes a major problem [1]: libdraganddropplugin.so changes to draganddropplugin.so in /usr/lib/qt/qml/org/kde/draganddrop and then they don't get loaded. any ideas? Otherwise I'll

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread Harald Sitter
On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: I've got both Gentoo and Arch saying this causes a major problem [1]: libdraganddropplugin.so changes to draganddropplugin.so in /usr/lib/qt/qml/org/kde/draganddrop and then they don't get loaded. any ideas? Otherwise I'll

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84338 --- When built as SHARED as in the current code,

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread David Edmundson
On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: I've got both Gentoo and Arch saying this causes a major problem [1]: libdraganddropplugin.so changes to draganddropplugin.so in /usr/lib/qt/qml/org/kde/draganddrop and then they don't get loaded. any ideas? Otherwise I'll

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread Harald Sitter
On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: I've got both Gentoo and Arch saying this causes a major problem [1]: libdraganddropplugin.so changes to draganddropplugin.so in /usr/lib/qt/qml/org/kde/draganddrop and then they don't get loaded. any ideas? Otherwise I'll

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

2015-08-25 Thread Kevin Funk
On Aug. 24, 2015, 11:18 p.m., Alex Richardson wrote: src/core/slave.cpp, line 89 https://git.reviewboard.kde.org/r/124904/diff/2/?file=397847#file397847line89 Unrelated but while you're touching this code maybe change this to qEnvironmentVariableIsSet(). More efficient and easier

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

2015-08-25 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124904/ --- (Updated Aug. 25, 2015, 7:10 a.m.) Status -- This change has been

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

2015-08-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124904/#review84318 --- Ship it! Ship It! - David Faure On Aug. 24, 2015, 1:11

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-25 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/ --- (Updated Ago. 25, 2015, 7:15 p.m.) Review request for KDE Frameworks and

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-25 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/#review84357 --- I accidentally pushed this, sorry. Could you review? -

Review Request 124916: also make kwindowsystem a module rather than a shared lib

2015-08-25 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124916/ --- Review request for KDE Software on Mac OS X, KDE Frameworks and Hanspeter

Re: Review Request 120443: Add ctags configuration option to highlighting

2015-08-25 Thread Bastian Holst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120443/ --- (Updated Aug. 25, 2015, 8:10 p.m.) Status -- This change has been

Re: Review Request 120443: Add ctags configuration option to highlighting

2015-08-25 Thread Bastian Holst
On Aug. 23, 2015, 12:19 p.m., Dominik Haumann wrote: Hi Bastian, are you still working on this? As it stands, the patch in its current form is proably not going into KTextEditor, as mentioned by Christoph. Are there still parts in this patch that are relevant? If so, can you

Re: Review Request 124916: also make kwindowsystem a module rather than a shared lib

2015-08-25 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124916/#review84329 --- Margin note: While it's great to see that some developers are

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84333 --- I've got both Gentoo and Arch saying this causes a major

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread Harald Sitter
On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: I've got both Gentoo and Arch saying this causes a major problem [1]: libdraganddropplugin.so changes to draganddropplugin.so in /usr/lib/qt/qml/org/kde/draganddrop and then they don't get loaded. any ideas? Otherwise I'll