Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

On Tuesday 15 September 2015 22:50:50 Kurt Hindenburg wrote: > > > On Sep 15, 2015, at 2:07 PM, Marko Käning wrote: > > > > Hi kdesignerplugin devs, > > > > On 14 Sep 2015, at 15:00 , Kurt Hindenburg > > wrote: > >> > >> It appears the QT_VERSION check in > >> d53ec9b97d7b353ea4cce54d5ecae

Re: Review Request 125251: KSycoca optimization: only watch the file if the app connects to databaseChanged()

> On Sept. 15, 2015, 11:36 p.m., Albert Astals Cid wrote: > > src/sycoca/ksycoca.cpp, line 721 > > > > > > Would it make more sense to only add the watcher here? i.e remove the > > watcher code from findDatabase

Re: Review Request 125237: Change KKeyserver (x11) to categorized logging

> On Sept. 15, 2015, 5:35 p.m., Martin Klapetek wrote: > > src/platforms/xcb/kkeyserver.cpp, line 26 > > > > > > If you put into "debug_p.h", then you'll have only one debug > > include instead of two everywhere

Re: Review Request 125252: Clean X11/XCB detection

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125252/#review85477 --- can you please ensure whether kwindowsystem can be built that

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

> On Sep 15, 2015, at 2:07 PM, Marko Käning wrote: > > Hi kdesignerplugin devs, > > On 14 Sep 2015, at 15:00 , Kurt Hindenburg wrote: >> >> It appears the QT_VERSION check in d53ec9b97d7b353ea4cce54d5ecae3c93b933ddd >> is not enough when using Qt 5.4.x > > anyone out there who can fix kdes

Re: Review Request 125251: KSycoca optimization: only watch the file if the app connects to databaseChanged()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125251/#review85472 --- src/sycoca/ksycoca.cpp (line 717)

Review Request 125252: Clean X11/XCB detection

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125252/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 125249: Fix crash when KDirWatch is used in Q_GLOBAL_STATIC.

> On Sept. 15, 2015, 10:42 p.m., Albert Astals Cid wrote: > > +1 makes sense and can confirm modified tests crash without the patch > > > > Will let mpyne give the final ship it (or you can if he takes some time to > > answer) Pushed to make CI green again (this impacts other modules as well,

Re: Review Request 125249: Fix crash when KDirWatch is used in Q_GLOBAL_STATIC.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125249/ --- (Updated Sept. 15, 2015, 11:08 p.m.) Status -- This change has been

Review Request 125251: KSycoca optimization: only watch the file if the app connects to databaseChanged()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125251/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository: kser

Re: Review Request 125249: Fix crash when KDirWatch is used in Q_GLOBAL_STATIC.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125249/#review85470 --- +1 makes sense and can confirm modified tests crash without th

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 63 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/63/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Sep 2015 22:34:53 + Build duration: 1 min 20 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 63 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/63/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Sep 2015 22:34:53 + Build duration: 1 min 20 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Re: Review Request 125220: KService: use a real global static for QThreadStorage rather than Q_GLOBAL_STATIC.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125220/ --- (Updated Sept. 15, 2015, 10:37 p.m.) Status -- This change has been

Re: Review Request 125226: move EventForge from the desktop containment

> On Sept. 15, 2015, 12:06 a.m., David Edmundson wrote: > > src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp, line 51 > > > > > > why do people need to do this? > > Eike Hein wrote: > It basically triggers

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/#review85466 --- src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp (

Re: Review Request 125214: Add support for network shares in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125214/#review85463 --- Ship it! Ship It! - David Faure On Sept. 14, 2015, 10:31 a

Re: Review Request 125243: Trivial CMake corrections for Baloo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125243/#review85460 --- Ship it! Ship It! - Vishesh Handa On Sept. 15, 2015, 5:15

Re: Review Request 125243: Trivial CMake corrections for Baloo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125243/#review85457 --- Ship it! Ship It! - David Faure On Sept. 15, 2015, 5:15 p.

Review Request 125249: Fix crash when KDirWatch is used in Q_GLOBAL_STATIC.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125249/ --- Review request for KDE Frameworks, Albert Astals Cid and Michael Pyne. Re

Re: Review Request 125226: move EventForge from the desktop containment

> On Sept. 15, 2015, 12:06 a.m., David Edmundson wrote: > > src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp, line 51 > > > > > > why do people need to do this? It basically triggers the onCanceled handler in

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 92 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/92/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Sep 2015 19:19:32 + Build duration: 5 min 0 sec CHANGE SET Revision ab177b97e57f8eaae10e27c5bbb0

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 85 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/85/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Sep 2015 19:19:32 + Build duration: 15 sec CHANGE SET Revision ab177b97e57f8eaae10e27c5bbb00cfa8b30c6d4

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

Hi kdesignerplugin devs, On 14 Sep 2015, at 15:00 , Kurt Hindenburg wrote: > > It appears the QT_VERSION check in d53ec9b97d7b353ea4cce54d5ecae3c93b933ddd > is not enough when using Qt 5.4.x anyone out there who can fix kdesignerplugin regarding this version check so that the next KF5 releas

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 15, 2015, 5:32 p.m.) Review request for KDE Frameworks, Pl

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 15, 2015, 5:30 p.m.) Review request for KDE Frameworks, Pl

Review Request 125243: Trivial CMake corrections for Baloo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125243/ --- Review request for KDE Frameworks. Repository: baloo Description --

Re: Review Request 125237: Change KKeyserver (x11) to categorized logging

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125237/#review85451 --- Ship it! src/platforms/xcb/kkeyserver.cpp (line 26)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 92 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/92/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Sep 2015 12:47:00 + Build duration: 5 min 2 sec CHANGE SET Revision 0b015c90380d34e61d27732243b28efef68a0eec by

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 85 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/85/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Sep 2015 12:47:00 + Build duration: 4 min 58 sec CHANGE SET Revision 0b015c90380d34e61d27732243b28efef68

Review Request 125238: [xcb] Consider mods in KKeyServer as initialized on platform != x11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125238/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: SIC/BIC in Frameworks (NOT)

On Tue, Sep 15, 2015 at 12:42 AM, Scarlett Clark wrote: > I guess I forgot to turn back on clean workspace? We were debugging qt5.5. > I > Am so sorry, been traveling home. No worries, it's all fixed now :) > Scarlett Cheers, Ben > > On Sep 14, 2015 12:59 PM, "Ben Cooksley" wrote: >> >> On M

Review Request 125237: Change KKeyserver (x11) to categorized logging

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125237/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 125226: move EventForge from the desktop containment

On Sept. 15, 2015, 12:06 a.m., Marco Martin wrote: > > This class feels like it's just working round Qt bugs? > > > > Other than that if this is long-term useful, we should do sendPress(flags > > buttons, flags modifiers, x, y) not just whatever AppletAppearance happened > > to need (or make i

Re: Review Request 125226: move EventForge from the desktop containment

On Sept. 15, 2015, 12:06 a.m., Marco Martin wrote: > > This class feels like it's just working round Qt bugs? > > > > Other than that if this is long-term useful, we should do sendPress(flags > > buttons, flags modifiers, x, y) not just whatever AppletAppearance happened > > to need (or make i

Re: Review Request 125226: move EventForge from the desktop containment

On Sept. 15, 2015, 12:06 a.m., Marco Martin wrote: > > This class feels like it's just working round Qt bugs? > > > > Other than that if this is long-term useful, we should do sendPress(flags > > buttons, flags modifiers, x, y) not just whatever AppletAppearance happened > > to need (or make i