Re: [OS X] adding a link module to all KF5 targets

2015-09-22 Thread Nicolás Alvarez
2015-09-22 19:28 GMT-03:00 Albert Astals Cid : > El Dimarts, 22 de setembre de 2015, a les 23:04:22, René J.V. Bertin va > escriure: >> On Tuesday September 22 2015 22:35:40 Albert Astals Cid wrote: >> > Shouldn't KF5 work with those sandboxing? I'd expect that KF5 goal is that >> > you can use it

Re: [OS X] adding a link module to all KF5 targets

2015-09-22 Thread René J . V . Bertin
Albert Astals Cid wrote: >> (just a non-default option). But it shouldn't be compulsory for everyone. > > Why not? Because it's an enormous lot of extra work that will lead to equally enormous disk overhead (duplicating everything for each and every application), as well as to applications th

Re: [OS X] adding a link module to all KF5 targets

2015-09-22 Thread Albert Astals Cid
El Dimarts, 22 de setembre de 2015, a les 23:04:22, René J.V. Bertin va escriure: > On Tuesday September 22 2015 22:35:40 Albert Astals Cid wrote: > > Shouldn't KF5 work with those sandboxing? I'd expect that KF5 goal is that > > you can use it in applications that end up in the App Store. > > It

Re: [OS X] adding a link module to all KF5 targets

2015-09-22 Thread René J . V . Bertin
On Tuesday September 22 2015 22:35:40 Albert Astals Cid wrote: > Shouldn't KF5 work with those sandboxing? I'd expect that KF5 goal is that > you > can use it in applications that end up in the App Store. It might be possible that someone will someday write an application that uses (a) KF5 fra

Re: KTabWidget vs QTabWidget

2015-09-22 Thread Luigi Toscano
Jeremy Whiting ha scritto: > In looking at what is using KTabWidget it seems there's a drop in > replacement for what we are doing in > http://lxr.kde.org/source/extragear/office/kile/src/kileviewmanager.h > in DropWidget towards the bottom. Could/should we simply copy that to > kwidgetsaddons and

Re: KTabWidget vs QTabWidget

2015-09-22 Thread Jeremy Whiting
In looking at what is using KTabWidget it seems there's a drop in replacement for what we are doing in http://lxr.kde.org/source/extragear/office/kile/src/kileviewmanager.h in DropWidget towards the bottom. Could/should we simply copy that to kwidgetsaddons and rename it KDropWidgetDecorator and us

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 94 - Still Unstable!

2015-09-22 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/94/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 22 Sep 2015 19:52:04 + Build duration: 15 min CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 89 - Still Unstable!

2015-09-22 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 22 Sep 2015 19:52:00 + Build duration: 15 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: [OS X] adding a link module to all KF5 targets

2015-09-22 Thread Albert Astals Cid
El Dimarts, 22 de setembre de 2015, a les 12:52:46, René J.V. Bertin va escriure: > Hello, > > I'm working on a Mac OS X specific patch that would require adding a small > object (probably a .o file) to the link list for *all* targets that use > KF5. This object contains some logic that flips the

Re: Review Request 125340: Fix crash in UnicodeGroupProber::HandleData with short strings

2015-09-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125340/ --- (Updated Sept. 22, 2015, 7:49 p.m.) Status -- This change has been m

Re: marble builds when it shouldn't

2015-09-22 Thread Scarlett Clark
That is correct. I have turned this off and on so many times it is not funny. Somehow everyone needs to agree on this. Scarlett On Tue, Sep 22, 2015 at 12:24 PM, Jan Kundrát wrote: > On Tuesday, 22 September 2015 13:00:38 CEST, Harald Sitter wrote: > >> Also on a more general note: I think it w

Re: marble builds when it shouldn't

2015-09-22 Thread Jan Kundrát
On Tuesday, 22 September 2015 13:00:38 CEST, Harald Sitter wrote: Also on a more general note: I think it would be handy if all builds used CMAKE_VERBOSE_MAKEFILE=TRUE to get verbose make output which would make it easier to notice when things such as -DNDEBUG are passed to gcc. Absolutely -- t

Re: Icons installed by apps

2015-09-22 Thread Jaroslaw Staniek
On 22 September 2015 at 14:17, Jaroslaw Staniek wrote: > Hello, > A couple of related questions while wrestling with issues such as [1]. > > Let's assume Kexi app installs some icons to > PREFIX/share/kexi/icons/oxygen/32x32/places/ or > PREFIX/share/kexi/icons/breeze/32x32/places. > Can these be

Re: Review Request 124983: Move the desktop files and file templates for the "Create New..." menu from kde-baseapps to kio

2015-09-22 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124983/ --- (Updated Sept. 22, 2015, 4:37 nachm.) Review request for KDE Frameworks a

Re: marble builds when it shouldn't

2015-09-22 Thread Scarlett Clark
Looks like -DCMAKE_BUILD_TYPE=Release was set in Marble. I have removed it so your build should fail as expected. Scarlett On Tue, Sep 22, 2015 at 1:00 PM, Harald Sitter wrote: > ahoy ahoy, > > I have a bit of an unexpected CI outcome on build.kde.org. > > > https://build.kde.org/job/marble%20A

[OS X] adding a link module to all KF5 targets

2015-09-22 Thread René J . V . Bertin
Hello, I'm working on a Mac OS X specific patch that would require adding a small object (probably a .o file) to the link list for *all* targets that use KF5. This object contains some logic that flips the behaviour of a central Qt class which is likely to be used by (almost) all code that depe

marble builds when it shouldn't

2015-09-22 Thread Harald Sitter
ahoy ahoy, I have a bit of an unexpected CI outcome on build.kde.org. https://build.kde.org/job/marble%20Applications-15.08%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/15/consoleFull this build has a suposedly broken commit [1]. The commit fails an assert to do with i18n types [2][3]. But, the

Re: Review Request 124788: Replace std::auto_ptr with std::unique_ptr

2015-09-22 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124788/ --- (Updated Sept. 22, 2015, 10:48 a.m.) Status -- This change has been

Re: Review Request 124788: Replace std::auto_ptr with std::unique_ptr

2015-09-22 Thread Harald Sitter
> On Sept. 22, 2015, 9:54 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > Ship It! pushed. please mark the review as submitted. someone forgot to add the commit trigger, so it won't auto-close XD - Harald --- This is an automaticall

Jenkins-kde-ci: kcodecs master kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

2015-09-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcodecs%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 22 Sep 2015 07:28:11 + Build duration: 2 min 34 sec CHANGE SET Revision 6cf616f47998bedf0c0068cf225799953ad095b

Jenkins-kde-ci: kcodecs master kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

2015-09-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcodecs%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 22 Sep 2015 07:28:11 + Build duration: 2 min 34 sec CHANGE SET Revision 6cf616f47998bedf0c0068cf225799953ad095b

Jenkins-kde-ci: kconfigwidgets master stable-kf5-qt5 » Linux,gcc - Build # 19 - Fixed!

2015-09-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kconfigwidgets%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 22 Sep 2015 07:24:34 + Build duration: 2 min 10 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kconfigwidgets master stable-kf5-qt5 » Linux,gcc - Build # 19 - Fixed!

2015-09-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kconfigwidgets%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 22 Sep 2015 07:24:34 + Build duration: 2 min 10 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 47 - Fixed!

2015-09-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 22 Sep 2015 07:23:57 + Build duration: 11 min CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 47 - Fixed!

2015-09-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 22 Sep 2015 07:23:57 + Build duration: 11 min CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kded master stable-kf5-qt5 » Linux,gcc - Build # 21 - Fixed!

2015-09-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kded%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 22 Sep 2015 07:24:04 + Build duration: 1 min 49 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kded master stable-kf5-qt5 » Linux,gcc - Build # 21 - Fixed!

2015-09-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kded%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 22 Sep 2015 07:24:04 + Build duration: 1 min 49 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kdesignerplugin master stable-kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

2015-09-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdesignerplugin%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 22 Sep 2015 07:23:45 + Build duration: 3 min 53 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kdesignerplugin master stable-kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

2015-09-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdesignerplugin%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 22 Sep 2015 07:23:45 + Build duration: 3 min 53 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 124788: Replace std::auto_ptr with std::unique_ptr

2015-09-22 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124788/#review85738 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On S

Re: Review Request 125343: bump so version from 5 to 6

2015-09-22 Thread Harald Sitter
> On Sept. 22, 2015, 8:31 a.m., John Layt wrote: > > Will have a proper look when I get home tonight, what was the so number > > when released as part of kdepimlibs4? Was it 4 or 5? If 4 then we can stay > > at 5 as KHolidays has never been officially released for KF5? Or will we > > get this

Re: Review Request 125343: bump so version from 5 to 6

2015-09-22 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125343/#review85736 --- Will have a proper look when I get home tonight, what was the

Re: Review Request 124788: Replace std::auto_ptr with std::unique_ptr

2015-09-22 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124788/ --- (Updated Sept. 22, 2015, 8:25 a.m.) Review request for KDE Frameworks and

Re: Review Request 125316: KProtocolManager: fix deadlock when using EnvVarProxy.

2015-09-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125316/ --- (Updated Sept. 22, 2015, 8:22 a.m.) Status -- This change has been m

Re: Review Request 125340: Fix crash in UnicodeGroupProber::HandleData with short strings

2015-09-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125340/#review85735 --- Ship it! Ship It! - David Faure On Sept. 21, 2015, 8:23 p.

Review Request 125343: bump so version from 5 to 6

2015-09-22 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125343/ --- Review request for KDE Frameworks, Daniel Vrátil and John Layt. Repositor

Re: kcodecs failing test

2015-09-22 Thread David Faure
On Monday 21 September 2015 22:02:47 Albert Astals Cid wrote: > This seems like Qt regressed? Not really, rather it didn't progress ;) See #if QT_VERSION <= QT_VERSION_CHECK(5, 5, 0) in the code. I'll turn it into a QEXPECT_FAIL. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working

Re: KTabWidget vs QTabWidget

2015-09-22 Thread David Faure
On Monday 21 September 2015 20:16:01 Jeremy Whiting wrote: > David, > > I've been considering what you mean. I think I understand, but wanted > to check before I spend a bit of time trying to implement what you > described. Does the class below fit what you are considering? > > class KDropWidgetD