Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-09-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/#review86070 --- src/widgets/koverlayiconplugin.desktop (line 3)

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-09-28 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/#review86063 --- src/widgets/koverlayiconplugin.h (line 55)

Re: Review Request 124941: Reparse notification config only when actually needed

2015-09-28 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124941/ --- (Updated Sept. 28, 2015, 6:16 p.m.) Status -- This change has been

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-09-28 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/#review86074 --- src/widgets/koverlayiconplugin.desktop (line 3)

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

2015-09-28 Thread David Faure
On Monday 28 September 2015 01:43:59 Alexander Potashev wrote: > And you can also look at the numbers: KF5 grows at the rate of less > than one framework per month. We probably don't have enough manpower > to review dozens/hundreds of libraries in a short period of time. So you would rather aim

Re: Review Request 124940: Update "config updated" signal

2015-09-28 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124940/ --- (Updated Sept. 28, 2015, 4:16 p.m.) Status -- This change has been

Re: Review Request 125309: Support multiple X servers in the NETWM classes

2015-09-28 Thread Martin Gräßlin
> On Sept. 28, 2015, 2:56 p.m., Martin Gräßlin wrote: > > src/platforms/xcb/netwm_p.h, line 39 > > > > > > I don't like the type name "Atom" as that's also an XLib type. As the > > actual name is hardly used we

Re: Review Request 125309: Support multiple X servers in the NETWM classes

2015-09-28 Thread Thomas Lübking
> On Sept. 28, 2015, 12:56 nachm., Martin Gräßlin wrote: > > src/platforms/xcb/netwm_p.h, line 39 > > > > > > I don't like the type name "Atom" as that's also an XLib type. As the > > actual name is hardly used

Re: Review Request 125309: Support multiple X servers in the NETWM classes

2015-09-28 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125309/ --- (Updated Sept. 28, 2015, 3:45 nachm.) Review request for KDE Frameworks

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

2015-09-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86028 --- The filename not matching the servicetype name in it, is very

Re: Review Request 125290: Refresh Solid's device list before querying in kio_trash

2015-09-28 Thread Bartosz Sławianowski
> On Sept. 26, 2015, 6:41 p.m., David Edmundson wrote: > > do you have commit access? Nope, would be nice if someone else could commit this - Bartosz --- This is an automatically generated e-mail. To reply, visit:

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 106 - Still Unstable!

2015-09-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/106/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Sep 2015 12:05:00 + Build duration: 4 min 41 sec CHANGE SET Revision 9b82d31d66f3c7f831c158d7aa885469c76e967a

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 95 - Still Unstable!

2015-09-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/95/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Sep 2015 10:30:55 + Build duration: 6 min 46 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 98 - Still Unstable!

2015-09-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/98/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Sep 2015 12:05:00 + Build duration: 12 min CHANGE SET Revision 9b82d31d66f3c7f831c158d7aa885469c76e967a

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 90 - Still Unstable!

2015-09-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/90/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Sep 2015 10:30:55 + Build duration: 14 min CHANGE SET Revision

Re: Review Request 125290: Refresh Solid's device list before querying in kio_trash

2015-09-28 Thread Bartosz Sławianowski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125290/ --- (Updated Sept. 28, 2015, 12:04 p.m.) Status -- This change has been

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-09-28 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/ --- (Updated Sept. 28, 2015, 9:14 vorm.) Review request for Dolphin and KDE

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-09-28 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/#review86034 --- Maybe i should return a QList instead of a QStringList? -

Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

2015-09-28 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/ --- Review request for Dolphin and KDE Frameworks. Repository: kio

Re: Review Request 120393: [kdelibs4support] Kill dead code

2015-09-28 Thread Vishesh Handa
> On May 26, 2015, 8:05 p.m., Hrvoje Senjan wrote: > > Ok. Will update diff to kill nepomuk only. What about forwarding headers? > > They are still installed Ping. What's the status on this? - Vishesh --- This is an automatically

Re: Review Request 125309: Support multiple X servers in the NETWM classes

2015-09-28 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125309/#review86036 --- hard cost. I now understand why I didn't get what you meant