Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

> On Oct. 18, 2015, 8:49 a.m., Albert Astals Cid wrote: > > Two more things: > > * I think this should only be done if translators() is empty > > * You should document this is going to fill in KAboutData::translators if > > empty with those values > > Thomas Eschenbacher wrote: > So what

Re: Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125521/#review87050 --- src/kdropwidgetdecorator.h (line 37)

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/ --- (Updated Oct. 19, 2015, 9:08 a.m.) Status -- This change has been ma

Frameworks API documentation links to projects.kde.org

Hi all, As you probably know, projects.kde.org is on it's way out. Can someone please terminate the links from the Frameworks API documentation to projects.kde.org, and have them send people to quickgit.kde.org to browse repositories instead? projects.kde.org is much more server intensive, and a

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

> On Окт. 18, 2015, 10:44 пре п., Albert Astals Cid wrote: > > src/kmainwindow.cpp, line 209 > > > > > > This is not going to work, you need to undefine TRANSLATION_DOMAIN > > include klocalizedstring again and

Re: Review Request 125695: Make KAboutData::translators/setTranslators simple

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125695/#review87086 --- Ship it! Technically I see no other solution. Because tier 1,

Review Request 125705: Use LANG for month names in calendar applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/ --- Review request for KDE Frameworks and Plasma. Bugs: 353715 http://bug

Re: Policy for Dependencies

Hi, > On Sunday, 18 October 2015 14:45:43 BST David Faure wrote: >> On Wednesday 14 October 2015 00:33:17 Christoph Cullmann wrote: >> > Lets see what David thinks about all that. >> >> First: thanks everyone for waiting for my input, I appreciate that (I'm just >> one more voice though, no dicta

Re: Review Request 125164: Fix misbehavior when canceling a job

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/#review87091 --- Is this trying to fix something similar to https://git.review

Re: Review Request 125705: Use LANG for month names in calendar applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/#review87095 --- +1 you won't be able to use this trick for the tooltip date

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/#review87098 --- May as well drop this now, it's largely superceded by code in

Re: Policy for Dependencies

On 2015-10-19 17:53, Christoph Cullmann wrote: On Sunday, 18 October 2015 14:45:43 BST David Faure wrote: 2) A global switch "everything that can be optional, is now optional" sounds strange to me too. If it's optional, it's optional. (The description for the suggested KDE_ENABLE_MINIMAL_DEPEND

Re: Review Request 125658: Do not treat the context menu button as modifier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125658/ --- (Updated Oct. 19, 2015, 7:21 p.m.) Status -- This change has been ma

Review Request 125711: Use deleteLater in Part::slotWidgetDestroyed().

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125711/ --- Review request for KDE Frameworks. Repository: kparts Description -

Re: Frameworks API documentation links to projects.kde.org

On 2015-10-19 10:58, Ben Cooksley wrote: Hi all, As you probably know, projects.kde.org is on it's way out. Can someone please terminate the links from the Frameworks API documentation to projects.kde.org, and have them send people to quickgit.kde.org to browse repositories instead? projects.kd

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/ --- (Updated Oct. 19, 2015, 10:27 p.m.) Review request for KDE Frameworks and

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/ --- (Updated Oct. 19, 2015, 10:32 p.m.) Review request for KDE Frameworks and

Re: Review Request 125695: Make KAboutData::translators/setTranslators simple

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125695/#review87106 --- Ship it! I concur. - Michael Pyne On Oct. 18, 2015, 10:38

Re: Review Request 125681: Correctly set the printSetting's parent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125681/#review87107 --- Ship it! Looks reasonable to me, so I'd implement as long as

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/ --- (Updated Oct. 20, 2015, 2:36 a.m.) Review request for KDE Frameworks, Loc

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/#review87108 --- Though I made the suggested changes I'm now worried we might n

Re: Review Request 125711: Use deleteLater in Part::slotWidgetDestroyed().

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125711/#review87109 --- Ship it! Looks good to me, and I might even backport to KDE 4

Review Request 125717: initialize socket size with correct value

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125717/ --- Review request for KDE Frameworks and Martin Klapetek. Bugs: 351805 h