Re: Review Request 125833: Use QStringLiteral in generated code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125833/#review87712 --- Ping ?:) - Laurent Montel On oct. 28, 2015, 7:32 matin, Lau

Re: Review Request 125874: make kio_http_cache_cleaner deployable in application installer/bundles

> On Oct. 29, 2015, 6:40 p.m., Kevin Funk wrote: > > LGTM. > > > > Let me just say: Great work Christoph! Glad to see somebody working on > > these issues. Thanks :) Just tested on the Mac again (bah, slow compile), with that and the other patch for embedding all .protocols in the slaves, KW

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

> On Oct. 29, 2015, 8:26 p.m., Aleix Pol Gonzalez wrote: > > autotests/kdeplatformtheme_unittest.cpp, line 237 > > > > > > What does `qApp->wheelScrollLines()` return now? > > David Rosca wrote: > It returne

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 151 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/151/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 20:28:44 + Build duration: 6 min 46 sec CHANGE SET Revision c81674366860b1b0accae53ad4d9c3b8acf3afae b

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 151 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/151/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 20:28:44 + Build duration: 6 min 46 sec CHANGE SET Revision c81674366860b1b0accae53ad4d9c3b8acf3afae b

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

> On Oct. 29, 2015, 9:26 p.m., Aleix Pol Gonzalez wrote: > > autotests/kdeplatformtheme_unittest.cpp, line 237 > > > > > > What does `qApp->wheelScrollLines()` return now? > > David Rosca wrote: > It returne

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 144 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/144/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 20:28:44 + Build duration: 6 min 36 sec CHANGE SET Revision c81674366860b1b0accae53ad4d9c3b8acf

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 144 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/144/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 20:28:44 + Build duration: 6 min 36 sec CHANGE SET Revision c81674366860b1b0accae53ad4d9c3b8acf

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

> On Oct. 29, 2015, 8:26 p.m., Aleix Pol Gonzalez wrote: > > autotests/kdeplatformtheme_unittest.cpp, line 237 > > > > > > What does `qApp->wheelScrollLines()` return now? It returned the value I have set in mou

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125877/#review87695 --- autotests/kdeplatformtheme_unittest.cpp (line 237)

Review Request 125877: Fix kdeplatformtheme_unittest after last commit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125877/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Re: Review Request 125164: Finish killed KIO jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/#review87694 --- Reopened because now everyone has the crash I was complaining

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 27 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 19:02:09 + Build duration: 3 min 40 sec CHANGE SET Revision 65af8a044f1d050f5d

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 29 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/29/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 19:02:09 + Build duration: 3 min 44 sec CHANGE SET Revision 65af8a044f1d050f5d68b7a0a

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125863/ --- (Updated Oct. 29, 2015, 7:01 p.m.) Status -- This change has been ma

Review Request 125875: Fix build for Qt < 5.5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125875/ --- Review request for KDE Frameworks. Repository: kauth Description --

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 150 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/150/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 18:36:14 + Build duration: 13 min CHANGE SET Revision 1771412c7cf8a8d07af4fe2687e2a698e409d73b by now

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 143 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/143/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 18:36:14 + Build duration: 6 min 42 sec CHANGE SET Revision 1771412c7cf8a8d07af4fe2687e2a698e4

Re: Review Request 125874: make kio_http_cache_cleaner deployable in application installer/bundles

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125874/#review87690 --- LGTM. Let me just say: Great work Christoph! Glad to see some

Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125691/ --- (Updated Oct. 29, 2015, 6:35 p.m.) Status -- This change has been ma

Re: Review Request 125874: make kio_http_cache_cleaner deployable in application installer/bundles

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125874/ --- (Updated Oct. 29, 2015, 5:21 p.m.) Review request for KDE Frameworks and

Review Request 125874: make kio_http_cache_cleaner deployable in application installer/bundles

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125874/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125863/#review87684 --- Ship it! Ship It! - David Edmundson On Oct. 29, 2015, 4:21

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/ --- (Updated Oct. 29, 2015, 5:03 p.m.) Review request for KDE Frameworks, Ale

Review Request 125869: Convert all io slave .protocol data to json and embed it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/ --- Review request for KDE Frameworks, Alex Richardson and David Faure. Repos

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125863/ --- (Updated Oct. 29, 2015, 4:21 p.m.) Review request for KDE Frameworks. C

Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125863/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Jenkins-kde-ci: kauth master stable-kf5-qt5 » Linux,gcc - Build # 24 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kauth%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 14:23:08 + Build duration: 48 sec CHANGE SET Revision 335ad976ac9f11cd51a838a7ae7dcb38d948bfcf

Re: Review Request 125860: Handle proxying qInfo messages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125860/ --- (Updated Oct. 29, 2015, 2:22 p.m.) Status -- This change has been ma

Re: Review Request 125859: Wait for async call starting helper to finish before checking the reply

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125859/ --- (Updated Oct. 29, 2015, 2:22 p.m.) Status -- This change has been ma

Re: Review Request 125860: Handle proxying qInfo messages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125860/#review87670 --- Ship it! Ship It! - Martin Gräßlin On Oct. 29, 2015, 2:59

Re: Review Request 125859: Wait for async call starting helper to finish before checking the reply

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125859/#review87669 --- Ship it! looks correct to me. Nice spot! - Martin Gräßlin

Review Request 125860: Handle proxying qInfo messages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125860/ --- Review request for KDE Frameworks. Repository: kauth Description --

Review Request 125859: Wait for async call starting helper to finish before checking the reply

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125859/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kauth

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 149 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/149/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 12:35:33 + Build duration: 6 min 50 sec CHANGE SET Revision 22b4cc54e1ecdc4dce89dbe2ba81de4b9786754a

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 142 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/142/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 12:35:33 + Build duration: 13 min CHANGE SET Revision 22b4cc54e1ecdc4dce89dbe2ba81de4b9786754a

Re: Review Request 125164: Finish killed KIO jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/ --- (Updated Oct. 29, 2015, 12:35 p.m.) Status -- This change has been m

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 141 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/141/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 10:58:58 + Build duration: 6 min 32 sec CHANGE SET Revision cbdef04fce58713ebeb18992c447a87db68

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 141 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/141/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 10:58:58 + Build duration: 6 min 32 sec CHANGE SET Revision cbdef04fce58713ebeb18992c447a87db68

Re: Review Request 125830: Read protocol info from plugin metadata

> On Oct. 29, 2015, 7:57 a.m., David Faure wrote: > > src/core/kprotocolinfofactory.cpp, line 90 > > > > > > You can ensure that by adding > > Q_ASSERT(!m_mutex.tryLock()); > > > > (this is a tric

Re: Review Request 125830: Read protocol info from plugin metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125830/ --- (Updated Oct. 29, 2015, 10:58 a.m.) Status -- This change has been m

Re: Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 140 - Unstable!

Hmmm, the second build did succeed (for master). And it works locally :/ Will see if that happens again after my next push. Greetings Christoph - Am 29. Okt 2015 um 10:00 schrieb no-re...@kde.org: > GENERAL INFO > > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/kio%20master%20st

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 140 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/140/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Oct 2015 08:19:17 + Build duration: 15 min CHANGE SET Revision e2a4517f099d809bd53c6a10769ebfddc0f28a8b

Re: [kdeclarative] src/quickaddons: fix ciritical regression for QuickViewSharedEngine by commit 3792923639b1c480fd622f7d4d31f6f888c925b9

On Thursday 22 October 2015 00:08:55 Takahiro Hashimoto wrote: > Git commit 1c3f42afe17cc090372eaf45647d71495de12c19 by Takahiro Hashimoto. > Committed on 22/10/2015 at 00:03. > Pushed by hashimoto into branch 'master'. > > fix ciritical regression for QuickViewSharedEngine by commit > 3792923639

Re: Jenkins-kde-ci: kxmlgui master kf5-qt5 » Linux, gcc - Build # 33 - Unstable!

On Thu, Oct 29, 2015 at 9:14 PM, David Faure wrote: > On Thursday 22 October 2015 00:35:59 no-re...@kde.org wrote: >> >> GENERAL INFO >> >> BUILD UNSTABLE >> Build URL: >> https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ > > https://build.kde.org/job/kxmlgui%20

Re: Review Request 125778: Allow local kioslave deployment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125778/ --- (Updated Oct. 29, 2015, 8:18 a.m.) Status -- This change has been ma

Re: Jenkins-kde-ci: kxmlgui master kf5-qt5 » Linux, gcc - Build # 33 - Unstable!

On Thursday 22 October 2015 00:35:59 no-re...@kde.org wrote: > > GENERAL INFO > > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/console Why d

Re: Review Request 125164: Finish killed KIO jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/#review87562 --- Ship it! Fix looks good, but the unittest can be cleaned up f

Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125691/#review87646 --- Ship it! Ship It! - David Faure On Oct. 18, 2015, 4:09 p.m

Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

> On Oct. 27, 2015, 8 a.m., David Faure wrote: > > src/widgets/kopenwithdialog.cpp, line 970 > > > > > > This else should be removed, then. > > > > There's no reason to only set m_pService when mimetype

Re: Review Request 125830: Read protocol info from plugin metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125830/#review87644 --- Ship it! src/core/kprotocolinfofactory.cpp (line 79)

Re: Review Request 125778: Allow local kioslave deployment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125778/#review87642 --- Ship it! Ship It! - David Faure On Oct. 26, 2015, 4:56 p.m