Re: Review Request 126038: Add protocol info to KIO plugin metadata

2015-11-12 Thread Andrew McCann
> On Nov. 12, 2015, 4:12 p.m., Christoph Cullmann wrote: > > Hi, > > > > I did the same in https://git.reviewboard.kde.org/r/125869/ but I still > > need to fix the i18n issue, first :/ Ahh, indeed you did. Should I abandon this? or do I 'add' it to yours? somehow.. I'm new to reviewboard.

Re: Frameworks API documentation broken

2015-11-12 Thread Allen Winter
On Wednesday, November 11, 2015 11:54:40 PM Alex Merry wrote: > On 2015-11-11 14:15, Allen Winter wrote: > > On Wednesday, November 11, 2015 08:13:17 AM Allen Winter wrote: > >> On Wednesday, November 11, 2015 11:33:17 AM Martin Graesslin wrote: > >> > Hi all, > >> > > >> > I just wanted to raise

Re: Review Request 126047: Don't add extra KDE SNI actions in our systemtray qpt plugin

2015-11-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126047/#review88310 --- shouldn't we just delete the code? Qt nowadays does SNI and

Review Request 126047: Don't add extra KDE SNI actions in our systemtray qpt plugin

2015-11-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126047/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository:

Re: Review Request 126047: Don't add extra KDE SNI actions in our systemtray qpt plugin

2015-11-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126047/#review88306 --- +1 - Martin Klapetek On Nov. 12, 2015, 8:24 p.m., David

Re: Review Request 126038: Add protocol info to KIO plugin metadata

2015-11-12 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126038/#review88300 --- Hi, I did the same in