Re: Review Request 125974: Make KTar KCompressionDevice-friendly

2015-11-24 Thread David Faure
On Monday 23 November 2015 12:11:12 Luiz Romário Santana Rios wrote: > 2015-11-21 21:02 GMT-03:00 David Faure : > > > > This is an automatically generated e-mail. To reply, visit: > > https://git.reviewboard.kde.org/r/125974/ > > > > On November 7th, 2015, 9:25 a.m. UTC, David

Re: Review Request 126140: [kfilemetadata] avoid utf16->utf8->utf16 conversions reading taglib metadata

2015-11-24 Thread Nick Shaforostoff
> On Nov. 24, 2015, 10:12 p.m., David Faure wrote: > > Looks good, but should be two different commits of course. > > > > Would this have been caught by -DQT_NO_CAST_FROM_ASCII? no, i used this conversion in my pet project for organizing tango music collection and just wondered if

Re: Review Request 126161: OS X housekeeping

2015-11-24 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/#review88776 --- Also, as I just observed: ``` > kwrapper5

Re: Review Request 126161: OS X housekeeping

2015-11-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/#review88779 --- src/kdeinit/CMakeLists.txt (line 15)

Re: Review Request 126140: [kfilemetadata] avoid utf16->utf8->utf16 conversions reading taglib metadata

2015-11-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126140/#review88774 --- Ship it! Looks good, but should be two different commits of

Review Request 126161: OS X housekeeping

2015-11-24 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/ --- Review request for KDE Software on Mac OS X and KDE Frameworks.

Re: Review Request 126140: [kfilemetadata] avoid utf16->utf8->utf16 conversions reading taglib metadata

2015-11-24 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126140/ --- (Updated Nov. 24, 2015, 11:05 p.m.) Status -- This change has been

Re: Review Request 126161: OS X housekeeping

2015-11-24 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/#review88782 --- src/kdeinit/kdeinit5_proxy.cpp (line 1)

Re: Review Request 126161: OS X housekeeping

2015-11-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/#review88784 --- src/kdeinit/kinit.cpp (line 1619)

Jenkins-kde-ci: ki18n master stable-kf5-qt5 » Linux,gcc - Build # 33 - Fixed!

2015-11-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ki18n%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 24 Nov 2015 17:35:03 + Build duration: 1 min 18 sec CHANGE SET Revision

Jenkins-kde-ci: ki18n master stable-kf5-qt5 » Linux,gcc - Build # 33 - Fixed!

2015-11-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ki18n%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 24 Nov 2015 17:35:03 + Build duration: 1 min 18 sec CHANGE SET Revision

Jenkins-kde-ci: ki18n master kf5-qt5 » Linux,gcc - Build # 28 - Fixed!

2015-11-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 24 Nov 2015 17:35:03 + Build duration: 1 min 26 sec CHANGE SET Revision 7ec383bddf836f6af5eb63b5d113462eaa1f1bc6

Jenkins-kde-ci: ki18n master kf5-qt5 » Linux,gcc - Build # 28 - Fixed!

2015-11-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 24 Nov 2015 17:35:03 + Build duration: 1 min 26 sec CHANGE SET Revision 7ec383bddf836f6af5eb63b5d113462eaa1f1bc6

Re: [Kde-pim] [kf5-]gpgmepp

2015-11-24 Thread René J . V . Bertin
Andre Heinecke wrote: >> Fine with me, but pray tell, are we going to see each and every point >> release from 15.08.04 onwards until then? ;) > > Afaik it will just be part of the normal releases. [...] Is this a problem > for you? I can't say I like it when there are frequent version bumps

Jenkins-kde-ci: ki18n master stable-kf5-qt5 » Linux,gcc - Build # 32 - Still Unstable!

2015-11-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ki18n%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/32/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 24 Nov 2015 16:26:48 + Build duration: 1 min 20 sec CHANGE SET Revision

Jenkins-kde-ci: ki18n master kf5-qt5 » Linux,gcc - Build # 27 - Still Unstable!

2015-11-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/27/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 24 Nov 2015 16:26:48 + Build duration: 1 min 45 sec CHANGE SET Revision

Re: [Kde-pim] [kf5-]gpgmepp

2015-11-24 Thread Andre Heinecke
Hi, On Tuesday 24 November 2015 10:27:08 René J. V. Bertin wrote: > Andre Heinecke wrote: > > We won't get there before 15.12 though, probably start of 2016. > > Fine with me, but pray tell, are we going to see each and every point > release from 15.08.04 onwards until then? ;) Afaik it will

Re: kdeinit5 on OS X

2015-11-24 Thread David Faure
On Monday 23 November 2015 13:29:23 René J.V. Bertin wrote: > Hi, > > Preparing a MacPorts port for kf5-kinit, I see the following in kdeinit's > CMake file: > > add_executable(kdeinit5 ${kdeinit_SRCS}) > if (APPLE) > # this has to be GUI on OSX because it launches GUI

Re: kdeinit5 on OS X

2015-11-24 Thread René J . V . Bertin
David Faure wrote: > I thought app bundles led to more GUI initializations than non-app bundles, > and clearly the person writing the above (Benjamin Reed, CC'ed) found that to > be true as well, at least back then. Yeah, that used to be true, question is to what extent that is still the case.

Re: Review Request 126161: OS X housekeeping

2015-11-24 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/ --- (Updated Nov. 25, 2015, 12:03 a.m.) Review request for KDE Software on

Re: [kf5-]gpgmepp

2015-11-24 Thread Andre Heinecke
Hi, On Tuesday 24 November 2015 08:57:26 Daniel Vrátil wrote: > On Monday, November 23, 2015 1:09:25 PM CET René J.V. Bertin wrote: > > Hi, > > > > Quick question: gpgmepp is a dependency for kwallet, albeit an optional > > one > > (still not without importance I guess). Why is it part of

Re: [kf5-]gpgmepp

2015-11-24 Thread René J . V . Bertin
Andre Heinecke wrote: > We won't get there before 15.12 though, probably start of 2016. Fine with me, but pray tell, are we going to see each and every point release from 15.08.04 onwards until then? ;) R ___ Kde-frameworks-devel mailing list

Re: Review Request 126110: Clean up and armour Baloo::Database::open()

2015-11-24 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126110/#review88751 --- Ship it! src/engine/database.cpp (line 73)

Re: Review Request 126152: Fly away from QString::isNull() in favor of isEmpty()

2015-11-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126152/ --- (Updated Nov. 24, 2015, 3:05 p.m.) Status -- This change has been

Jenkins-kde-ci: ki18n master stable-kf5-qt5 » Linux,gcc - Build # 31 - Still Unstable!

2015-11-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ki18n%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 24 Nov 2015 15:06:13 + Build duration: 2 min 20 sec CHANGE SET Revision

Jenkins-kde-ci: ki18n master kf5-qt5 » Linux,gcc - Build # 26 - Still Unstable!

2015-11-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/26/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 24 Nov 2015 15:06:13 + Build duration: 2 min 9 sec CHANGE SET Revision 9c17965a56b83b3fd34b1eefcd915823ec546f76

Re: Review Request 126110: Clean up and armour Baloo::Database::open()

2015-11-24 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126110/ --- (Updated Nov. 24, 2015, 11:42 a.m.) Status -- This change has been

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-24 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/ --- (Updated Nov. 24, 2015, 11:53 a.m.) Status -- This change has been

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-24 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88756 --- Since there has been no negative comments from the

Re: Review Request 126110: Clean up and armour Baloo::Database::open()

2015-11-24 Thread Boudhayan Gupta
> On Nov. 24, 2015, 4:20 p.m., Vishesh Handa wrote: > > src/engine/database.cpp, line 73 > > > > > > Please remove the comment. It's not longer valid. We still are checking if the index exists and bailing out

Re: [KDE/Mac] OS X : org.kde.klauncher5 was not provided by any .service files

2015-11-24 Thread René J . V . Bertin
On Tuesday November 24 2015 21:45:35 Ian Wadham wrote: Hi Ian, >> I only see "org.kde.XXX' references in the CMake files and in the source, so >> where do the "kf5_org.kde.XXX" files come from -- not because I have KDE4 >> equivalents installed I hope? >> How is kdeinit_exec_wait supposed to

Re: Review Request 126152: Fly away from QString::isNull() in favor of isEmpty()

2015-11-24 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126152/#review88755 --- Ship it! Ship It! - Chusslove Illich On Нов. 24, 2015,

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-24 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88757 --- You commited it to wrong branch.. should be Plasma/5.5 then

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-24 Thread Boudhayan Gupta
> On Nov. 24, 2015, 5:32 p.m., Bhushan Shah wrote: > > You commited it to wrong branch.. should be Plasma/5.5 then master. Pushed master first, sorry :-D - Boudhayan --- This is an automatically generated e-mail. To reply, visit: