Re: Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126461/#review89861 --- Ship it! Ship It! - David Edmundson On Dec. 21, 2015,

Re: Review Request 126409: Fix use-after-free in .desktop file parser

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126409/ --- (Updated Dec. 21, 2015, 7:41 p.m.) Status -- This change has been

Review Request 126459: Add a hint to skip notifications grouping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126459/ --- Review request for KDE Frameworks. Repository: knotifications

Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126461/ --- Review request for KDE Frameworks and Plasma. Bugs: 356653

Re: Review Request 126426: Add a warning color to kwalletd's password dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126426/#review89846 --- +1, looks good to me. - Martin Klapetek On Dec. 19, 2015,

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 11:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the

Re: Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126461/ --- (Updated Dec. 21, 2015, 9:56 p.m.) Review request for KDE Frameworks and

Re: Review Request 125619: Refactor KNewPasswordDialog class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/#review89853 --- btw I would suggest using a message widget for the error

Re: Review Request 126459: Add a hint to skip notifications grouping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126459/#review89857 --- Ship it! - David Edmundson On Dec. 21, 2015, 8:18 p.m.,

Re: Review Request 126426: Add a warning color to kwalletd's password dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126426/#review89877 --- As already said in the other review request: The field should

Re: Review Request 126149: [Icon widget] Bring back properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/ --- (Updated Dez. 21, 2015, 11:31 nachm.) Review request for KDE Frameworks

Re: Review Request 126453: Fix library order

> On Dec. 21, 2015, 5:33 p.m., Hrvoje Senjan wrote: > > A public header here (DownloadWidget) includes QWidget > > Kevin Funk wrote: > Qt5::Widgets is still in PUBLIC scope Oops, i could swear i've seen it moved into PRIVATE section. Ignore. - Hrvoje

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126343/ --- (Updated Dec. 21, 2015, 9:45 a.m.) Review request for KDE Frameworks.

Re: Review Request 126453: Fix library order

> On Dec. 21, 2015, 4:33 p.m., Hrvoje Senjan wrote: > > A public header here (DownloadWidget) includes QWidget Qt5::Widgets is still in PUBLIC scope - Kevin --- This is an automatically generated e-mail. To reply, visit:

Re: about ki18n/locales: installing only a subset?

>> [: Chusslove Illich :] >> I'm talking about coming to a random office in the world and finding my >> language already available, without trifling anyone about it. > > [: René J.V. Bertin :] > Out of curiosity: do you expect to use your language when communicating > with people instead of

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 10:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 11:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the

Re: Review Request 126409: Fix use-after-free in .desktop file parser

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126409/#review89808 --- Ship it! Ship It! - Alex Richardson On Dec. 18, 2015,

Re: Review Request 126423: KPluginSelector::addPlugins: do not assert if 'config' parameter is null

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126423/ --- (Updated Dec. 21, 2015, 8:55 a.m.) Status -- This change has been

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126343/#review89815 --- Ship it! My nitpicks have been resolved, a weak +1 from my

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126418/#review89816 --- Ship it! Ship It! - Sebastian Kügler On Dec. 18, 2015,

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126230/ --- (Updated Dec. 21, 2015, 1:04 p.m.) Status -- This change has been

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review89823 --- bump? - Aleix Pol Gonzalez On Dec. 15, 2015, 4:24 p.m.,

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 10:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the

Re: Review Request 126453: Fix library order

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126453/#review89837 --- A public header here (DownloadWidget) includes QWidget -

Review Request 126455: Add mutex round static QRegExp usage in KShorturifilter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126455/ --- Review request for KDE Frameworks. Bugs: 352356

Re: Review Request 126455: Add mutex round static QRegExp usage in KShorturifilter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126455/#review89836 --- src/urifilters/shorturi/kshorturifilter.cpp (line 295)

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 10:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 10:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the

Review Request 126453: Fix library order

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126453/ --- Review request for KDE Frameworks, Heiko Becker and Jeremy Whiting.