Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-29 Thread Kai Uwe Broulik
> On Dez. 29, 2015, 11:56 nachm., Ken Vermette wrote: > > In regards to the message displayed (as mentioned in your G+ post) how > > about: > > > > "Sorry for the inconvenience. Please report the error to help improve this > > software." > > Kai Uwe Broulik wrote: > I'm quite indifferent

Re: Review Request 126555: Remove unused variable in KConfigPrivate

2015-12-29 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126555/ --- (Updated Dec. 30, 2015, 12:38 a.m.) Status -- This change has been m

Re: Review Request 126556: Ensure group is unescaped properly in kconf_update.

2015-12-29 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126556/ --- (Updated Dec. 30, 2015, 12:35 a.m.) Status -- This change has been m

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-29 Thread Kai Uwe Broulik
> On Dez. 29, 2015, 11:56 nachm., Ken Vermette wrote: > > In regards to the message displayed (as mentioned in your G+ post) how > > about: > > > > "Sorry for the inconvenience. Please report the error to help improve this > > software." I'm quite indifferent on the wording: http://wstaw.org

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-29 Thread Ken Vermette
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90316 --- In regards to the message displayed (as mentioned in your G+ p

Re: Review Request 126516: Add StatusNotifier flag

2015-12-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126516/ --- (Updated Dez. 29, 2015, 11:09 nachm.) Status -- This change has been

Re: Review Request 126568: [KNotifyConfigWidget] Allow selecting a specific event

2015-12-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126568/ --- (Updated Dez. 29, 2015, 10:58 nachm.) Review request for KDE Frameworks,

Review Request 126568: [KNotifyConfigWidget] Allow selecting a specific event

2015-12-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126568/ --- Review request for KDE Frameworks, Martin Klapetek and Olivier Goffart. R

Re: Review Request 126459: Add a hint to skip notifications grouping

2015-12-29 Thread Martin Klapetek
> On Dec. 29, 2015, 10:50 p.m., Kai Uwe Broulik wrote: > > src/knotification.h, line 251 > > > > > > This must be 0x10! > > > > 0x10 = 0b1 (one bit set) > > > > 0x22 = 0b10110 (multiple bits

Re: Review Request 126459: Add a hint to skip notifications grouping

2015-12-29 Thread Kai Uwe Broulik
> On Dez. 29, 2015, 9:50 nachm., Kai Uwe Broulik wrote: > > src/knotification.h, line 251 > > > > > > This must be 0x10! > > > > 0x10 = 0b1 (one bit set) > > > > 0x22 = 0b10110 (multiple bit

Re: Review Request 126459: Add a hint to skip notifications grouping

2015-12-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126459/#review90310 --- src/knotification.h (line 251)

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- (Updated Dez. 29, 2015, 9:19 nachm.) Review request for KDE Frameworks, P

Re: Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification

2015-12-29 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126461/ --- (Updated Dec. 29, 2015, 8:12 p.m.) Status -- This change has been ma

Re: Review Request 126459: Add a hint to skip notifications grouping

2015-12-29 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126459/ --- (Updated Dec. 29, 2015, 8:07 p.m.) Status -- This change has been ma

Re: Review Request 126348: Make it possible to provide the metadata in json

2015-12-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review90303 --- Ship it! Ship It! - Marco Martin On Dec. 15, 2015, 3:24 p.

Re: Review Request 126348: Make it possible to provide the metadata in json

2015-12-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review90302 --- Ship it! Ship It! - Sebastian Kügler On Dec. 15, 2015, 3:2

Re: Review Request 126149: [Icon widget] Bring back properties dialog

2015-12-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/#review90298 --- I completely screwed up my Kate desktop files :( Would it help

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 207 - Fixed!

2015-12-29 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/207/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 29 Dec 2015 14:42:29 + Build duration: 1 min 55 sec CHANGE SET Revisi

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 207 - Fixed!

2015-12-29 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/207/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 29 Dec 2015 14:42:29 + Build duration: 1 min 55 sec CHANGE SET Revisi

Re: Review Request 125536: Remove unused variable warnings

2015-12-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125536/#review90277 --- Related: https://git.reviewboard.kde.org/r/126429/ - Aleix Po

Re: Review Request 125536: Remove unused variable warnings

2015-12-29 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125536/#review90276 --- ping? - Albert Astals Cid On oct. 5, 2015, 10:41 p.m., Albe

Re: Review Request 126556: Ensure group is unescaped properly in kconf_update.

2015-12-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126556/#review90275 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 29, 2015, 6

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 185 - Still Unstable!

2015-12-29 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/185/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 29 Dec 2015 11:24:13 + Build duration: 11 min CHANGE SET Revision 03db921e68d7fbdcd5d05cd6a14193ff2a2e75b5

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 193 - Still Unstable!

2015-12-29 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/193/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 29 Dec 2015 11:24:13 + Build duration: 5 min 20 sec CHANGE SET Revision 03db921e68d7fbdcd5d05cd6a14193ff2a2e75b5

Re: Review Request 126555: Remove unused variable in KConfigPrivate

2015-12-29 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126555/#review90274 --- Ship it! Ship It! - Albert Astals Cid On des. 29, 2015, 5:

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 29, 2015, 9:34 a.m.) Status -- This change has been ma