Review Request 126724: Expose callingUser in HelperSupport if available

2016-01-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126724/ --- Review request for KDE Frameworks, Dario Freddi and David Edmundson.

Re: Review Request 126712: Make kcookiejar accessible under the dbus service name org.kde.kcookiejar5.

2016-01-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126712/ --- (Updated Jan. 12, 2016, 8:12 a.m.) Status -- This change has been

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread Matthias Klumpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/#review90956 --- Patch looks good - normally I would say that the build-deps

Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/ --- Review request for KDE Frameworks, David Edmundson, Hrvoje Senjan, and

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread Martin Gräßlin
> On Jan. 12, 2016, 10:43 a.m., Matthias Klumpp wrote: > > Patch looks good - normally I would say that the build-deps need to be > > bumped to request an appropriate Polkit version (0.113), but e.g. Debian > > backports this change to the older 0.105 release - and that seems to be > > quite

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread Hrvoje Senjan
> On Jan. 12, 2016, 10:43 a.m., Matthias Klumpp wrote: > > Patch looks good - normally I would say that the build-deps need to be > > bumped to request an appropriate Polkit version (0.113), but e.g. Debian > > backports this change to the older 0.105 release - and that seems to be > > quite

Re: Review Request 126692: Provide a DBus service file for org.kde.kpasswdserver

2016-01-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126692/ --- (Updated Jan. 12, 2016, 8:12 a.m.) Status -- This change has been

Re: Review Request 126696: kssld: install DBus service file for org.kde.kssld5

2016-01-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126696/ --- (Updated Jan. 12, 2016, 8:12 a.m.) Status -- This change has been

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread Martin Gräßlin
> On Jan. 12, 2016, 10:43 a.m., Matthias Klumpp wrote: > > Patch looks good - normally I would say that the build-deps need to be > > bumped to request an appropriate Polkit version (0.113), but e.g. Debian > > backports this change to the older 0.105 release - and that seems to be > > quite

Review Request 126727: [plasmaquick/dialog] Don't use KWindowEffects for Notification window type

2016-01-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126727/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 126725: prevent crash-on-exit in KSelectAction::~KSelectAction

2016-01-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126725/#review90980 --- Can I see the backtrace, with a description of how this gets

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

2016-01-12 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126624/ --- (Updated Jan. 12, 2016, 10:40 p.m.) Review request for KDE Software on

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread Martin Gräßlin
> On Jan. 12, 2016, 10:43 a.m., Matthias Klumpp wrote: > > Patch looks good - normally I would say that the build-deps need to be > > bumped to request an appropriate Polkit version (0.113), but e.g. Debian > > backports this change to the older 0.105 release - and that seems to be > > quite

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 206 - Unstable!

2016-01-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/206/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 12 Jan 2016 12:07:33 + Build duration: 7 min 21 sec CHANGE SET Revision f7b58166bd9cd5957534af65f10bb9bb7f897e2d

Review Request 126725: prevent crash-on-exit in KSelectAction::~KSelectAction

2016-01-12 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126725/ --- Review request for KDE Frameworks and Christoph Feck. Repository:

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread Hrvoje Senjan
> On Jan. 12, 2016, 10:43 a.m., Matthias Klumpp wrote: > > Patch looks good - normally I would say that the build-deps need to be > > bumped to request an appropriate Polkit version (0.113), but e.g. Debian > > backports this change to the older 0.105 release - and that seems to be > > quite

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/#review90970 --- core/polkitqt1-subject.cpp (line 184)

Re: Review Request 126724: Expose callingUser in HelperSupport if available

2016-01-12 Thread Dario Freddi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126724/#review90973 --- Ship it! As long as the additional dependency does not cause

Re: Review Request 126724: Expose callingUser in HelperSupport if available

2016-01-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126724/#review90971 --- Ship it! looks good, thanks for this patch. note given my

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 207 - Fixed!

2016-01-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/207/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 12 Jan 2016 22:26:10 + Build duration: 5 min 37 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 207 - Fixed!

2016-01-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/207/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 12 Jan 2016 22:26:10 + Build duration: 5 min 37 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Re: Review Request 126727: [plasmaquick/dialog] Don't use KWindowEffects for Notification window type

2016-01-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126727/#review90976 --- Ship it! Ship It! - David Edmundson On Jan. 12, 2016,

Re: Review Request 126725: prevent crash-on-exit in KSelectAction::~KSelectAction

2016-01-12 Thread René J . V . Bertin
> On Jan. 12, 2016, 10:49 p.m., David Faure wrote: > > Can I see the backtrace, with a description of how this gets triggered? I'm > > not sure the issue is fully understood (as shown by the use of "might" in > > the description...). > > > > Is the action being destroyed by clicking into a

KIOGui ?

2016-01-12 Thread David Faure
I'm about to write a class to handle favicons in a KIO library, rather than using DBus communication to a (currently kded, could be kiod otherwise) module. I think there just isn't any point in using a central DBus module to handle a shared cache when a lock file can do the job. The question

Re: KIOGui ?

2016-01-12 Thread Kai Uwe Broulik
Hi, I think there are many more features in KIO that aren't really widget-dependant, so +1 for that, though we probably cannot move them anymore now. Cheers,  Kai Uwe ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: KIOGui ?

2016-01-12 Thread Aleix Pol
On Wed, Jan 13, 2016 at 12:33 AM, David Faure wrote: > I'm about to write a class to handle favicons in a KIO library, rather than > using DBus > communication to a (currently kded, could be kiod otherwise) module. > > I think there just isn't any point in using a central DBus