Re: kconfig question

2016-01-17 Thread Boudewijn Rempt
On Sun, 17 Jan 2016, Matthew Dawson wrote: It appears this is the desired behaviour. On most platforms, GenericConfigLocation and ConfigLocation are the same things, except Windows. According to Qt's history, ConfigLocation was supposed to act like GenericConfigLocation, but a mistake was made

Re: kconfig question

2016-01-17 Thread Matthew Dawson
On Friday, January 15, 2016 9:46:00 AM EST Boudewijn Rempt wrote: > I noticed that krita on windows wrote its kritarc to Roaming\local\ or > Local\local instead of Roaming\krita\kritarc, and I was wondering why that > was. I now think it's because KConfig's default is to write to > GenericConfigLoc

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-01-17 Thread Sergey Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/ --- (Updated Янв. 17, 2016, 8:50 п.п.) Review request for KDE Frameworks, Pla

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-01-17 Thread Sergey Popov
> On Янв. 11, 2016, 12:38 п.п., Sebastian Kügler wrote: > > src/declarativeimports/core/corebindingsplugin.cpp, line 77 > > > > > > QString()? > > Aleix Pol Gonzalez wrote: > +1 That was an automated change

Re: Review Request 126740: Add a script for optimizing svgs

2016-01-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/ --- (Updated Jan. 17, 2016, 9:15 p.m.) Review request for KDE Frameworks and

Re: Review Request 126772: Fix some Clazy warnings in KService

2016-01-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126772/#review91217 --- Please fix those, just some nitpicking. Otherwise, +1. src

Re: QSP patch/activator

2016-01-17 Thread René J . V . Bertin
On Monday January 11 2016 18:58:08 David Faure wrote: Sorry for the silence, I'm trying to force myself to devote my attention to other things that should have priority right now. > We can get cohesion without subclassing QApplication, that's for sure. The question is how. I'm not saying it's i

Re: Review Request 126764: Workaround for leading slash returned by QUrl::toDisplayString(QUrl::PreferLocalFile) untill fixed in Qt

2016-01-17 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126764/#review91214 --- I have a fix: https://codereview.qt-project.org/#/c/145963/

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

2016-01-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126595/ --- (Updated Jan. 17, 2016, 12:02 p.m.) Status -- This change has been m

Re: Review Request 125869: Allows protocoltojson & kio to handle translated json ExtraNames

2016-01-17 Thread Christoph Cullmann
> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original