Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the

Re: Review Request 126934: Reduce use of gettext API.

2016-02-02 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126934/ --- (Updated Feb. 2, 2016, 8:03 a.m.) Status -- This change has been

Review Request 126963: New class FavIconRequestJob in new lib KIOGui, for favicons retrieval.

2016-02-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126963/ --- Review request for KDE Frameworks, Kevin Ottens, Laurent Montel, and Sune

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Kai Uwe Broulik
> On Feb. 1, 2016, 8:12 nachm., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > >

Re: Review Request 126969: KRecursiveFilterProxyModel::match: Fix crash

2016-02-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126969/#review91959 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 2,

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Thomas Pfeiffer
> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > >

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Thomas Pfeiffer
> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > >

Review Request 126969: KRecursiveFilterProxyModel::match: Fix crash

2016-02-02 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126969/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Boudhayan Gupta
> On Feb. 2, 2016, 1:42 a.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > >

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme Then we got some fixing to do as this is how Air looks like here: http://paste.opensuse.org/view/raw/6071be9f (also notice the bottom frame of the controls) I

Re: Review Request 126969: KRecursiveFilterProxyModel::match: Fix crash

2016-02-02 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126969/#review91958 --- Ship it! Ship It! - Milian Wolff On Feb. 2, 2016, 2:42

Re: Review Request 126969: KRecursiveFilterProxyModel::match: Fix crash

2016-02-02 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126969/ --- (Updated Feb. 2, 2016, 8:41 p.m.) Status -- This change has been

Re: Review Request 126963: New class FavIconRequestJob in new lib KIOGui, for favicons retrieval.

2016-02-02 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126963/#review91922 --- autotests/CMakeLists.txt (line 50)

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/#review91924 --- maybe not oxygen, but i want to point out that i *do*

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 1, 2016, 8:12 p.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > >

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread andreas kainz
> On Feb. 1, 2016, 8:12 nachm., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > >

Re: Review Request 126945: Don't call exec() from QML

2016-02-02 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126945/#review91935 --- src/workspace/settings/imports/dialog.cpp (line 142)

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 173 - Still Unstable!

2016-02-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/173/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 02 Feb 2016 10:51:41 + Build duration: 7 min 0 sec CHANGE SET Revision

Re: Review Request 126963: New class FavIconRequestJob in new lib KIOGui, for favicons retrieval.

2016-02-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126963/ --- (Updated Feb. 2, 2016, 11:46 a.m.) Review request for KDE Frameworks,

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 178 - Still Unstable!

2016-02-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/178/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 02 Feb 2016 10:51:41 + Build duration: 15 min CHANGE SET Revision

Re: Review Request 126945: Don't call exec() from QML

2016-02-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126945/ --- (Updated Feb. 2, 2016, 12:11 p.m.) Review request for KDE Frameworks.

Re: Review Request 126945: Don't call exec() from QML

2016-02-02 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126945/#review91941 --- Ship it! A couple of nit-picks: - kactivities reviews

Re: Review Request 126945: Don't call exec() from QML

2016-02-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126945/ --- (Updated Feb. 2, 2016, 5:23 a.m.) Status -- This change has been

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Martin Klapetek
> On Feb. 2, 2016, 10:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread andreas kainz
> On Feb. 2, 2016, 9:17 vorm., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:17 a.m., Marco Martin wrote: > > maybe not oxygen, but i want to point out that i *do* maintain the Air theme > > Martin Klapetek wrote: > Then we got some fixing to do as this is how Air looks like here: > http://paste.opensuse.org/view/raw/6071be9f (also notice the

Re: Review Request 126955: Fix crash in activities context menu

2016-02-02 Thread David Edmundson
> On Feb. 2, 2016, 7:49 a.m., David Faure wrote: > > Looks correct, although IMHO it's the code that creates a class, that > > should decide how it should get deleted, rather than the class itself > > deciding that (same reason why for widgets, WA_DeleteOnClose should be set > > after new,

Re: Review Request 126955: Fix crash in activities context menu

2016-02-02 Thread Ivan Čukić
> On Feb. 2, 2016, 7:49 a.m., David Faure wrote: > > Looks correct, although IMHO it's the code that creates a class, that > > should decide how it should get deleted, rather than the class itself > > deciding that (same reason why for widgets, WA_DeleteOnClose should be set > > after new,

Re: Review Request 126955: Fix crash in activities context menu

2016-02-02 Thread David Faure
> On Feb. 2, 2016, 7:49 a.m., David Faure wrote: > > Looks correct, although IMHO it's the code that creates a class, that > > should decide how it should get deleted, rather than the class itself > > deciding that (same reason why for widgets, WA_DeleteOnClose should be set > > after new,