Re: Review Request 126774: Fix many warnings presented by clazy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126774/#review92601 --- src/core/kprotocolinfofactory.cpp (line 114)

Re: Review Request 127077: kio_http: read and discard body after a 404 with errorPage=false.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127077/#review92593 --- Still reviewing... I think this is a regression caused by

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 235 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/235/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 20 Feb 2016 20:41:30 + Build duration: 5 min 56 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 235 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/235/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 20 Feb 2016 20:41:30 + Build duration: 5 min 56 sec CHANGE SET Revision

Re: Review Request 127121: KWallet::openWallet(Synchronous) : time out after 1 hour rather than 25 seconds.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127121/ --- (Updated Feb. 20, 2016, 8:48 p.m.) Review request for KDE Frameworks and

Re: Review Request 126774: Fix many warnings presented by clazy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126774/ --- (Updated Feb. 20, 2016, 8:41 p.m.) Status -- This change has been

Re: Review Request 127121: KWallet::openWallet(Synchronous) : time out after 1 hour rather than 25 seconds.

> On Feb. 20, 2016, 8:25 p.m., Andreas Hartmetz wrote: > > Sorry for being the guy who says "I don't like this improvement because > > it's still not perfect"... > > Why have a timeout at all and not, for example, retry after getting a > > timeout error? (A long timeout still makes sense to

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 234 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/234/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 20 Feb 2016 19:26:29 + Build duration: 6 min 9 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 244 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/244/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 20 Feb 2016 19:26:29 + Build duration: 6 min 22 sec CHANGE SET Revision 9d1158274f49aa824521310d1413455f050a8195

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 244 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/244/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 20 Feb 2016 19:26:29 + Build duration: 6 min 22 sec CHANGE SET Revision 9d1158274f49aa824521310d1413455f050a8195

Re: Review Request 127121: KWallet::openWallet(Synchronous) : time out after 1 hour rather than 25 seconds.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127121/#review92589 --- Sorry for being the guy who says "I don't like this

Re: Review Request 126774: Fix many warnings presented by clazy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126774/#review92588 --- autotests/http/httpheaderdispositiontest.cpp (line 118)

Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127111/#review92587 --- src/filewidgets/kurlnavigator.h (line 425)

Re: Review Request 127127: KOpenWithDialog: show mimetype name and comment in "Remember" checkbox text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127127/ --- (Updated Feb. 20, 2016, 7:07 p.m.) Review request for KDE Frameworks.

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 243 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/243/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 20 Feb 2016 17:51:03 + Build duration: 6 min 50 sec CHANGE SET Revision 9bd9a949a9203b0bc67436eaf74540cca58efca1

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 233 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/233/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 20 Feb 2016 17:51:03 + Build duration: 7 min 42 sec CHANGE SET Revision

Review Request 127127: KOpenWithDialog: show mimetype name and comment in "Remember" checkbox text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127127/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 127077: kio_http: read and discard body after a 404 with errorPage=false.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127077/ --- (Updated Feb. 20, 2016, 5:50 p.m.) Status -- This change has been

Re: Review Request 127076: kio_http: fix mimetype determination when URL ends with '/'.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127076/ --- (Updated Feb. 20, 2016, 5:50 p.m.) Status -- This change has been

Re: Review Request 127093: Drop KDocTools requirement

> On Feb. 18, 2016, 11:37 p.m., Albert Astals Cid wrote: > > Why is suddenty documentation less important than the rest? Do you even get > > a hint saying you must install kdoctools to get documetnation or it > > silently skips it? Documentation is very important. However there are use cases

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

On Saturday, 20 February 2016, Anthony Fieroni wrote: > This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127122/ > Review request for Kate and KDE Frameworks. > By Anthony Fieroni. > Repository: kate > > Description > > Show prev/next

Re: Review Request 127121: KWallet::openWallet(Synchronous) : time out after 1 hour rather than 25 seconds.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127121/ --- (Updated Feb. 20, 2016, 2:16 p.m.) Review request for KDE Frameworks and

Re: Proposal for moving KColorScheme from KConfigWidgets to KGuiAddons

Thanks, that's actually the consequence I completely oversaw... With this in mind, I am coming to the same conclusion. Considering the alternatives, the only somehow reasonable solution IMO would be to move KColorScheme "up" to KIconThemes. However, that place looks similar "unfitting" for

Re: Proposal for moving KColorScheme from KConfigWidgets to KGuiAddons

On Saturday 20 February 2016 11:22:48 Andreas Cord-Landwehr wrote: > Hi, I want to propose to move the KColorScheme class from the KConfigWidgets > famework to the KGuiAddons framework. Impossible, this would require adding a dependency on KConfig for KGuiAddons. > Reasons: > * that would

Review Request 127122: [Kate] Back/Forward mouse buttons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127122/ --- Review request for Kate and KDE Frameworks. Repository: kate

Re: Review Request 126940: Move .protocol files of all io slaves bundled in kio to JSON meta data

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126940/#review92579 --- Ship it! (assuming the unittests pass and the typo

Re: KMenu aboutToShowContextMenu KF5 porting options: None. Do we care?

On Monday 01 February 2016 20:07:20 Albert Astals Cid wrote: > El Monday 01 February 2016, a les 08:39:22, David Faure va escriure: > > On Monday 01 February 2016 00:43:27 Albert Astals Cid wrote: > > > In the kdelibs4 world one could connect to KMenu aboutToShowContextMenu > > > signal to add

Review Request 127121: KWallet::openWallet(Synchronous) : time out after 1 hour rather than 25 seconds.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127121/ --- Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet

Proposal for moving KColorScheme from KConfigWidgets to KGuiAddons

Hi, I want to propose to move the KColorScheme class from the KConfigWidgets famework to the KGuiAddons framework. Reasons: * that would reduce dependencies of KIconThemes and make it - a Tier 2 framework (currently Tier 3) and - make it easier to use KIconThemes on Android * KGuiAddons

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/#review92576 --- Ship it! Ship It! - David Faure On Feb. 9, 2016, 9:53