Re: Jenkins and XDG_DATA_DIRS

On Saturday, March 19, 2016 10:27:38 PM CET David Faure wrote: > It appears that something regressed in the jenkins setup. > > Almost all of the current failures in the "Frameworks kf5-qt5" group come > from XDG_DATA_DIRS not being set up correctly anymore, I think. > E.g. in > https://build.kde.o

Re: Review Request 127383: Avoid introspecting a DBus interface when we don't use it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127383/ --- (Updated March 20, 2016, 11:15 p.m.) Status -- This change has been

Re: Qt 5.6/QtWebkit (got it, now to build it)

René J. V. Bertin wrote: > I presume there must be at least one member on this list who managed to > build QtWebKit 5.6.0 (and remembers how)? See https://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/qt5-webkit Besides generating headers with syncqt.pl, you need

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 324 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/324/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 20 Mar 2016 21:51:45 + Build duration: 2 min 37 sec CHANGE SET Revis

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 326 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/326/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 20 Mar 2016 21:51:45 + Build duration: 2 min 30 sec CHANGE SE

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 324 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/324/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 20 Mar 2016 21:51:45 + Build duration: 2 min 36 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 326 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/326/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 20 Mar 2016 21:51:45 + Build duration: 3 min 11 sec CHANGE SET Re

Re: Raising Qt requirement to Qt 5.4

On Wed, Mar 16, 2016 at 1:13 PM, Martin Graesslin wrote: > Hi all, > > with todays release of Qt 5.6 I suggest that we raise the minimum Qt version > requirement to 5.4. This would mean the latest three releases are supported. > > The important new features in Qt 5.4 in my opinion for frameworks d

Re: Review Request 127415: Set the appropriate feature test macro definitions to enable building on musl libc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127415/ --- (Updated March 20, 2016, 3:12 p.m.) Status -- This change has been m

Re: Review Request 127415: Set the appropriate feature test macro definitions to enable building on musl libc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127415/ --- (Updated March 20, 2016, 3:08 p.m.) Status -- This change has been m

Review Request 127437: Fix many threading issues in KUrlCompletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127437/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On March 20, 2016, 12:21 p.m., Thomas Lübking wrote: > > except that it's effectively an editable combobox? > > > > _NET_WM_WINDOW_TYPE_COMBO should be used on the windows that are popped up > > by combo boxes. An example is a window that appears below a text field with > > a list of suggest

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On March 20, 2016, 12:29 p.m., Anthony Fieroni wrote: > > Please, be sure this works as expected on Linux. Works on Linux as expected (no change in behavior noticeable). - Dominik --- This is an automatically generated e-mail. To repl

Re: Qt 5.6/QtWebkit

Aleix Pol wrote: > > https://code.qt.io/cgit/qt/qtwebkit.git/ Right, thanks, I'd seen that one too (there's also a clone on github but it isn't clear how recent/unmodified that one is). What I didn't yet see is if there's a way to do tarball fetches from code.qt.io that correspond to a speci

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127424/#review93783 --- Please, be sure this works as expected on Linux. - Anthony F

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127424/#review93780 --- except that it's effectively an editable combobox? _NET_WM_W

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127424/ --- (Updated März 20, 2016, 12:06 nachm.) Review request for KDE Frameworks,

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 325 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/325/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 20 Mar 2016 11:00:53 + Build duration: 2 min 17 sec CHANGE SE

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 325 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/325/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 20 Mar 2016 11:00:53 + Build duration: 2 min 51 sec CHANGE SET Re

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 323 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/323/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 20 Mar 2016 11:00:53 + Build duration: 2 min 7 sec CHANGE SET Revisi

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 323 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/323/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 20 Mar 2016 11:00:53 + Build duration: 2 min 29 sec CHANGE SET Revision

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On March 19, 2016, 1:22 p.m., Thomas Lübking wrote: > > "Loose focus" is the complete wrong concept anyway. > > It makes kickoff and various other plasmashell elements barely usable w/ > > any but the click-to-focus policy (implicit hide) > > > > Try adding Qt::FramelessWindowHint (Qt::X11Byp

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 255 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/255/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 20 Mar 2016 09:33:52 + Build duration: 5 min 52 sec CHANGE SET Revision 850a4ea8bbeea9165638affe5067a9469a

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 270 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/270/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 20 Mar 2016 09:33:52 + Build duration: 5 min 51 sec CHANGE SET Revision 850a4ea8bbeea9165638affe5067a9469ac6f7a9

Re: Review Request 127415: Set the appropriate feature test macro definitions to enable building on musl libc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127415/#review93766 --- Ship it! Ship It! - David Faure On March 20, 2016, 10:1

Re: Review Request 127415: Set the appropriate feature test macro definitions to enable building on musl libc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127415/ --- (Updated March 20, 2016, 10:14 a.m.) Review request for KDE Frameworks.

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

> On March 17, 2016, 1:29 p.m., Aleix Pol Gonzalez wrote: > > Change looks good. > > > > Would it be possible to get a test? > Would it be possible to get a test? autotest (is it allowed to show a dialog in KF autotests?) or more like kpropertiesdialogtest? - Emmanuel

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126618/#review93761 --- Ship it! Ship It! - David Faure On March 11, 2016, 8:19

Re: Review Request 125965: Add declarative plugin to KHolidays

> On Nov. 6, 2015, 2:29 p.m., Nick Shaforostoff wrote: > > src/declarative/holidayregionsmodel.cpp, line 81 > > > > > > i suggest enclosing strings into QByteArrayLiteral. > > > > see http://woboq.com/blo

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On März 20, 2016, 4:22 vorm., Anthony Fieroni wrote: > > src/kcompletionbox.cpp, line 282 > > > > > > After show, call activateWindow(), even you can call raise() The window shall *not* be activated. One could

Re: Equivalent of KDE::version*()?

On Monday 15 June 2015 22:23:17 Jaroslaw Staniek wrote: > Hi, > One would need a need runtime version information of particular kf5 > libraries -- in addition to version with which the software has been > built. > > It seems that mostly Plasma and KActivities have equivalent of runtime > version i

Re: Review Request 127383: Avoid introspecting a DBus interface when we don't use it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127383/#review93758 --- Ship it! + generating code ensures we use the methods defi

Re: Raising Qt requirement to Qt 5.4

> > The important new features in Qt 5.4 in my opinion for frameworks > > development > > are: > > * QSignalSpy(const QObject *object, PointerToMemberFunction signal) > > * Q_LOGGING_CATEGORY(name, string, msgType) >  > + QTimer::singleShot(timeout, receiver, PointerToMemberFunction) > + QVector:

Re: Review Request 127380: More conservative approach to saving some disk accesses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127380/#review93756 --- autotests/kiconloader_benchmark.cpp (line 82)

Re: Raising Qt requirement to Qt 5.4

On Wednesday 16 March 2016 13:13:36 Martin Graesslin wrote: > Hi all, > > with todays release of Qt 5.6 I suggest that we raise the minimum Qt version > requirement to 5.4. This would mean the latest three releases are supported. > > The important new features in Qt 5.4 in my opinion for framewo

Re: Review Request 127391: Require Qt 5.4 and remove version ifdefs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127391/#review93754 --- Ship it! Ship It! - David Faure On March 16, 2016, 12:1

Re: Review Request 127415: Set the appropriate feature test macro definitions to enable building on musl libc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127415/#review93753 --- Fix it, then Ship it! Tested with glibc, didn't lead to mu

Jenkins-kde-ci: kemoticons master kf5-qt5 » Linux,gcc - Build # 47 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kemoticons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 20 Mar 2016 09:03:22 + Build duration: 1 min 22 sec CHANGE SET Revision 5901b41b8ca431c6da5389d098aca6b7bc5

Re: Raising Qt requirement to Qt 5.4

On Friday 18 March 2016 20:16:05 Ivan Čukić wrote: > Hi all, > > IIRC, the last time we talked about this we decided (I'll try to find > the e-mail thread when I get back home, IIRC the conclusion was by > dfaure) on KF5 always support the two last versions of Qt. This was > decided so that we do

Re: Review Request 127428: KEmoticons: fix crash when loadProvider fails for some reason.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127428/ --- (Updated March 20, 2016, 9:03 a.m.) Status -- This change has been m

Re: oxygen icon name clasheroo

On Wednesday 16 March 2016 15:57:45 Harald Sitter wrote: > Hola! > > Our most awesome icon maintainers wanted to carry over icon symlinking > from breeze to oxygen, alas that turned up a whole slew of > compatibility problems. > > examples: > https://bugs.kde.org/show_bug.cgi?id=360605 > https://

Jenkins-kde-ci: kemoticons master stable-kf5-qt5 » Linux,gcc - Build # 48 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kemoticons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/48/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 20 Mar 2016 09:03:22 + Build duration: 2 min 2 sec CHANGE SET Revision 5901b41b8ca431c6da5389d098aca

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 203 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/203/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 18 Mar 2016 13:10:48 + Build duration: 6 min 8 sec CHANGE SET Revision 4c9c4524f0f7f5ff564a4764eda414b598e

Re: Review Request 127406: Fix encoding for gap.xml (use UTF-8)

> On März 17, 2016, 7:46 vorm., Kevin Funk wrote: > > Ship It! sorry to be late here, but please increase the version number in the language element. otherwise internal caches are not rebuilt... - Dominik --- This is an automatically g

Review Request 127391: Require Qt 5.4 and remove version ifdefs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127391/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Qt 5.6/QtWebkit

On 17/03/16 03:59, René J. V. Bertin wrote: > Aleix Pol wrote: > > >> >> https://code.qt.io/cgit/qt/qtwebkit.git/ > > Right, thanks, I'd seen that one too (there's also a clone on github but it > isn't clear how recent/unmodified that one is). > > What I didn't yet see is if there's a way to d