Re: Review Request 127632: Prioritize correct extension per theme

2016-04-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/ --- (Updated April 12, 2016, 1:17 a.m.) Review request for KDE Frameworks and

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-11 Thread Aleix Pol Gonzalez
> On April 12, 2016, 12:44 a.m., Albert Astals Cid wrote: > > I'm unconvinced, actually the spec mentions order to be "Changed search > > order to png, svg, xpm" > > Albert Astals Cid wrote: > > https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html I see, I di

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-11 Thread Albert Astals Cid
> On April 11, 2016, 10:44 p.m., Albert Astals Cid wrote: > > I'm unconvinced, actually the spec mentions order to be "Changed search > > order to png, svg, xpm" https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html - Albert -

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/#review94547 --- I'm unconvinced, actually the spec mentions order to be "Chan

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/#review94546 --- Ship it! Ship It! - David Edmundson On April 10, 2016,

Re: official guidelines on the install location of cmake modules?

2016-04-11 Thread Stephen Kelly
René J.V. Bertin wrote: > I've stumbled upon the importance of that location for at least 2 > libraries (grantlee and mobipocket); their cmake modules determine the > installation prefix dynamically, using the install location of those same > modules. IOW, those modules have to be installed into $

Re: Review Request 126161: OS X housekeeping

2016-04-11 Thread David Faure
> On April 10, 2016, 8:31 a.m., David Faure wrote: > > I liked what I was seeing in this patch until I got to the horrible > > code duplication introduced by kinit_mac.mm. This is not the way to go. > > Yes #ifdefs are a pain, but code duplication is 1000 times worse. In Qt, > > the _mac.m

Re: Misbehavior when unloading KStyle

2016-04-11 Thread Andreas Hartmetz
On Freitag, 8. April 2016 17:25:06 CEST Aleix Pol wrote: > On Fri, Apr 8, 2016 at 3:42 PM, Andreas Hartmetz wrote: > > On Donnerstag, 7. April 2016 20:33:19 CEST Andreas Hartmetz wrote: > >> On Mittwoch, 6. April 2016 20:10:53 CEST Aleix Pol wrote: > >> > Hi, > >> > I've seen a couple of times su

Re: Review Request 126161: OS X housekeeping

2016-04-11 Thread René J . V . Bertin
> On April 10, 2016, 10:31 a.m., David Faure wrote: > > I liked what I was seeing in this patch until I got to the horrible > > code duplication introduced by kinit_mac.mm. This is not the way to go. > > Yes #ifdefs are a pain, but code duplication is 1000 times worse. In Qt, > > the _mac.

Review Request 127635: use QSettings::IniFormat

2016-04-11 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127635/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Re: [sonnet] about the QSettings format

2016-04-11 Thread René J . V . Bertin
On Monday April 11 2016 09:44:26 Martin Sandsmark wrote: Morning, It seems I was a bit confused. I posted this question because I had to introduce a new patch to force the use of IniFormat, but that was not in Sonnet itself but for some new setting in KTextWidgets :-/ Same question/principle a

Re: [sonnet] about the QSettings format

2016-04-11 Thread Martin Sandsmark
Hi! On Sun, Apr 10, 2016 at 07:33:38PM +0200, David Faure wrote: > Hmm we already care for backwards compatibility on Windows and OSX ? Well, we shouldn't? Sonnet is at least used by Quassel on Windows AFAIK, and probably (hopefully) others. But if you don't think it is something that we need to

Re: [sonnet] about the QSettings format

2016-04-11 Thread Martin Sandsmark
Hi! On Sun, Apr 10, 2016 at 11:23:58AM +0200, David Faure wrote: > On Friday 01 April 2016 15:03:10 René J. V. Bertin wrote: > > Wasn't it decided a while ago (5.16.0 or so) that frameworks would use > > QSettings::IniFormat and not QSettings::NativeFormat unless they had a very > > good > > re

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/ --- (Updated April 11, 2016, 9:26 vorm.) Status -- This change has been

official guidelines on the install location of cmake modules?

2016-04-11 Thread René J . V . Bertin
Hi, Re-post from the general KDE ML (sorry about that). Is there any official set of guidelines/rules concerning where the cmake modules that come with KDE libraries (incl. the frameworks) can be installed? I've stumbled upon the importance of that location for at least 2 libraries (grantlee

Re: Review Request 127613: Add a test application to render all icons installed on an X11 window

2016-04-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127613/ --- (Updated April 11, 2016, 8:16 a.m.) Status -- This change has been m