Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127236/ --- (Updated April 30, 2016, 3:44 a.m.) Status -- This change has been d

Re: Review Request 127788: Fix leak in KNS::Engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127788/ --- (Updated April 30, 2016, 1:56 a.m.) Status -- This change has been m

Re: Review Request 127655: Fix KAboutData::applicationData() to sync to current Q*Application metadata

> On April 29, 2016, 3:15 a.m., Michael Pyne wrote: > > I think I disagree with the idea of overwriting KAboutData properties if > > they are already set by the user. Alex, any thoughts? > > > > In the event the KAboutData doesn't already exist I think automatically > > setting it up makes sen

Re: Review Request 127788: Fix leak in KNS::Engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127788/#review95033 --- Fix it, then Ship it! src/core/engine.cpp (line 155)

Re: Review Request 127770: Increase maximum string length in KSycoca database

> On apr 28, 2016, 9:12 a.m., Milian Wolff wrote: > > src/sycoca/ksycocautils.cpp, line 29 > > > > > > as a follow-up cleanup I suggest to introduce an enum to hold this > > magic value I can do that if the code

Re: Review Request 127788: Fix leak in KNS::Engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127788/#review95019 --- Ship it! Ship It! - David Edmundson On April 29, 2016,

Review Request 127788: Fix leak in KNS::Engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127788/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstu

Re: Review Request 127786: Remove custom read functions for QString and QStringList

> On apr 29, 2016, 10:56 a.m., David Faure wrote: > > This is not about trust and attacks, this is about not allocating 4 GB of > > RAM when reading a corrupted binary file. > > Jos van den Oever wrote: > That will only happen if the file or stream is 4 GB. `QDataStream > &operator>>(QData

Re: Review Request 127786: Remove custom read functions for QString and QStringList

> On apr 29, 2016, 10:56 a.m., David Faure wrote: > > This is not about trust and attacks, this is about not allocating 4 GB of > > RAM when reading a corrupted binary file. That will only happen if the file or stream is 4 GB. `QDataStream &operator>>(QDataStream &in, QString &str)` allocates

Re: Review Request 127786: Remove custom read functions for QString and QStringList

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127786/#review95012 --- This is not about trust and attacks, this is about not alloca

Review Request 127786: Remove custom read functions for QString and QStringList

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127786/ --- Review request for KDE Frameworks, David Faure and Milian Wolff. Reposito

Jenkins-kde-ci: krunner master kf5-qt5 » Linux,gcc - Build # 37 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/krunner%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/37/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 29 Apr 2016 09:46:24 + Build duration: 9 min 10 sec CHANGE SET Revision af4ef9d77373084da236e34b97ab0965696300

Re: Review Request 127779: use system colors for monochrome icons

> On April 28, 2016, 5:36 p.m., Aleix Pol Gonzalez wrote: > > src/kiconloader.cpp, line 861 > > > > > > We will need that and expose it properly, as we'll have to request the > > icon cache to clean if it's one

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/ --- (Updated April 29, 2016, 9:25 a.m.) Review request for KDE Frameworks and